Genart last call review of draft-ietf-rtgwg-yang-key-chain-17
Matthew Miller <linuxwolf+ietf@outer-planes.net> Fri, 07 April 2017 17:58 UTC
Return-Path: <linuxwolf+ietf@outer-planes.net>
X-Original-To: ietf@ietf.org
Delivered-To: ietf@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F387129552; Fri, 7 Apr 2017 10:58:52 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Matthew Miller <linuxwolf+ietf@outer-planes.net>
To: gen-art@ietf.org
Cc: draft-ietf-rtgwg-yang-key-chain.all@ietf.org, ietf@ietf.org, rtgwg@ietf.org
Subject: Genart last call review of draft-ietf-rtgwg-yang-key-chain-17
X-Test-IDTracker: no
X-IETF-IDTracker: 6.49.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <149158793224.11224.1489071223626497682@ietfa.amsl.com>
Date: Fri, 07 Apr 2017 10:58:52 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/a1on1q5nqc9MloTilT0aBjcEKDQ>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Apr 2017 17:58:52 -0000
Reviewer: Matthew Miller Review result: Almost Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-rtgwg-yang-key-chain-17 Reviewer: Matthew A. Miller Review Date: 2017-04-07 IETF LC End Date: 2017-04-07 IESG Telechat date: 2017-04-13 Summary: This document is almost ready to be published as a Proposed Standard, once the issues noted herein are resolved. Major issues: NONE Minor issues: * Forgive me for my limited knowledge of YANG, but is there a reason key-strings are only representable as either a YANG string or hex-string type, and not the YANG binary type? * This document does not provide much guidance around AES key wrap other than it can be used and the KEK is provided out-of-band/-context. For instance, AES key-wrapped key-strings probably require using "hexidecimal-string". Also, assuming I'm reading the model correctly, it appears this feature applies to the whole chain, which I think is worth calling out. * This document warns against using the "clear-text" algorithm, which the reader is lead to understand is for legacy implementation reasons. However, is there not a similar concern with cryptographically weak algorithms, such as md5 and (arguably) sha1? Nits/editorial comments: * In Section 3.2. "Key Chain Model Features", the word "of" is missing between "configuration" and "an" in the phrase "support configuration an acceptance tolerance". Non-nits: * I note that idnits is calling out some odd spacing issues, but I think they are safe to ignore.
- Re: Genart last call review of draft-ietf-rtgwg-y… Acee Lindem (acee)
- Re: Genart last call review of draft-ietf-rtgwg-y… Matthew A. Miller
- Genart last call review of draft-ietf-rtgwg-yang-… Matthew Miller