Opsdir last call review of draft-ietf-bess-evpn-proxy-arp-nd-04

Joe Clarke <jclarke@cisco.com> Thu, 30 August 2018 13:11 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: ietf@ietf.org
Delivered-To: ietf@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C10A130EF4; Thu, 30 Aug 2018 06:11:06 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joe Clarke <jclarke@cisco.com>
To: ops-dir@ietf.org
Cc: draft-ietf-bess-evpn-proxy-arp-nd.all@ietf.org, ietf@ietf.org, bess@ietf.org
Subject: Opsdir last call review of draft-ietf-bess-evpn-proxy-arp-nd-04
X-Test-IDTracker: no
X-IETF-IDTracker: 6.83.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <153563466646.3197.17486989329935846815@ietfa.amsl.com>
Date: Thu, 30 Aug 2018 06:11:06 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/aVncZKaU5kxg4-wPx0byUY_IpWU>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.27
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Aug 2018 13:11:07 -0000

Reviewer: Joe Clarke
Review result: Has Issues

I have been assigned to do an OPS DIR review of draft-ietf-bess-proxy-arp-nd. 
This document describes how the proxy ARP/ND functions of EVPN can be used to
mitigate the impact of address resolution in large broadcast domains.  While
the text does support the abstract and describes how such proxy functions can
help prevent flooding of broadcast traffic into the EVPNs, I found something
noticeably missing from an operational point of view.  This was especially
apparent since the concept of an ARP-Sponge was also discussed.  That is, one
of the big operational headaches of a large broadcast domain is with negative
ARP/ND (especially ARP).  We actually see this in the IETF conference networks
due to internet backscatter (we might be considered a DC in this regard). 
While the proxy functions can mitigate the positive address resolution, they
will not help with negative caching.  I feel that should be discussed, at least
in the security recommendations, assuming there is not a proposal for adding
capabilities to the EVPN proxy functions to further mitigate this.

An overall nit is that you seem to mix capitalization of various terms like
Ethernet, Proxy-ARP, Layer-2, etc.  It would be good to normalize these for
easier reading.

Other comments and nits on a per-section basis are found below.

Section 2.1:

In general, I found this section lacking when compared with the IXP section
below it.  You describe that large DCs may have a problem with broadcasts, but
that is a known quantity.  What I was expecting is to see more on how this
document is applicable to that scenario like you did with the subsequent IXP
section.

===

Section 4

"When CE3 sends an ARP Request asking for IP1..."

Technically, CE3 is asking for the MAC address of IP1.

===

Section 4.2

s/potential Layer-2 switches seating/potential Layer-2 switches sitting/

===

Section 4.4

You say that a dynamic Proxy-ARP/ND entry SHOULD be flushed.  It MUST be
flushed if the age-time expires.  I think this should be restated applying the
SHOULD to whether or not an age-time is implemented.  IMHO, if an age-time is
implemented, keeping an entry in the table after it has aged out is incorrect
behavior.  An implementation MUST NOT do that.

===

Section 6.5

LAG is not listed in your glossary of abbreviations.

===

Section 7

Typically the conventions section is located at the top of a document, after
the abstract.