RE: Gen-ART review of draft-ietf-bfd-mib-18

"Black, David" <david.black@emc.com> Tue, 29 April 2014 06:00 UTC

Return-Path: <david.black@emc.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4CEEA1A8876; Mon, 28 Apr 2014 23:00:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.352
X-Spam-Level:
X-Spam-Status: No, score=-3.352 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.651, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TGSTr96EXk8U; Mon, 28 Apr 2014 23:00:31 -0700 (PDT)
Received: from mailuogwhop.emc.com (mailuogwhop.emc.com [168.159.213.141]) by ietfa.amsl.com (Postfix) with ESMTP id 269D91A883C; Mon, 28 Apr 2014 23:00:30 -0700 (PDT)
Received: from maildlpprd05.lss.emc.com (maildlpprd05.lss.emc.com [10.253.24.37]) by mailuogwprd03.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s3T60QPg008071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Apr 2014 02:00:28 -0400
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd03.lss.emc.com s3T60QPg008071
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1398751228; bh=cAqupTYVpHhHWClD9b5xnOOQOIg=; h=From:To:CC:Date:Subject:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=W7VZGD6Y738hFaqZHi2lCPSt5KAMLiXZbmpNiC3fCpDcHq3Z/ZNbOwzPQSLeYq7Hb i8XXPQKDVZdiaaP7MAa/vZIifhaYbOoyPoDq9Ge6XzNZMnx9UWEXWjql1YImBSMn0H V7wncUiOuUCSKdGO6fxYDcEuegqm7BI7WQ9av73E=
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd03.lss.emc.com s3T60QPg008071
Received: from mailusrhubprd52.lss.emc.com (mailusrhubprd52.lss.emc.com [10.106.48.25]) by maildlpprd05.lss.emc.com (RSA Interceptor); Tue, 29 Apr 2014 02:00:14 -0400
Received: from mxhub15.corp.emc.com (mxhub15.corp.emc.com [128.222.70.236]) by mailusrhubprd52.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s3T60C17030349 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 29 Apr 2014 02:00:13 -0400
Received: from mx15a.corp.emc.com ([169.254.1.64]) by mxhub15.corp.emc.com ([128.222.70.236]) with mapi; Tue, 29 Apr 2014 02:00:12 -0400
From: "Black, David" <david.black@emc.com>
To: "Nobo Akiya (nobo)" <nobo@cisco.com>, "tnadeau@lucidvision.com" <tnadeau@lucidvision.com>, "Zafar Ali (zali)" <zali@cisco.com>, "General Area Review Team (gen-art@ietf.org)" <gen-art@ietf.org>
Date: Tue, 29 Apr 2014 02:00:05 -0400
Subject: RE: Gen-ART review of draft-ietf-bfd-mib-18
Thread-Topic: Gen-ART review of draft-ietf-bfd-mib-18
Thread-Index: Ac9i7PyERuk5jZsyQOKSHRHy2Ij/LwAG2CxAABnaMYA=
Message-ID: <8D3D17ACE214DC429325B2B98F3AE712076C437EA9@MX15A.corp.emc.com>
References: <8D3D17ACE214DC429325B2B98F3AE712076C437CE3@MX15A.corp.emc.com> <CECE764681BE964CBE1DFF78F3CDD3941E114938@xmb-aln-x01.cisco.com>
In-Reply-To: <CECE764681BE964CBE1DFF78F3CDD3941E114938@xmb-aln-x01.cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd52.lss.emc.com
Archived-At: http://mailarchive.ietf.org/arch/msg/ietf/d1ZRuUsJiWbz-shdtbdofCrY9zU
Cc: "rtg-bfd@ietf.org" <rtg-bfd@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "Black, David" <david.black@emc.com>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Apr 2014 06:00:38 -0000

Hi Nobo,

With respect to the MIB, this concern is a nit, so I'm ok with going ahead without
making this change ...

... However ...

Your WG chairs and AD should be concerned that this significant flaw in
BFD version 0 (justifying a "SHOULD NOT use" recommendation) is undocumented.

Thanks,
--David

> -----Original Message-----
> From: Nobo Akiya (nobo) [mailto:nobo@cisco.com]
> Sent: Monday, April 28, 2014 1:46 PM
> To: Black, David; tnadeau@lucidvision.com; Zafar Ali (zali); General Area
> Review Team (gen-art@ietf.org)
> Cc: rtg-bfd@ietf.org; ietf@ietf.org
> Subject: RE: Gen-ART review of draft-ietf-bfd-mib-18
> 
> Hi David,
> 
> > -----Original Message-----
> > From: Black, David [mailto:david.black@emc.com]
> > Sent: Monday, April 28, 2014 10:20 AM
> > To: tnadeau@lucidvision.com; Zafar Ali (zali); Nobo Akiya (nobo); General
> > Area Review Team (gen-art@ietf.org)
> > Cc: rtg-bfd@ietf.org; ietf@ietf.org; Black, David
> > Subject: RE: Gen-ART review of draft-ietf-bfd-mib-18
> >
> > The -18 version of this draft responds to all of the comments in the Gen-ART
> > review of -17, including the request for coordination w/the OPS area,
> > although I wasn't exactly expecting that to occur on the main IETF list.
> 
> Thanks, they were very good comments.
> 
> >
> > The -18 version is ready with one small nit - The following text has been
> > added to the introduction:
> >
> >    This memo does not define a compliance requirement for a system that
> >
> >    only implements BFD version 0. This is a reflection of a considered
> >    and deliberate decision by the BFD WG.
> >
> > An explanation of the rationale for that decision would help - I suggest
> > adding the following text and a suitable reference to the end of the text
> > above:
> >
> >    because the BFD version 0 protocol may deadlock and hence SHOULD NOT
> >    be used, as explained further in [RFCxxxx].
> 
> Unfortunately the problem with BFD version 0 is not documented in any RFCs,
> and MIB is probably not the right place to start this documentation either. If
> this should be documented in a RFC, possibly a new info document or raise
> errata on RFC5880 ... I'm not sure what would be a reasonable/recommended path
> here. In any case, my vote for the MIB document(s) is to keep the current text
> to proceed. Would that be ok with you?
> 
> -Nobo
> 
> >
> > Thanks,
> > --David
> >
> > > -----Original Message-----
> > > From: Black, David
> > > Sent: Wednesday, April 16, 2014 7:31 PM
> > > To: tnadeau@lucidvision.com; zali@cisco.com; nobo@cisco.com; General
> > > Area Review Team (gen-art@ietf.org)
> > > Cc: rtg-bfd@ietf.org; ietf@ietf.org; Black, David
> > > Subject: Gen-ART review of draft-ietf-bfd-mib-17
> > >
> > > I am the assigned Gen-ART reviewer for this draft. For background on
> > > Gen-ART, please see the FAQ at
> > >
> > > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> > >
> > > Please resolve these comments along with any other Last Call comments
> > > you may receive.
> > >
> > > Document: draft-ietf-bfd-mib-17
> > > Reviewer: David L. Black
> > > Review Date: April 16, 2014
> > > IETF LC End Date: April 28, 2014
> > >
> > > Summary: This draft is on the right track, but has open issues
> > > 		described in the review.
> > >
> > > This draft is a MIB module for the BFD protocol, which is an important
> > > low- level routing protocol.  The draft is reasonable for a MIB draft;
> > > one needs to go read the protocol documents to understand how the
> > > protocol works, and significant portions of the text are derived from the
> > usual MIB "boilerplate"
> > > as one would expect.  The "Brief Description of MIB Objects" is indeed
> > > brief, but reasonable.  The shepherd writeup indicates that there are
> > > multiple implementations.
> > >
> > > Major issues:
> > >
> > > This MIB contains many writable objects, so the authors should take
> > > note of the IESG statement on writable MIB modules:
> > >
> > > 	http://www.ietf.org/iesg/statement/writable-mib-module.html
> > >
> > > I did not see this mentioned in the shepherd writeup.  If the OPS Area
> > > has not been consulted, I strongly suggest doing so during IETF Last
> > > Call, e.g., starting with Benoit Claise (AD).
> > >
> > > Minor issues:
> > >
> > > The security considerations section includes considerations for
> > > unauthorized modification of bfdSessAdminStatus and bfdSessOperStatus,
> > > but omits the corresponding considerations for bfdAdminStatus and
> > > bfdSessNotificationsEnable.  Both of the latter objects are global, so
> > > significant damage can be inflicted via these objects with a small
> > > number of unauthorized modifications, so they need to be included in
> > > the first list of sensitive objects.
> > >
> > > I suggest that the authors recheck the entire MIB to ensure that every
> > > object or table that should be included in the security considerations
> > > section is appropriately included.
> > >
> > > Also, as a General Variable, would bfdSessNotificationsEnable be
> > > better named bfdNotificationsEnable, as it's not in the BFD Session Table?
> > >
> > > I did not see a compliance requirement for a system that only
> > > implements BFD protocol version 0.  That absence should at least be
> > > mentioned somewhere.  For example, if this reflects a considered and
> > > deliberate decision by the WG, that should be mentioned in the
> > > introduction.
> > >
> > > Nits/editorial comments:
> > >
> > > In the security considerations for authentication-related objects:
> > >
> > > OLD
> > >    In order for these sensitive information
> > >    from being improperly accessed, implementers MAY wish to disallow
> > >    access to these objects.
> > > NEW
> > >    In order to prevent this sensitive information
> > >    from being improperly accessed, implementers MAY disallow
> > >    access to these objects.
> > >
> > > idnits 2.13.01 found a truly minor nit that should be corrected when
> > > the draft is next revised:
> > >
> > >   == Outdated reference: A later version (-05) exists of
> > >      draft-ietf-bfd-tc-mib-04
> > >
> > > it also generated a warning that probably does not reflect an actual
> > problem:
> > >
> > >   -- The document seems to lack a disclaimer for pre-RFC5378 work, but
> > may
> > >      have content which was first submitted before 10 November 2008.  If
> > you
> > >      have contacted all the original authors and they are all willing to
> grant
> > >      the BCP78 rights to the IETF Trust, then this is fine, and you can
> ignore
> > >      this comment.  If not, you may need to add the pre-RFC5378
> disclaimer.
> > >      (See the Legal Provisions document at
> > >      http://trustee.ietf.org/license-info for more information.)
> > >
> > > Thanks,
> > > --David
> > > ----------------------------------------------------
> > > David L. Black, Distinguished Engineer EMC Corporation, 176 South St.,
> > > Hopkinton, MA  01748
> > > +1 (508) 293-7953             FAX: +1 (508) 293-7786
> > > david.black@emc.com        Mobile: +1 (978) 394-7754
> > > ----------------------------------------------------
>