Re: Review of draft-ietf-trill-over-ip-08

Donald Eastlake <d3e3e3@gmail.com> Thu, 29 December 2016 17:44 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3D1D129648; Thu, 29 Dec 2016 09:44:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.45
X-Spam-Level:
X-Spam-Status: No, score=-2.45 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UmPbDDsvNOU3; Thu, 29 Dec 2016 09:44:13 -0800 (PST)
Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 31ACC129620; Thu, 29 Dec 2016 09:44:10 -0800 (PST)
Received: by mail-io0-x22f.google.com with SMTP id d9so357016578ioe.0; Thu, 29 Dec 2016 09:44:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=E3l5zrXJn3yzji0E94pPvZ3jnTRPTvApFK/0G4LjRRU=; b=IXTFxW1v9vC6YOMAWhBS2KWv1yJumsPFs07lmf4wCUUV6LYWMMQUjyaZaf0Ld0O0gD ZdB2jHgMckb7Ioo4yxWLSG/3zaM/gBPZmeB3KL4NnDTAvb5NeqT3168+zUjlr01E0qM4 Y4nLmCz95uZ4O4Elw9Ds1nuxV7vULnu+eXyIAlsD3dznBAG/JiVaH8UxGLFxGysEZlv2 93ITCw4UVzFNuENcnGsrYe+6bZ35Hdwpy2JJENGa56BVPY9iIloImVFSl4/OB3mYFihu J3I8WMBEbSyvbvvWEmKqfnDCVgVYbbhxgu7eu4eSFJ4LW0IzBUhmPC6vlY14sDvZtnQP oVdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=E3l5zrXJn3yzji0E94pPvZ3jnTRPTvApFK/0G4LjRRU=; b=jNAdApEVIRrKGeqEDCHlxUt1EXXkEPxr5Q3qEjOj6fUg0AQl2IPc7TATW1dMOtXyYE ePVw0g1x4Tt/+00cLHvc4q5VoGT+lo86WrxYNxg1P5lFRGrt/W8ekQBJdwXKeHnf2T62 eaWfDJ0DE6xanCQcVA60Ev7+W6vlPxZDM4uQtPAX/PylvQOvyE0lypfLH9fTviWeMyD0 bgErOACdl8OH2JM3QQ0wpqs/3kt6qacefG3NtANq9MA5Xlhm5xkzxGsYzaMEYJ3l7DyQ CIoot0dj6jT4vUyrUvpJcOkQDL8z2sVNdjj7b5XsPAcQuzZQYXBdy/b68tyD5WRmd+/L 5HZw==
X-Gm-Message-State: AIkVDXJp67BFYYUNHtO24HCWLR6imTcK5TyufUc/XaCZjbb1+Vpe7soTFe3TQBDqVjafvkRt8OWobqF/6FmqeQ==
X-Received: by 10.107.34.207 with SMTP id i198mr29281489ioi.16.1483033449488; Thu, 29 Dec 2016 09:44:09 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.41.136 with HTTP; Thu, 29 Dec 2016 09:43:54 -0800 (PST)
In-Reply-To: <148290260152.14213.11124890517026127285.idtracker@ietfa.amsl.com>
References: <148290260152.14213.11124890517026127285.idtracker@ietfa.amsl.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Thu, 29 Dec 2016 12:43:54 -0500
Message-ID: <CAF4+nEHVAztPb0Bj+v2A8-F3Qi0xAr0aZOdGz3sxOh4jzFBNvg@mail.gmail.com>
Subject: Re: Review of draft-ietf-trill-over-ip-08
To: Ines Robles <maria.ines.robles@ericsson.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/fYBVuw15yaegU1jABg_fLVCLomg>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, draft-ietf-trill-over-ip.all@ietf.org, IETF Discussion <ietf@ietf.org>, "trill@ietf.org" <trill@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Dec 2016 17:44:15 -0000

Hi Ines,

Thanks for the review. See below:

On Wed, Dec 28, 2016 at 12:23 AM, Ines Robles
<maria.ines.robles@ericsson.com>; wrote:
> Reviewer: Ines Robles
> Review result: Has Nits
>
> Hi,
>
> QA review for "TRILL (Transparent Interconnection of Lots of Links)
> over IP" I-D:
>
>
> Document: draft-ietf-trill-over-ip-08.txt
> Reviewer: Ines Robles
> Review Date: December 28, 2016
> Intended Status: Proposed Standard
>
> Summary:
>  I believe the draft is technically good. I have some minor comments.
>
> Comments:
>
>         Major Issues:
>                 I have no “Major” issues with this I-D.

Thanks.

>         Minor Issues and Nits:
>
>                 Section 1: Introduction
>                         - I would add a reference to [draft-ietf-6man-rfc2460bis-08] when
> IPv6 is mentioned.

OK.

>                 Section 2: Terminology
>                         - In RBridge definition, I would add a reference to [RFC6325]
>                         - In VNI definition, I would extend VXLAN - "...In Virtual
> eXtensible Local Area Network (VXLAN) [RFC7348]..."

OK.

>                 Section 3: Use Cases for TRILL over IP
>                         The text of the uses cases is clear. However, I think it would be
> nice to add a graph for each use case like:
> https://www.ietf.org/proceedings/82/slides/trill-13.pdf (Slide 4 and
> 5)

OK. Thanks for the research to reference that presentation.

>                 Section 4.5: TRILL Over IP IS-IS SubNetwork Point of Attachment
>                         I think it would be nice to add in the text the meaning of "111111"
> depicted in the figure.

Humm... Those are the first digits of vertically arrayed bit numbers
(10 through 15). So, since it would fit, maybe we should make those
bits one character space wider so the bit number can be horizontal
rather than vertical. I think that would be clearer.

>                 Section 8.1: Congestion Considerations
>                         I would expand ECMP in the 3rd paragraph.

OK.

>                 Section 9.2.3.2
>                         I think it would be nice to add a reference to RFC 7172 when
> Inner.FGL is mentioned.

OK.

>                 Section 11.1: Port Assignments
>
>                         I would add the registry for this request - "Service Name and
> Transport Protocol Port Number Registry"
> [https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml]

Good idea.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com

> Thank you very much,
> Ines.