Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

tom petch <ietfa@btconnect.com> Thu, 07 February 2019 11:42 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 98E981310F7; Thu, 7 Feb 2019 03:42:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.106
X-Spam-Level:
X-Spam-Status: No, score=0.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K2ey1-pfkAj8; Thu, 7 Feb 2019 03:42:23 -0800 (PST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20133.outbound.protection.outlook.com [40.107.2.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E6D3C12D4F2; Thu, 7 Feb 2019 03:42:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Dds8i0u5ZsL5mXX7E+DNWhEX0sg0MhGv4/muuQaRps=; b=QxQ5nNz1BxLr96ksQUa0pT/RQVrOg5oFfOSR8iG2/Byh7jlGilJfjq83iVr38n6sHqh+DUEjD7xEoGaX3sdMjNJKYmyEhwM51B96ZlLAybL3Az/1fQEgMtIjTbkFbsCzLPMdslaI3L4OlpkZ1mGR40bAKy8RhEX8KvQqRVLHYLs=
Received: from AM5PR0701MB2321.eurprd07.prod.outlook.com (10.169.152.20) by AM5PR0701MB2945.eurprd07.prod.outlook.com (10.168.156.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.16; Thu, 7 Feb 2019 11:42:20 +0000
Received: from AM5PR0701MB2321.eurprd07.prod.outlook.com ([fe80::9132:55d7:3900:9748]) by AM5PR0701MB2321.eurprd07.prod.outlook.com ([fe80::9132:55d7:3900:9748%4]) with mapi id 15.20.1601.016; Thu, 7 Feb 2019 11:42:20 +0000
From: tom petch <ietfa@btconnect.com>
To: "Tarek Saad (tsaad)" <tsaad@cisco.com>, Jan Lindblad <janl@tail-f.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-teas-yang-te-types.all@ietf.org" <draft-ietf-teas-yang-te-types.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>
Subject: Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
Thread-Topic: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
Thread-Index: AQHUsz7lJhclQK6K6kmMA6C0eS0JwA==
Date: Thu, 7 Feb 2019 11:42:20 +0000
Message-ID: <00c901d4bed9$fdf8aae0$4001a8c0@gateway.2wire.net>
References: <154090780735.15255.3911131220920609603@ietfa.amsl.com> <973699DE-882E-4531-A7D5-32AFEF4359E7@cisco.com> <6CC3CA10-0768-4C99-9237-30A78E1EC3DA@tail-f.com> <BB36593B-0A4E-4F88-A088-3C35BBCAB902@cisco.com> <39E705F8-EE93-4F16-AD3A-39B2E6FCC37E@tail-f.com> <00bc01d4b33e$c42e4d20$4001a8c0@gateway.2wire.net> <B9068E7A-9D15-4F77-A9BF-3B25092DC1CC@cisco.com> <005f01d4bd61$8855f8c0$4001a8c0@gateway.2wire.net> <8009797C-AAFD-46A9-860F-04059D44F6D1@cisco.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LO2P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::32) To AM5PR0701MB2321.eurprd07.prod.outlook.com (2603:10a6:203:d::20)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfa@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Microsoft Outlook Express 6.00.2800.1106
x-originating-ip: [86.139.215.184]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM5PR0701MB2945; 6:CUJpwPzywfduG6XZvLTwrZ7nK6bOMwsbsjTrxFO5LmlXIQDi94OiltP9AjyizU7a+LWCOmYO9R6eRx8TJ2nX831Kkg/fCMTS8XxNsg7WlJEZ2c/GiSdcqoOX00rCBt8mFtPZHE+Apa37mGiVRcfCfPYxhAhEaFnPAtxqFw7iAHMTBm9np6bps6LV0GVcatgOM5ysD5Co8E7D2av3FX4ngNnvs3npVGWau8QllHFCsw0VWQRb0bJDn+8V5HJZMqRpKhe2dhaBj9CiKXofph7MfJq+PBGZV9T6QLrBiJVwOypnfnt0vOM94e9Z7K3j94KUuimVmqtbcpH3cBp9xORMsSvGPbus09/osKUFHb6cZPCinyYKB0cH0aWKlvVC1jh9scdJ/t3J1sPaWku6cCD5IvBWPb2zPcHHk6mQOYFlxBWTOOccQzldqzRb2B/luGdweGQdHLV1MJivjQDndN6M4Q==; 5:jqh2TkZZ6L7cfMaKyUyduv0cIrGuwMHeqmJQr3YIFRxbrCC+CUNsbc69IwEBZEryvKEsp1V6l8wrcKtH2s0I4yVmOqMmiyJ4PXcVjsNYwKHhTTwFy2unj5czjx0u++2gs0y8bwOvZxCHwx2BE3oE5GyawPeeiD+d52elg8h81C6qChrlmrJ5mhB+ftmFWxNMnq0efbwAyAJ4zEEE00WhRA==; 7:AnbBIBCYQ8FtgxuTBWGONV4jNfPUJ/DMYQbBWn47fZEQaFBylUJzJxZhWKccb7vTr70+4X6ABCi+8e9h0JRWm2cOMrdV9dXSyShZiAIE75lU/lBdtt2Y+KcNwcjd8Sir6sRUHKqdcNs5rfJI9xO01Q==
x-ms-office365-filtering-correlation-id: c71d10ab-d7d9-48b9-87e1-08d68cf15161
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7193020); SRVR:AM5PR0701MB2945;
x-ms-traffictypediagnostic: AM5PR0701MB2945:
x-microsoft-antispam-prvs: <AM5PR0701MB294508450C143211157B00ECA2680@AM5PR0701MB2945.eurprd07.prod.outlook.com>
x-forefront-prvs: 0941B96580
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(136003)(366004)(346002)(376002)(396003)(199004)(189003)(43544003)(13464003)(105586002)(61296003)(102836004)(186003)(106356001)(14496001)(66066001)(386003)(6506007)(53546011)(316002)(54906003)(110136005)(1556002)(93886005)(476003)(446003)(486006)(33896004)(26005)(71200400001)(71190400001)(99286004)(14444005)(256004)(81686011)(76176011)(81816011)(52116002)(81166006)(81156014)(8936002)(8676002)(50226002)(62236002)(86362001)(44716002)(229853002)(7736002)(44736005)(6486002)(14454004)(478600001)(53936002)(2906002)(6436002)(305945005)(6512007)(86152003)(9686003)(3846002)(6116002)(68736007)(84392002)(25786009)(6246003)(4326008)(97736004)(4720700003)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0701MB2945; H:AM5PR0701MB2321.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: jBbPsTu6j6G74ePKOqsBC5DfZnADw87tC6IuH5nYStg8NdWrDCXB0/01nFcyymTayYj2QgPp/QWD8h3ZvUwNj3Fmxwv8j2rfmb3KlYKVoMSeC1RgQCVdWCVBrCrCtnL1ZWL092OneECvfE6SJJB2ggdR7ntD4L62a0rpV1PQR80KmxD78lmaER4kDAb7eT3slCzn68OrbY2MGJ3cNs+GFPhKliNCrvfXnv6yHk5AJkwTzXqNdF9+n1vzFOVDmt79rVn1fuT682Yv4GrPgbcpp0F3VPdlIH0PGoiqf5cfwMkHutvEqb80gVv853GT7bkQgq2p3UP6V+PNX8Fsj7gPjfDCELD307l5vweYkI2u2z1yKA02KXq8rHNTmZ095poNZgPNsno1WZI1U9ICG8zR000+QVKq9vWj5bz1hsOp1Hc=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AA10D1915635804F912EDCC86468DDA7@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c71d10ab-d7d9-48b9-87e1-08d68cf15161
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2019 11:42:19.3862 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0701MB2945
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/hwPWXuEDGLgIHuJaEo5J9M-70yE>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 11:42:26 -0000

----- Original Message -----
From: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
Sent: Tuesday, February 05, 2019 8:11 PM

> Thanks, Tom. Please see inline below.
>
> -----Original Message-----
> From: tom petch <ietfa@btconnect.com>;
> Date: Tuesday, February 5, 2019 at 9:47 AM
>     Tarek
>
>     Getting there .
>
>     You will need to have a reference to the new I-D references in the
body
>     of the I-D else you will get unused references.  One way to do
this is
>     to have a Section 4.1 This module references [RFC3272]. [....  I
have
>     not gone through and seen how many this applies to but imagine it
is
>     most of them.
> [TS]: unfortunate that the tool will flag those as warning as the I-D
YANG module clearly references them.. I am wondering if there is a
chance or a plan to enhance the IETF idnit tool to parse the YANG module
for references and silence such warnings?
>

Well no, that would be wrong.

A YANG module needs references, for import statements and to tell the
user where to go for more information on the objects, their use and so
on.

A YANG module must be plain text so cannot contain the usual HTML/XML
style anchors that an I-D/RFC has.

Documents referenced from within an RFC must appear in the References of
that RFC.

Hence
 - anything referenced in the YANG module must be in the References of
the RFC
- anything referenced in the YANG module must have a HTML/XML style
reference somewhere in the RFC outside the YANG module.

Where such references do not crop up in the existing text of the memo
outside the YANG module, then the practice is to add a
Section X.1
before the YANG module saying words to the effect that this YANG module
imports from [. and references [....

So the tool wants enhancing to generate more warnings, not less, when
the contents of a a YANG reference clause do not appear in the Reference
section of the I-D.

HTH

I was unclear about my comment on G808; having the reference is find but
I would prefer G.808; I note that Deborah's e-mail used G.808 even when
referring to the 'G808' in the I-D so I think G.808 is to be preferred.

Tom Petch


>     Also you have G.8031 but G808.  Not wrong, but...
> [TS]: G.8031 is already listed in references. G808 is still relevant.
I've moved both to informative references as per other recommendations.
>
>           import ietf-routing-types { prefix "rt-types";
>     now has the right RFC but the wrong title; should be
>     Common YANG Data Types for the Routing Area
>
> [TS]: thank you. I'll take care of this one in the next update.
>
> Regards,
> Tarek
>
>
>     Tom Petch
>
>     ----- Original Message -----
>     From: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
>     Sent: Thursday, January 31, 2019 2:10 PM
>
>     > Hi Tom,
>     >
>     > Thank again for your review comments below. We've uploaded
version
>     04/-05 which attempts to address these comments.
>     > See inline [TS] for resolution.
>     >
>     > -----Original Message-----
>     > From: tom petch <ietfa@btconnect.com>;
>     > Date: Wednesday, January 23, 2019 at 12:13 PM
>     > To: Jan Lindblad <janl@tail-f.com>;, Tarek Saad <tsaad@cisco.com>;
>     > Cc: "yang-doctors@ietf.org"; <yang-doctors@ietf.org>;,
>     "draft-ietf-teas-yang-te-types.all@ietf.org";
>     <draft-ietf-teas-yang-te-types.all@ietf.org>;, "ietf@ietf.org";
>     <ietf@ietf.org>;, "teas@ietf.org"; <teas@ietf.org>;
>     > Subject: [Teas] not a Yangdoctor review of
>     draft-ietf-teas-yang-te-types-03
>     >
>     >     Tarek
>     >
>     >     The YANG modules have lots of references - good - but they
are not
>     in
>     >     the I-D references - not good.
>     >
>     >     My list is
>     >
>     >     3272
>     >     4202
>     >     4328
>     >     4657
>     >     5817
>     >     6004
>     >     6205
>     >     6511
>     >     7139
>     >     7308
>     >     7551
>     >     7571
>     >     7579
>     >     7951
>     >     G.808
>     >     G.8031
>     >     G.8131
>     >     G.873.1
>     >
>     > [TS]: thanks. I've added the missing references and they should
show
>     in the I-D references now.
>     >
>     >     s.3.1 I would find more usable if the types were in an order
I
>     could
>     >     recognise, such as alphabetical
>     >
>     > [TS]: OK, I tried an attempt to sort the typedefs
alphabetically.
>     >
>     >       import ietf-routing-types { prefix "rt-types";
>     >     reference "RFC6991: Common YANG Data Types";
>     >     perhaps RFC8294 is intended
>     >
>     > [TS]: corrected to RFC8294
>     >
>     >     "   defined in ietf-network.yang, to help user to understand
""
>     >     might benefit from a reference - is this
>     >     draft-ietf-i2rs-yang-network-topo?
>     >
>     > [TS]: added reference RFC8345.
>     >
>     >     /"Then index of the label/ "The index of the label /
>     >
>     > [TS]: fixed typo.
>     >
>     >               container tiebreakers {
>     >                 description
>     >                   "The list of tiebreaker criterion to apply
>     >                    on an equally favored set of paths to pick
best";
>     >                 list tiebreaker {
>     >                   description
>     >                   "The list of tiebreaker criterion to apply
>     >                      on an equally favored set of paths to pick
best";
>     >     One description is perhaps enough
>     >
>     > [TS]: removed/updated redundant description.
>     >
>     >     uses path-objective-function_config;
>     >     using _ is not wrong but is discouraged, mixing _ with - in
a
>     label more
>     >     so
>     >
>     > [TS]: OK, we have moved away from using "_" in the naming.
>     >
>     >     /This document registers a YANG module/
>     >     This document registers two YANG modules/
>     >
>     > [TS]: fixed typo.
>     >
>     >        name: ietf-te-types namespace:
>     urn:ietf:params:xml:ns:yang:ietf-te-
>     >        types prefix: ietf-te-types reference: RFC3209
>     >        name: ietf-te-packet-types namespace:
>     >        urn:ietf:params:xml:ns:yang:ietf-te-packet-types prefix:
>     ietf-te-
>     >        packet-types reference: RFC3209
>     >
>     >     Perhaps /3209/XXXX/
>     >
>     > [TS]: fixed.
>     >
>     > Regards,
>     > Tarek
>     >
>     >     Tom Petch
>     >
>     >     ----- Original Message -----
>     >     From: "Jan Lindblad" <janl@tail-f.com>;
>     >     To: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
>     >     Cc: <yang-doctors@ietf.org>;;
>     >     <draft-ietf-teas-yang-te-types.all@ietf.org>;;
<ietf@ietf.org>;;
>     >     <teas@ietf.org>;
>     >     Sent: Monday, January 21, 2019 10:10 AM
>     >     Subject: Re: [Teas] Yangdoctors early review of
>     >     draft-ietf-teas-yang-te-types-03 (was -01)
>     >
>     >
>     >     >
>     >
>     >
>     >
>     >
>
>
>
>