RE: [i2rs] Rtgdir early review of draft-ietf-i2rs-yang-l3-topology-10

Alexander Clemm <alexander.clemm@huawei.com> Mon, 10 July 2017 18:17 UTC

Return-Path: <alexander.clemm@huawei.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 839EF13183F; Mon, 10 Jul 2017 11:17:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.222
X-Spam-Level:
X-Spam-Status: No, score=-4.222 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q6hpFTrMFAzw; Mon, 10 Jul 2017 11:17:05 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A526C131839; Mon, 10 Jul 2017 11:17:03 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml704-cah.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DKC54971; Mon, 10 Jul 2017 18:17:01 +0000 (GMT)
Received: from SJCEML701-CHM.china.huawei.com (10.208.112.40) by lhreml704-cah.china.huawei.com (10.201.108.45) with Microsoft SMTP Server (TLS) id 14.3.301.0; Mon, 10 Jul 2017 19:17:00 +0100
Received: from SJCEML702-CHM.china.huawei.com ([169.254.4.142]) by SJCEML701-CHM.china.huawei.com ([169.254.3.186]) with mapi id 14.03.0301.000; Mon, 10 Jul 2017 11:16:56 -0700
From: Alexander Clemm <alexander.clemm@huawei.com>
To: Christian Hopps <chopps@chopps.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "i2rs@ietf.org" <i2rs@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-i2rs-yang-l3-topology.all@ietf.org" <draft-ietf-i2rs-yang-l3-topology.all@ietf.org>
Subject: RE: [i2rs] Rtgdir early review of draft-ietf-i2rs-yang-l3-topology-10
Thread-Topic: [i2rs] Rtgdir early review of draft-ietf-i2rs-yang-l3-topology-10
Thread-Index: AQHS98KNUSDSz+AzG02R/9n7T9fsDqJNYazg
Date: Mon, 10 Jul 2017 18:16:55 +0000
Message-ID: <644DA50AFA8C314EA9BDDAC83BD38A2E0E0CD724@SJCEML702-CHM.china.huawei.com>
References: <149950173106.2877.12360295603653924176@ietfa.amsl.com>
In-Reply-To: <149950173106.2877.12360295603653924176@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.213.48.103]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.5963C49E.007F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.4.142, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: ab8871c8153424ec3765661730c8f207
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/lY9JZQBJcCg-5ilCwXyrTgjOkrc>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Jul 2017 18:17:07 -0000

Hello Christian,

Thank you for your review.  We will apply the suggested updates.

--- Alex

-----Original Message-----
From: i2rs [mailto:i2rs-bounces@ietf.org] On Behalf Of Christian Hopps
Sent: Saturday, July 08, 2017 1:16 AM
To: rtg-dir@ietf.org
Cc: i2rs@ietf.org; ietf@ietf.org; draft-ietf-i2rs-yang-l3-topology.all@ietf.org
Subject: [i2rs] Rtgdir early review of draft-ietf-i2rs-yang-l3-topology-10

Reviewer: Christian Hopps
Review result: Has Nits

Hello,

I have been selected to do a routing directorate “early” review of this draft.

  https://datatracker.ietf.org/doc/draft-ietf-i2rs-yang-l3-topology/

The purpose of this review is to determine it's compatibility with the new revised datastore model guidelines.

For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Document: draft-ietf-i2rs-yang-l3-topology-10.txt
Reviewer: Christian Hopps
Review Date: July 8, 2017
Intended Status: Standards Track

Summary:

- This document is basically ready for publication, but has nits that should be
  considered prior to being submitted to the IESG.

Comments:

- This document adapts the suggested NMDA guidelines quite nicely.

- Perhaps an informative reference to the NMDA guidelines draft would be useful.

- Appendix A: Second Paragraph, last sentence:
  - I believe that it should say:

      "instead of ietf-network and ietf-network-topology"

    it currently says:

      "instead of ietf-network and ietf-network-state"

- IS-IS example model (sorry couldn't help myself :)

  - The example IS-IS l3-node-attributes augmentation isis-node-attributes
    includes an "iso-pseudonode-id". This isn't a node attribute, but rather a
    link one (it is repeated later under link attributes).

  - The isis-wg suggests to use "IS-IS" consistently, where possible, in
    documents rather than "isis" or "ISIS".


_______________________________________________
i2rs mailing list
i2rs@ietf.org
https://www.ietf.org/mailman/listinfo/i2rs