Re: Gen-Art LC review: draft-ietf-netmod-yang-metadata-04

Ladislav Lhotka <lhotka@nic.cz> Wed, 09 March 2016 17:04 UTC

Return-Path: <lhotka@nic.cz>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BE4212D877; Wed, 9 Mar 2016 09:04:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([127.0.0.1]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R5lnuBQ0Tdfq; Wed, 9 Mar 2016 09:04:06 -0800 (PST)
Received: from trail.lhotka.name (trail.lhotka.name [77.48.224.143]) by ietfa.amsl.com (Postfix) with ESMTP id CA84A12DBD8; Wed, 9 Mar 2016 09:04:01 -0800 (PST)
Received: from localhost (unknown [195.113.220.110]) by trail.lhotka.name (Postfix) with ESMTPSA id 309891CC035F; Wed, 9 Mar 2016 18:04:01 +0100 (CET)
From: Ladislav Lhotka <lhotka@nic.cz>
To: Robert Sparks <rjsparks@nostrum.com>, General Area Review Team <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, netmod@ietf.org, draft-ietf-netmod-yang-metadata.all@ietf.org
Subject: Re: Gen-Art LC review: draft-ietf-netmod-yang-metadata-04
In-Reply-To: <56D60EF5.7020001@nostrum.com>
References: <56D60EF5.7020001@nostrum.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.4.51.2 (x86_64-apple-darwin14.0.0)
Date: Wed, 09 Mar 2016 18:04:08 +0100
Message-ID: <m27fhbvb07.fsf@birdie.labs.nic.cz>
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <http://mailarchive.ietf.org/arch/msg/ietf/m9A-WFRWGKK6dWamzlSB5BRemnM>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 17:04:08 -0000

Hi Robert,

thanks for the review, I apologize for replying late, please see my responses inline:

Robert Sparks <rjsparks@nostrum.com> writes:

> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>
> Document: draft-ietf-netmod-yang-metadata-04
> Reviewer: Robert Sparks
> Review Date: 1Mar2016
> IETF LC End Date: 9Mar2016
> IESG Telechat date: not yet scheduled
>
> Summary: Ready with nits
>
> 1) I might be missing something obvious, but the introduction has two 
> statements that don't seem aligned:
>
> " Values of annotations are not limited to strings; any YANG built-in or 
> derived type may be used for them"
> and
> "annotations are scalar values and cannot be further structured".

These two statements are not in conflict: YANG data types (built-in or
derived) apply to scalar values. 

>
> If I'm not missing something, that may be more of an open issue than a nit.
>
> 2) The shepherd writeup calls out the tension in figuring out whether to 
> make this an extension or a new built-in statement. Please consider 
> capturing the reasoning for the path you chose in the draft itself.

I will try, the main reason was that most people felt that introducing a
new built-in statement is too big a change for the upcoming maintenance
version of YANG (1.1) and YANG 2.0 is nowhere in sight.

Thanks, Lada

>
>
>
>
>
>
>
>
>

-- 
Ladislav Lhotka, CZ.NIC Labs
PGP Key ID: E74E8C0C