答复: [Idr] Opsdir early review of draft-ietf-idr-bgp-ls-segment-routing-ext-06

"Aijun Wang" <wangaijun@tsinghua.org.cn> Thu, 10 May 2018 01:54 UTC

Return-Path: <wangaijun@tsinghua.org.cn>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 337CF12E883; Wed, 9 May 2018 18:54:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6Xqp9lbCmWq; Wed, 9 May 2018 18:53:57 -0700 (PDT)
Received: from m88102.mail.qiye.163.com (m88102.mail.qiye.163.com [106.2.88.102]) by ietfa.amsl.com (Postfix) with ESMTP id C258812D864; Wed, 9 May 2018 18:53:53 -0700 (PDT)
Received: from WangajPC (unknown [219.142.69.77]) by m88102.mail.qiye.163.com (Hmail) with ESMTPA id C751A425A8; Thu, 10 May 2018 09:53:46 +0800 (CST)
From: Aijun Wang <wangaijun@tsinghua.org.cn>
To: 'Joel Jaeggli' <joelja@bogus.com>, ops-dir@ietf.org
Cc: idr@ietf.org, ietf@ietf.org, draft-ietf-idr-bgp-ls-segment-routing-ext.all@ietf.org
References: <152584833398.2904.14504730626460815575@ietfa.amsl.com>
In-Reply-To: <152584833398.2904.14504730626460815575@ietfa.amsl.com>
Subject: 答复: [Idr] Opsdir early review of draft-ietf-idr-bgp-ls-segment-routing-ext-06
Date: Thu, 10 May 2018 09:53:49 +0800
Message-ID: <002e01d3e801$bdec55f0$39c501d0$@org.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AdPnYXS4ml6e6++cQ4a6pOQvDo62fQAn6Glw
Content-Language: zh-cn
X-HM-Spam-Status: e1ktWUFJV1koWUFKTEtLSjdXWQgYFAkeWUFLVUtXWQkOFx4IWUFZMjUtOj cyP0FLVUtZBg++
X-HM-Sender-Digest: e1kSHx4VD1lBWUc6Ngw6Cxw4AjoqSR8WSUJMGSpCAigwFC1VSlVKTklO QkpMSUhJSU1PVTMWGhIXVQwaFRwaEhEOFTsPCBIVHBMOGlUUCRxVGBVFWVdZDB4ZWUEdGhcIHldZ CAFZQU5KSEI3V1kSC1lBWUlKQlVKT0lVTUJVTExZBg++
X-HM-Tid: 0a6347c1186d9865kuuuc751a425a8
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/pMcOkMjnzN6PX4Ykbn_s5BlGNy4>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 May 2018 01:54:00 -0000

Hi, Joel:

Is there any IETF document to define the "IPv4/IPv6 Source Router ID" in OSPFv2/v3, for the similar scenarios that described in RFC7794?


Best Regards.

Aijun Wang
Network R&D and Operation Support Department
China Telecom Corporation Limited Beijing Research Institute,Beijing, China.

-----邮件原件-----
发件人: Joel Jaeggli [mailto:joelja@bogus.com] 
发送时间: 2018年5月9日 14:46
收件人: ops-dir@ietf.org
抄送: idr@ietf.org; ietf@ietf.org; draft-ietf-idr-bgp-ls-segment-routing-ext.all@ietf.org
主题: [Idr] Opsdir early review of draft-ietf-idr-bgp-ls-segment-routing-ext-06

Reviewer: Joel Jaeggli
Review result: Has Nits

I have performed a requested early review on the behalf of the operations directorate of the current draft-ietf-idr-bgp-ls-segment-routing-ext-06.
Generally I think this document is good, I won't say ready, as this review is intended as an early review not a final one.

Some nits

1-
introduction

   This way, all BGP speakers (specifically the route-reflectors) obtain
   Link-State information from all IGP areas (and from other ASes from
   EBGP peers).

* BGP speakers are agnostic about the source of the information beyond that it was exported with certain properties from the rib of it’s neighbor.

2 -
   An external component (e.g., a controller) then can
   collect SR information in the "northbound" direction across IGP areas
   or ASes and construct the end-to-end path (with its associated SIDs)
   that need to be applied to an incoming packet to achieve the desired
   end-to-end forwarding.

* Unqualified use of the term northbound I find generally problematic, particularly in the case of a route reflector. Previously RFC 7752 manged to use the term in the title and then never again within the text.

3-

2.3.3.  Source Router Identifier (Source Router-ID) TLV

   The Source Router-ID TLV contains the IPv4 or IPv6 Router-ID of the
   originator of the Prefix.  For IS-IS protocol this is as defined in
   [RFC7794].  The Source Router-ID TLV may be used to carry the OSPF
   Router-ID of the prefix originator.

   The Source Router-ID TLV has the following format:

    0                   1                   2                   3
    0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
   |            Type               |            Length             |
   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
   //                  IPv4/IPv6 Address (Router-ID)              //
   +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

   where:

      Type: TBD, see Section 4.

      Length: 4 or 16.

      IPv4/IPv6 Address: 4 octet IPv4 address or 16 octet IPv6 address.

   The semantic of the Source Router-ID TLV is defined in [RFC7794].

* While RFC7794 Router-IDs are in fact IP addresses. OSPF Router-IDs are not even if they happen to look like them, this is particularly germain with ospfv3 but it’s worth making the distinction.

4 -
5.1.1.  Operations

   Existing BGP and BGP-LS operational procedures apply.  No additional
   operation procedures are defined in this document.

* An informative or normative reference (probably to 7752 especially fault
mangement) is probably required.

_______________________________________________
Idr mailing list
Idr@ietf.org
https://www.ietf.org/mailman/listinfo/idr