Re: Gen-ART LC Review of draft-ietf-ipfix-data-link-layer-monitoring-06

Ben Campbell <ben@nostrum.com> Wed, 06 November 2013 00:09 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2832821E80AF; Tue, 5 Nov 2013 16:09:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.456
X-Spam-Level:
X-Spam-Status: No, score=-102.456 tagged_above=-999 required=5 tests=[AWL=0.144, BAYES_00=-2.599, SPF_PASS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XmjPchK9pV8v; Tue, 5 Nov 2013 16:09:29 -0800 (PST)
Received: from shaman.nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id 216AE21E808F; Tue, 5 Nov 2013 16:09:29 -0800 (PST)
Received: from dhcp-bc5b.meeting.ietf.org (dhcp-bc5b.meeting.ietf.org [31.133.188.91]) (authenticated bits=0) by shaman.nostrum.com (8.14.3/8.14.3) with ESMTP id rA609POv061506 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 5 Nov 2013 18:09:26 -0600 (CST) (envelope-from ben@nostrum.com)
Content-Type: text/plain; charset="iso-8859-1"
Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1816\))
Subject: Re: Gen-ART LC Review of draft-ietf-ipfix-data-link-layer-monitoring-06
From: Ben Campbell <ben@nostrum.com>
In-Reply-To: <52787129.5060907@cisco.com>
Date: Tue, 05 Nov 2013 16:09:24 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <F80BA530-12D2-42CD-9851-27B62D8DB68F@nostrum.com>
References: <877E63A6-07D1-45C3-93EA-086871A8ADE7@nostrum.com> <52727FDE.6040108@cisco.com> <7CCBFD9D-71E4-42C4-A10B-B60ABCC5DDE7@nostrum.com> <52787129.5060907@cisco.com>
To: Benoit Claise <bclaise@cisco.com>
X-Mailer: Apple Mail (2.1816)
Received-SPF: pass (shaman.nostrum.com: 31.133.188.91 is authenticated by a trusted mechanism)
Cc: "ipfix-ads@tools.ietf.org" <ipfix-ads@tools.ietf.org>, "gen-art@ietf.org Team (gen-art@ietf.org)" <gen-art@ietf.org>, draft-ietf-ipfix-data-link-layer-monitoring.all@tools.ietf.org, Paul Aitken <paitken@cisco.com>, "ietf@ietf.org list" <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2013 00:09:30 -0000

Hi,

The revised version addresses all of my Gen-ART review comments.

Thanks!

Ben.

On Nov 4, 2013, at 8:16 PM, Benoit Claise <bclaise@cisco.com> wrote:

> Ben,
> 
> A new draft version has been posted
> https://datatracker.ietf.org/doc/draft-ietf-ipfix-data-link-layer-monitoring/ 
> 
> Regards, Benoit
>> Thanks for the response. Those changes would address all of my comments.
>> 
>> Thanks!
>> 
>> Ben.
>> 
>> On Oct 31, 2013, at 11:05 AM, Paul Aitken <paitken@cisco.com> wrote:
>> 
>>> Thanks for the review, Ben.
>>> 
>>> As you pointed out, the description in 3.2.18 wrongly specified a delta rather than a total; I've fixed it.
>>> 
>>> I also clarified the third paragraph of the Introduction to say that the existing models don't yet contain enough elements - which is the point of this draft.
>>> 
>>> Regarding section 4 / RFC 5477, the intention is that IANA's IPFIX registry is the ultimate reference. We want to avoid new drafts updating old RFCs.
>>> The IPFIX AD is considering how to proceed with that.
>>> 
>>> I'll publish a -07 with the changes.
>>> 
>>> Thanks,
>>> P.
>>> 
>>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>>> Gen-ART, please see the FAQ at
>>>> 
>>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>> 
>>>> Please resolve these comments along with any other Last Call comments
>>>> you may receive.
>>>> 
>>>> Document: draft-ietf-ipfix-data-link-layer-monitoring-06
>>>> Reviewer: Ben Campbell
>>>> Review Date: 2013-22-10
>>>> IETF LC End Date: 2013-23-10
>>>> 
>>>> Summary: Ready for publication as a proposed standard, with  one problem that should be easily fixed.
>>>> 
>>>> Major issues:
>>>> 
>>>> None
>>>> 
>>>> Minor issues:
>>>> 
>>>> 3.2.18:
>>>> 
>>>> Title of the data element suggests a total, but the description sounds like a delta (i.e change since last report.)
>>>> 
>>>> -- section 4 and subsections
>>>> 
>>>> It looks like this draft updates at least RFC5477. If so, this should be indicated in the header and in the abstract.
>>>> 
>>>> 
>>>> 
>>>> Nits/editorial comments:
>>>> 
>>>> -- section , 3rd paragraph:
>>>> 
>>>> Do you mean to say the existing data models do not contain the elements needed, or that the models do not provide the right foundation for the needed elements? The wording seems to indicate the latter but I think you mean the former.
>>>> 
>>>> -- General:
>>>> Watch for missing articles.
>> .
>> 
>