Re: Rtgdir early review of draft-ietf-idr-ext-opt-param-07

John Scudder <jgs@juniper.net> Wed, 21 April 2021 21:33 UTC

Return-Path: <jgs@juniper.net>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5D0973A37BF; Wed, 21 Apr 2021 14:33:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.799
X-Spam-Level:
X-Spam-Status: No, score=-2.799 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b=FVlDdjA3; dkim=pass (1024-bit key) header.d=juniper.net header.b=ipOQYumQ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c_ysWj8molw2; Wed, 21 Apr 2021 14:33:54 -0700 (PDT)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4851E3A37BE; Wed, 21 Apr 2021 14:33:54 -0700 (PDT)
Received: from pps.filterd (m0108160.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13LL9vEL005953; Wed, 21 Apr 2021 14:33:52 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=BvV4BV8NwOb6y9z6YmznflS1Qf5248fA7xo4xvawNrA=; b=FVlDdjA3hOZOHQtOkoWNn9YStDB7WR8CGER5IhFbrj4ryFJwsf30RSVmcevYPbF0jjYD 24K8fdOwz0FKAoQO1odyefOz2ipgSZHp1euB9VCw0duTaL1bL6D95DaTTsCk3VRlbRAq FWo5nkNTSLauiW36fEhG4AU9msvIeKCenlA8epHxDEJHNga6XdGuUfF/LrYSsHhpJNgu tBbinvTDjsUu8QrwtHJNQDtGxfbt8f+lVa3FhTiNO4jD3IxCBwfHJax7z7UcxExMyyRl fmztmGH3wjcHWL8cGesE8yzkKYXbQKRPE9b0Bh2AStQSm9iqGv9dy8dOHpIoskxjKh0D lA==
Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105]) by mx0b-00273201.pphosted.com with ESMTP id 382p4t8vrj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 14:33:52 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jgh22Q0KUv38IjrMbAnPukwhpC4EfbTaSI6zrxSGL/65vlDdxOtErLZoumJ6Td5hr7/LQLb6xg677SJMBk6BigJXrxXoxgXJ6KjdwupCQGjZzhYU1R8dvIiFCP87eOjEf3PC2Lk/1hfWWoJWUmELwRokKWwOeGrkUUo78TRyUnvIwzX4s7bcZS2GFhJyzin4T3DyrPjMDf2tFx61S9sgEBC8XLLeakqn9t9IhyRhGXmIGPaK7zQbFwm33vSHUQrBmCwi2nbu5LliEeTfgbDo1TGPcWmNoeaW/NeDhTLnHwNfXe+m6GI1XIr24ett3/uLLobsLciU+VuCXoEqM8LFHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BvV4BV8NwOb6y9z6YmznflS1Qf5248fA7xo4xvawNrA=; b=JwlSnzvl1VTLqjI9UckMQ40TKN42uW1c8lUNgZKNWHwBqoFPT1L/+0ZFd1itLAv677ImM4tORpi39IlbJIM0R2pbdN92ZiAUqirRPLXV/0GxojuLRDZAHR2HC9eEqXWd7rl1O6dNbH5ZvmVzeSjH1uXONiJhqxzk5q7uS9RxKU52nW2lxhL+vi44VcRKAuGwuu8l/5+Uv+Mim+Nuo4eY8Q4fs10UjJR9ibDa0xGoC83TE/sI2zhjRwaTjS0GLkR0lFzT3TsRhfirIIKIkmUqPpSIHIU5oexNJP7FB6QB4HywW10gHFC9nA8Nuqhr2aawG+q76VdVcwmpNDFoEGQYxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BvV4BV8NwOb6y9z6YmznflS1Qf5248fA7xo4xvawNrA=; b=ipOQYumQ7luSgYKG1BOPr3SUnacR/cf2m0i8CabzyACF88ltYCrnB9DY7Er7m2HfxHhelv98o67VOiNnGboqLD8BDLsl/lu8ZV1zyKqxav31VMKeMypslpWf0Y8bbcbWDprQFydAPA0BbrfxDzAMPR/nDQlvALjmYGgTi8pl7+Y=
Received: from BN8PR05MB6098.namprd05.prod.outlook.com (2603:10b6:408:45::29) by BN7PR05MB4212.namprd05.prod.outlook.com (2603:10b6:406:91::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.12; Wed, 21 Apr 2021 21:33:50 +0000
Received: from BN8PR05MB6098.namprd05.prod.outlook.com ([fe80::4d47:2d3c:d3c5:2e14]) by BN8PR05MB6098.namprd05.prod.outlook.com ([fe80::4d47:2d3c:d3c5:2e14%3]) with mapi id 15.20.4065.021; Wed, 21 Apr 2021 21:33:50 +0000
From: John Scudder <jgs@juniper.net>
To: Joel Halpern <jmh@joelhalpern.com>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-idr-ext-opt-param.all@ietf.org" <draft-ietf-idr-ext-opt-param.all@ietf.org>, "idr@ietf. org" <idr@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Subject: Re: Rtgdir early review of draft-ietf-idr-ext-opt-param-07
Thread-Topic: Rtgdir early review of draft-ietf-idr-ext-opt-param-07
Thread-Index: AQHXNvYE3VLaAmeR3kiPUbU3LkWeew==
Date: Wed, 21 Apr 2021 21:33:50 +0000
Message-ID: <86CFA286-35F2-4457-8925-ACC4B3090B74@juniper.net>
References: <156852158610.2942.7120450929500158327@ietfa.amsl.com>
In-Reply-To: <156852158610.2942.7120450929500158327@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3608.120.23.2.4)
authentication-results: joelhalpern.com; dkim=none (message not signed) header.d=none;joelhalpern.com; dmarc=none action=none header.from=juniper.net;
x-originating-ip: [162.225.191.192]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c29ddafa-07e3-472b-b8bb-08d9050d2750
x-ms-traffictypediagnostic: BN7PR05MB4212:
x-microsoft-antispam-prvs: <BN7PR05MB4212E052BD636CD59A23CDE5AA479@BN7PR05MB4212.namprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: XZk0FBqEvdYW365zGVoLEZv92I4HeH3B2EljH8d+6Hivu6vMd1hfxQhbT+pyDcpNmBHfG7cw5crqNaQmwTZEZDyI8fpFqQcCEZiWjZWK9wI7RTsq2tdV84rOaZmjomIQ3wDE8IaKOyvGRPBunUB4YWm76fXIkkVNZeVlKrApeC1gHJXRB41JAXoyvNBJ0E+BYTSiDvNSAVsb0zj4iKVygo9agA5pbNTLql9HhH7ECslKNlhpDua6dDdZe/sOiQIz4gXbcRdPGzNIekR/LgRHE1MFhkJVbt8my2uh8nf8buKMY2wWcw7kgC153YDqPc9zzKWDYFb0R6Oau5GU3wONQVfM5O/I3WjRd9XrWJ/09AtRjVhhDib0cXn0t5O1c2zG4vxCvLQB2lS40Q3QKm6cGER1ZxEIKqHKczn6rRfSBuRuVGqQRVR0tDpHYXuUhMKE90I2mmZns8wxmvyKnDYJCVvVA2JDI0xadVeXFVThvOGf8J7qWw1jQQRjAqSScUg2R+IT9oBQ3tBKpSN44vqdA0ZBQDgiS5xu6QOkfeDMXGHN44fvkU91PHgtDUc2BgpcacGD5c39qUINN8Ju2sInEbsVQzLVtPGxyWTISkw/1VrA49eHtSQdUTK09Tc6DaT2ui1zVIF+i1QRI8BqGg6irCZXcrbiYrtDHd7LuZpwQYp8WEcP/zTbneZYdM3TcIvqDs3Qb1hgx52/vqGb7RvRFTUsM9j7RbSMNR7+hlgo+Z0=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR05MB6098.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(316002)(54906003)(5660300002)(26005)(186003)(2616005)(166002)(6486002)(8936002)(122000001)(6506007)(53546011)(91956017)(2906002)(8676002)(66946007)(66556008)(64756008)(76116006)(478600001)(36756003)(33656002)(4326008)(6512007)(83380400001)(38100700002)(6916009)(66476007)(66446008)(71200400001)(86362001)(45980500001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: =?utf-8?B?ZHc0b2lZbmo1bUx3Q0hLVWoyeFZQREFPUmN4M0t6d3h2MElMVjdzdnlLbzU0?= =?utf-8?B?WENJMDVLVFljL0IxaFVFcllyZEN5QTJ4WkxkVzVTbzZsVzhHdDRqMnNscmVh?= =?utf-8?B?Q3hNNzdUeVEyK2Q2eHFrVjBaQUk4aFBiYWxmckV0RVFsZE9RSFkyVnB1bWFS?= =?utf-8?B?VVNvbUNiM0w3RzlWRXgzWE4xamFESEFYdzhQTldZOFl0R0ZKZjdJamowVlo2?= =?utf-8?B?cTNFMDE2VWZYUExxK1JNTDlPMFhGVXlrNDhUSnZkMElMQXVHOW5sSFFNeHQy?= =?utf-8?B?UDlTNFlsakVMblBuWnNKTWxEbHowSU9lSHRSRVAyZVQxUkNNMkxCOWlBMEEr?= =?utf-8?B?NFZyWkM1RWFMQ2xLa2d1d3FhN0IzVE0xeFhaNFkrZDRhTXRBbHc1L2FVUzRU?= =?utf-8?B?RUhxdk0wYmlVaktvcG5zNzBjSnFHSUZkUGZBZUM4RzVHcURZc1RqZk1hTU80?= =?utf-8?B?Y0UwS2t2cERIV24vcG5iS09ROWRvSWQ2aE1nenNiSGlIcTVvNUJjSWtxQXBO?= =?utf-8?B?a2FxVEZtanMrUTlndXF4VS9SVUNrN3N1NjJZUXFaYTlEWUV3bXY4dWxQcHZG?= =?utf-8?B?RVl0a3hEUWk0L1hzb04yNVdRR0UvODdMK1NROVZ0WTZmeWR6dUNwRVJEYUtq?= =?utf-8?B?UElYUVdWb2MyK1hHMEdkdHA2OFY1VnJwSmxPTUVXVzJldGJhZ29PNEUra0lz?= =?utf-8?B?YldZR2RHRlVoemdHWVJjNGFrclVaL0xDYmhwb1BJVFA2MVRJcFBIWDJYZjYx?= =?utf-8?B?TXZrRzJQUzdhRHZzUXF2ZVV5QmgxR0NRMjVFcmluTENWaHMvaHVMVDNOY3cr?= =?utf-8?B?T1h3MDBtS3ZNMDdQV0FpUVpBOG13T2xHMWhYYi85VE96OEpWeDNhUUFuSzZM?= =?utf-8?B?aHpTOVB6TTBFL01qYVZNK3pUclVKSElRdXM2Vk0yak1MOUhPMTVXSHpTQ0Yr?= =?utf-8?B?Z2Fia0xnNnVMbnF3KzhXR2tZV2NGdnNlTE5aY25YaW1IRHVwSDd0M0NyWloy?= =?utf-8?B?OVRkTG5Mc3Jqa0VPL21adjVodXhFWkRzNTJTeUJjanFNai9LYUdKQlJnZFpj?= =?utf-8?B?UHZ0cVA3VDB0TjlPSGk1WEFlQlpmYTlsRnlwWnlJVFBmYzJXMSsxNUdURFBI?= =?utf-8?B?TlVNd1FPSzR6a3FNNFZMY1pHYThiK2t2K1NpZnZYaGUxcnBjTnQvVXRlc0l3?= =?utf-8?B?Um5KM1FrYU1rRU5ZWGViMGppODQyYktkVlN3ay9ZWU9ucGZUcERyTUtzSEU4?= =?utf-8?B?ZmIyNyttSTZORmMzVEpqSitVaDIwMlZIeWZ4aFBaa3FkOHV2QkdGWEZKK044?= =?utf-8?B?U2VkRm5IditDU0xOcU5xM2VLVk9RWWkyUVJEK3hOMTF4cFdSQUlob1oxVVNn?= =?utf-8?B?amNoNzZEMEdid1AwRUFkSms0Z1dyRTRIYkhheUZNVi9KYVVVQ0Nqa0ozaE03?= =?utf-8?B?TXI2cGQwL2p1MDAwK3VXZy9zTFVpUm5CQ3pGNUp6WlJ3Z2lwODlaVmp2N3NL?= =?utf-8?B?NSs4bXFvckVuS2JESXhRcGtjYkdKTjRsU0F3eGZ0TzgvZ1ZlM3g5RFlFSWc0?= =?utf-8?B?YmUyQ2pFMklHVDF5NUpUL1VlMUE4SWlIUlErQXpVM2h6THdMTDhGWmRWUWti?= =?utf-8?B?Wk5NWVdvOTcxUmFBZzJ5N1BaenMrUWh0RWYwYjFTZTFpMkpvMjZhSUhxaWhT?= =?utf-8?B?dWpxSDRXeVA3N1VUYkd2MTlFazRRcWt2Sm1xWDlXeUwwUFdQM2x5YmxTWDhO?= =?utf-8?B?cGZQQnBJQ3pCNnQ4eUtSdXNvY2F6R0F5d2JIdE9ZSmRKVDFsemNHZkpFM2I0?= =?utf-8?B?TC9iNHozd3pMSGNVMW5xdz09?=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_86CFA28635F244578925ACC4B3090B74junipernet_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR05MB6098.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c29ddafa-07e3-472b-b8bb-08d9050d2750
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 21:33:50.0661 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0ggZgiZKjHI3G9w2A1ZlrdKgVriKU1iQFTrcLOS8qz7jUdxGjcS5iiLh6COj7EHT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR05MB4212
X-Proofpoint-GUID: diYmqEP7Mg3q43O__xEjcJzCkWXaBsqb
X-Proofpoint-ORIG-GUID: diYmqEP7Mg3q43O__xEjcJzCkWXaBsqb
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-21_06:2021-04-21, 2021-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 suspectscore=0 clxscore=1011 mlxscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104210142
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/tnxZktGwxKwBwyBElePi6XNUmo4>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2021 21:33:59 -0000

Belated thanks, Joel. I did make the change you suggested:


   In parsing an OPEN message, if the one-octet "Optional Parameters
   Length" field is non-zero, a BGP speaker MUST use the value of the
   octet following the one-octet "Optional Parameters Length" field
   (labeled "Non-Ext OP Type" in Figure 1) to determine both the
   encoding of the Optional Parameters length and the size of the
   "Parameter Length" field of individual Optional Parameters.  If the
   value of this the "Non-Ext OP Type" field is 255, then the encoding
   described above is used for the Optional Parameters length.
   Otherwise the encoding defined in [RFC4271] is used.


FYI,

—John

On Sep 15, 2019, at 12:26 AM, Joel Halpern via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>> wrote:

Reviewer: Joel Halpern
Review result: Ready

Hello

I have been selected to do a routing directorate “early” review of this draft.
​https://urldefense.com/v3/__https://datatracker.ietf.org/doc/draft-foo-name/__;!8WoA6RjC81c!S69wo5NzgmQCnJqISrpg4tVLOpB6j03FXH2ZhJzZoYQsgsvKb8RWAFcMo9zMQg$

The routing directorate will, on request from the working group chair, perform
an “early” review of a draft before it is submitted for publication to the
IESG. The early review can be performed at any time during the draft’s lifetime
as a working group document. The purpose of the early review depends on the
stage that the document has reached.

<case 1> As this document has recently been adopted by the working group, my
focus for the review is on providing a new perspective on the work, with the
intention of catching any issues early on in the document's life cycle.

<case 2> As this document is in working group last call, my focus for the
review was to determine whether the document is ready to be published. Please
consider my comments along with the other working group last call comments.

<case 3> If neither of the above describes the circumstances of the review,
then write a brief summary of the reasons for and purpose of the review here
(get this from the WG chair if you are not sure).

For more information about the Routing Directorate, please see
​https://urldefense.com/v3/__http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir__;!8WoA6RjC81c!S69wo5NzgmQCnJqISrpg4tVLOpB6j03FXH2ZhJzZoYQsgsvKb8RWAFfHyqJRIQ$

Document: draft-ietf-idr-ext-opt-param-07
Reviewer: Joel Halpern
Review Date: 25-Sept-2019
Intended Status: Proposed Standard

Summary: No issues found. This documents is ready to proceed to the IESG.

Major Comments: N/A

Minor Comments: N/A

Nits:
  You might consider replacing "this" in "the value of this field" in the 2nd
  from last paragraph of section 2.  I knew what it had to refer to, but it
  stalled me and caused me to recheck the grammar twice before I was sure it
  said what it needed to say.  It may confuse some readers.