Re: Last Call: <draft-ietf-ospf-te-metric-extensions-08.txt> (OSPF Traffic Engineering (TE) Metric Extensions) to Proposed Standard

"Acee Lindem (acee)" <acee@cisco.com> Mon, 15 December 2014 16:58 UTC

Return-Path: <acee@cisco.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ACBAE1A86FB for <ietf@ietfa.amsl.com>; Mon, 15 Dec 2014 08:58:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.345
X-Spam-Level:
X-Spam-Status: No, score=-12.345 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FF_IHOPE_YOU_SINK=2.166, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ziDXXS45vKJv for <ietf@ietfa.amsl.com>; Mon, 15 Dec 2014 08:58:52 -0800 (PST)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D28E1A86E5 for <ietf@ietf.org>; Mon, 15 Dec 2014 08:58:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4545; q=dns/txt; s=iport; t=1418662730; x=1419872330; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=/YPkeCT9K0m1eYjSEob22o0sOd8jfexiCUXvXCzvxwU=; b=gopjJi+0iEJChiId+FCWWsC3f7IlvJ4QICEuPAtFGK7vLOv7pkZwMiAo mwy1HsL41XaXNPFztDKTVtoFmu0N54MQBRwuo7toiP2wfWLHWf117gVG9 OsWHArVdO6Q73WTXCzYfkvLaFjaEtHur6ce5XEY+HOtplwYA6r22XkN1G 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AuUEAPsRj1StJssW/2dsb2JhbABahDAEy0sCgTUBAQEBAX2EDAEBAQMBOj8FBwQCAQgRBAEBAR4FBAcyFAkIAgQOBYgkCNQcAQEBAQEBAQEBAQEBAQEBAQEBAQEBF48/MwcGgxCBEwEEjgKIb4ELgl6NTiKCMIE8bgGBRH4BAQE
X-IronPort-AV: E=Sophos;i="5.07,580,1413244800"; d="scan'208";a="271012427"
Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP; 15 Dec 2014 16:58:48 +0000
Received: from xhc-rcd-x12.cisco.com (xhc-rcd-x12.cisco.com [173.37.183.86]) by aer-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id sBFGwkrE004944 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 15 Dec 2014 16:58:48 GMT
Received: from xmb-aln-x06.cisco.com ([169.254.1.12]) by xhc-rcd-x12.cisco.com ([173.37.183.86]) with mapi id 14.03.0195.001; Mon, 15 Dec 2014 10:58:47 -0600
From: "Acee Lindem (acee)" <acee@cisco.com>
To: "adrian@olddog.co.uk" <adrian@olddog.co.uk>
Subject: Re: Last Call: <draft-ietf-ospf-te-metric-extensions-08.txt> (OSPF Traffic Engineering (TE) Metric Extensions) to Proposed Standard
Thread-Topic: Last Call: <draft-ietf-ospf-te-metric-extensions-08.txt> (OSPF Traffic Engineering (TE) Metric Extensions) to Proposed Standard
Thread-Index: AQHQFjbHi9X/7NLXKEiSKgwlpJ6WzJyMpteAgAAAwwCABKFMgA==
Date: Mon, 15 Dec 2014 16:58:47 +0000
Message-ID: <1D523223-38FB-4FEE-9B59-CB1930FDDC82@cisco.com>
References: <018b01d014ce$06215290$1263f7b0$@olddog.co.uk> <07ae01d01636$ac853340$4001a8c0@gateway.2wire.net> <89C1D2C3-DC24-4A8F-84F4-EB6CC7DC829D@cisco.com> <064e01d01637$bab52370$301f6a50$@olddog.co.uk>
In-Reply-To: <064e01d01637$bab52370$301f6a50$@olddog.co.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.116.152.196]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BF6D88F9F2B6AA448A3FBE107632C0A2@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/ietf/wwPSgPl9LLc2VSJHf4uqpbTqaqI
X-Mailman-Approved-At: Tue, 16 Dec 2014 09:59:17 -0800
Cc: "draft-ietf-ospf-te-metric-extensions.all@tools.ietf.org" <draft-ietf-ospf-te-metric-extensions.all@tools.ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Dec 2014 16:58:58 -0000

Hi Adrian, Tom, 
Can you guys indicate how you would like to see this comment reflected in the draft? Are you suggesting to change he encoding to 64 bits for the new bandwidth sub-TLVs? 
Thanks,
Acee
On Dec 12, 2014, at 1:16 PM, Adrian Farrel <adrian@olddog.co.uk> wrote:

> Good catch Tom,
> 
> Acee, the trick is to go to 6340 and look in the references :-)
> 
>   [IEEE.754.2008]  Institute of Electrical and Electronics Engineers,
>                    "Standard for Floating-Point Arithmetic",
>                    IEEE Standard 754, August 2008.
> 
> A
> 
>> -----Original Message-----
>> From: Acee Lindem (acee) [mailto:acee@cisco.com]
>> Sent: 12 December 2014 18:14
>> To: t.p.
>> Cc: adrian@olddog.co.uk;
> draft-ietf-ospf-te-metric-extensions.all@tools.ietf.org;
>> ietf@ietf.org
>> Subject: Re: Last Call: <draft-ietf-ospf-te-metric-extensions-08.txt> (OSPF
> Traffic
>> Engineering (TE) Metric Extensions) to Proposed Standard
>> 
>> Hi Tom,
>> 
>> On Dec 12, 2014, at 1:08 PM, t.p. <daedulus@btconnect.com> wrote:
>> 
>>> On the question of Floating-Point, there is now 754-2008, which is a
>>> tighter spec and is used in RFC6340.
>> 
>> What is 754-2008?
>> 
>> Thanks,
>> Acee
>> 
>> 
>> 
>>> 
>>> At a tangent, the issue of floating-point support has surfaced a number
>>> of times in YANG and, to date, has always been rejected, reckoning that
>>> suppport for 64-bit decimal is adequate for data modelling.  The
>>> interactions with XPath (which is used as a basis for YANG constraint
>>> statements), where floating-point is allowed, have caused a number of
>>> discussions, some ongoing, about the comparison of a floating-point
>>> number to a 64-bit decimal one. Something to be aware of should you ever
>>> want to model this in YANG.
>>> 
>>> Tom Petch
>>> 
>>> 
>>> ----- Original Message -----
>>> From: "Adrian Farrel" <adrian@olddog.co.uk>
>>> To: <draft-ietf-ospf-te-metric-extensions.all@tools.ietf.org>
>>> Cc: <ospf@ietf.org>; <ietf@ietf.org>
>>> Sent: Wednesday, December 10, 2014 11:07 PM
>>> 
>>>> All,
>>>> 
>>>> I reviewed this document as AD and found a few small points that I
>>> have asked
>>>> the authors to address as IETF last call comments.
>>>> 
>>>> Adrian
>>>> 
>>>> ===
>>>> 
>>>> Please look for places where you have "proposed" something and change
>>>> that to "defined".
>>>> 
>>>> ---
>>>> 
>>>> It would be good to include a reference for encoding floating point
>>>> integers. The usual is (I think)...
>>>> 
>>>>       IEEE, "IEEE Standard for Binary Floating-Point Arithmetic",
>>>>       Standard 754-1985, 1985 (ISBN 1-5593-7653-8).
>>>> 
>>>> ---
>>>> 
>>>> Section 4.2.5
>>>> 
>>>>  Implementations MAY also permit the configuration of a static (non
>>>>  dynamic) offset value (in microseconds) to be added to the measured
>>>>  delay value, to facilitate the communication of operator specific
>>>>  delay constraints.
>>>> 
>>>> On the third reading I got it! I'm slow (I have a high delay :-)
>>>> 
>>>> The point here is that the measured value and the static value are
>>> added
>>>> together and the sum is transmitted in this field. I'd suggest...
>>>> 
>>>>  Implementations MAY also permit the configuration of a static (non
>>>>  dynamic) offset value (in microseconds) to be added to the measured
>>> 
>>>>  delay value before encoding into this TLV, to facilitate the
>>>>  communication of operator specific delay constraints.
>>>> 
>>>> Similarly in 4.2.6.
>>>> 
>>>> ---
>>>> 
>>>> 4.2.7 appears out of sequence. But since it repeats the content of
>>>> 4.2.4 I suggest you merge them and talk about the plurality of fields.
>>>> 
>>>> ---
>>>> 
>>>> Section 7
>>>> 
>>>> "Sections 6 and 7 provide" should be 5 and 6.
>>>> 
>>>> ---
>>>> 
>>>> Section 10
>>>> 
>>>>  "As per (RFC3630), unrecognized TLVs should be silently ignored"
>>>> 
>>>> There has been confusion about what 3630 means by "silently ignored".
>>>> In particular, some enthusiastic implementations thought this meant
>>> the
>>>> TLVs should be stripped from the LSA before it is propagated. I think
>>> it
>>>> is worth the few words to explicitly state that this is not the case.
>>>> 
>>>> ---
>>>> 
>>>> Section 13
>>>> 
>>>> RFC 4203 is used in a normative way, please move it to the other
>>>> section.
>>>> 
>>>> 
>>>> 
>>> 
>