Re: [Insipid] Eric Rescorla's Discuss on draft-ietf-insipid-logme-marking-12: (with DISCUSS and COMMENT)

Eric Rescorla <ekr@rtfm.com> Tue, 14 August 2018 17:50 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: insipid@ietfa.amsl.com
Delivered-To: insipid@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8610A1277C8 for <insipid@ietfa.amsl.com>; Tue, 14 Aug 2018 10:50:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, T_DKIMWL_WL_MED=-0.01] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=rtfm-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FUQ15jQ4dpaQ for <insipid@ietfa.amsl.com>; Tue, 14 Aug 2018 10:50:19 -0700 (PDT)
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BBC21130EBE for <insipid@ietf.org>; Tue, 14 Aug 2018 10:50:15 -0700 (PDT)
Received: by mail-lf1-x134.google.com with SMTP id a4-v6so14394621lff.5 for <insipid@ietf.org>; Tue, 14 Aug 2018 10:50:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rtfm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rbyXXmUTRpj1o6eR98jfs7a0d10y4KM3LosXYkgNXpY=; b=NRezj23OEZcSJDFB6CthhR0gOk3xZJhyPf6Nk5LzQ1758GiaGKZ+GH62oK70jo5AqS CBEby/k54ApLPKlEDD+K1Yxz/mjhsP2nWUVyrWOBdm9p7VtjjrVfFhNeKkGFG3fMKm/t I0gNoR0WQ+DfjVg/aaIjJ+BqqQ5BVi/L7TAm3Xd8O/e98E3KOopm+vW5p2kYGT7nJmcZ T2Cke3N21h03Ca9DUQo6EFrssHtKzjT7BeLSLzTD3+OWQcb9v9Fo09WxXAJkC0DRYbMk RRbYT0KXCy+S21GWLDRNmWxfatvpQcarQtIoH/qppVABseXdPueydHxtOirco4EphEBz Ta+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rbyXXmUTRpj1o6eR98jfs7a0d10y4KM3LosXYkgNXpY=; b=h7midquckSGmmyOQ8Zl6pXi5vf0h7w94Eb1x3OYeBcb+NwC30CJhEcBLZdML+RKP+x YktF9K0ziIDCjv+5uuNBKaq647W9uU7bZ3Tph+pLaSznVNICpTS3x5t3swVMcScbU1N4 sPTgRhIjLAKqVZVm5eJsr/RjbyHNSKEs5s+f9/y4m87Xo9slxbNRLw1Tq/kD+DNI19xr cVyGSZBsnRpPDGMGzp9+mt2BS35rIJz57wUchGaQ78OUgTqbzWvGF/aGYpLuO4hNS5SJ 5kJQB4GjBcz8fKkZrQq2cQLacEdKh8Sk6EGMYkVaw9g3/9T4wAHQ4kLPywW3ZFGIYVUM Xhxw==
X-Gm-Message-State: AOUpUlHoWDQXkLrLKCrAbNUV0ohO4NVK9CE321uPnuw6PWJv5SLP8IyE 1/BxicRtGXY3dVNCE17inhwGR/hp3eROWwzSuYGc7A==
X-Google-Smtp-Source: AA+uWPzD0oasGwmS9ohzVk5a3fCD+sU7+MmfEWLvHA7TjlQ5ejD22SZRaqUQje5BkIMKI72Cd7C/rjXqUIFx32xqykM=
X-Received: by 2002:a19:1749:: with SMTP id n70-v6mr14097427lfi.54.1534269013935; Tue, 14 Aug 2018 10:50:13 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ab3:4091:0:0:0:0:0 with HTTP; Tue, 14 Aug 2018 10:49:33 -0700 (PDT)
In-Reply-To: <331AD917-D401-4B85-AD52-5A6607226823@cisco.com>
References: <153419287407.25053.6083538589111644157.idtracker@ietfa.amsl.com> <331AD917-D401-4B85-AD52-5A6607226823@cisco.com>
From: Eric Rescorla <ekr@rtfm.com>
Date: Tue, 14 Aug 2018 10:49:33 -0700
Message-ID: <CABcZeBO2vGB4oVEhsjhJ2+p66tLBEecpaX3DmYk6Z5br1itoeQ@mail.gmail.com>
To: "Arun Arunachalam (carunach)" <carunach@cisco.com>
Cc: Adam Roach <adam@nostrum.com>, Ben Campbell <ben@nostrum.com>, The IESG <iesg@ietf.org>, "draft-ietf-insipid-logme-marking@ietf.org" <draft-ietf-insipid-logme-marking@ietf.org>, "insipid@ietf.org" <insipid@ietf.org>, "Gonzalo Salgueiro (gsalguei)" <gsalguei@cisco.com>, "insipid-chairs@ietf.org" <insipid-chairs@ietf.org>, "Dawes, Peter, Vodafone Group" <Peter.Dawes@vodafone.com>
Content-Type: multipart/alternative; boundary="00000000000090dd46057368d7ee"
Archived-At: <https://mailarchive.ietf.org/arch/msg/insipid/Xar_IGlBESumy_FuzXT5ZFCBaIE>
Subject: Re: [Insipid] Eric Rescorla's Discuss on draft-ietf-insipid-logme-marking-12: (with DISCUSS and COMMENT)
X-BeenThere: insipid@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SIP Session-ID discussion list <insipid.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/insipid>, <mailto:insipid-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/insipid/>
List-Post: <mailto:insipid@ietf.org>
List-Help: <mailto:insipid-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/insipid>, <mailto:insipid-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Aug 2018 17:50:22 -0000

On Tue, Aug 14, 2018 at 7:58 AM, Arun Arunachalam (carunach) <
carunach@cisco.com>; wrote:

> Hi Eric, Adam and Ben,
>
> Thanks for your comments!
>
> Please see inline.
>
> On Aug 13, 2018, at 4:41 PM, Eric Rescorla <ekr@rtfm.com>; wrote:
>
> Eric Rescorla has entered the following ballot position for
> draft-ietf-insipid-logme-marking-12: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-insipid-logme-marking/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> Rich version of this review at:
> https://mozphab-ietf.devsvcdev.mozaws.net/D7386
>
>
>
> DETAIL
> S 6.1.
>
>  6.1.  "Log Me" Authorization
>
>     An end user or network administrator MUST give permission for a
>     terminal to perform "log me" marking.  The configuration of a SIP
>     intermediary to perform "log me" marking on behalf of a terminal MUST
>     be authorized by the network administrator.
>
>
> This seems to contradict S 4.4.2, which describes how you get logging
> even when the responding UA doesn't support it (and thus presumably
> doesn't give permission). Perhaps you mean "at least one end user or
> administrator…?
>
>
>
> The statement "An end user or network administrator MUST give
> permission….” is applicable for scenarios in which the terminal supports
> “log me” marking. Whereas the statement “The configuration of a SIP
> intermediary to perform…” is applicable when the terminal doesn’t support
> “log me” marking.
>
> We can rephrase this paragraph as:
>
> “Log me” marking MUST be disabled by default both at the endpoints and
> intermediaries and MUST be enabled only by authorized users. For example,
> an end user or network administrator must give permission for a terminal
> that supports “log me” marking in order to initiate marking. Similarly, a
> network administrator must enable a configuration at the SIP intermediary
> to perform "log me" marking on behalf of a terminal that doesn’t support
> “log me” marking. The permission MUST be limited to only specific calls of
> interest that are originated in a given time duration.
>

Sure.

S 6.4.2.
>
>     store all the SIP messages that are exchanged within a given dialog.
>     SIP messages can contain the personal identifiers listed in
>     Section 6.4.1 and additionally a user identity, calling party number,
>     IP address, hostname, and other user and device related items.  The
>     SIP message bodies describe the kind of session being set up by the
>     identified end user and device.
>
>
> This seems to have extremely negative consequences when security
> descriptions is used. It seems like you need to prohibit their
> combination or at least call this out.
>
>
> We can add the following lines to Section 8.4.2
>
> When the SIP SDP message body contains security descriptions in the
> “crypto” attribute [RFC4568], the attribute value MUST be masked with a
> dummy value prior to storing the message in a log file. For example, the
> attribute value can be replaced with a string of special characters like
> “X”, “*” and “#” as shown in the example below.
>
> a=crypto:XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
> XXXXXXXXXXXXX
>

That would be OK. It would be useful perhaps, to go through all the
possible contents of SIP messages and sort out which contents would a
problem if disclosed.

-Ekr


>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> S 3.6.
>
>
>  3.6.  Format of Logged Signaling
>
>     The entire SIP message (SIP headers and message body) MUST be logged.
>     Logging SHOULD use common standard formats such as the SIP CLF
>     defined in [RFC6873] and Libpcap.  If SIP CLF format is used, the
>
>
> Reference for libpcap?
>
>
> We can use the reference provided by Adam.
>
> Modified text:
>
> "defined in [RFC6873] and Libpcap [application/vnd.tcpdump.pcap
> <https://www.iana.org/assignments/media-types/application/vnd.tcpdump.pcap>
> ].  If SIP CLF format is used, the….”
>
> Thanks!
> Peter & Arun
>
>
>
>
>
>