Re: [Insipid] Eric Rescorla's Discuss on draft-ietf-insipid-logme-marking-12: (with DISCUSS and COMMENT)

[Eric Rescorla <[e-mail]>]

On Tue, Aug 14, 2018 at 7:58 AM, Arun Arunachalam (carunach) <
[e-mail]> wrote:

> Hi Eric, Adam and Ben,
>
> Thanks for your comments!
>
> Please see inline.
>
> On Aug 13, 2018, at 4:41 PM, Eric Rescorla <[e-mail]> wrote:
>
> Eric Rescorla has entered the following ballot position for
> draft-ietf-insipid-logme-marking-12: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-insipid-logme-marking/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> Rich version of this review at:
> https://mozphab-ietf.devsvcdev.mozaws.net/D7386
>
>
>
> DETAIL
> S 6.1.
>
>  6.1.  "Log Me" Authorization
>
>     An end user or network administrator MUST give permission for a
>     terminal to perform "log me" marking.  The configuration of a SIP
>     intermediary to perform "log me" marking on behalf of a terminal MUST
>     be authorized by the network administrator.
>
>
> This seems to contradict S 4.4.2, which describes how you get logging
> even when the responding UA doesn't support it (and thus presumably
> doesn't give permission). Perhaps you mean "at least one end user or
> administrator…?
>
>
>
> The statement "An end user or network administrator MUST give
> permission….” is applicable for scenarios in which the terminal supports
> “log me” marking. Whereas the statement “The configuration of a SIP
> intermediary to perform…” is applicable when the terminal doesn’t support
> “log me” marking.
>
> We can rephrase this paragraph as:
>
> “Log me” marking MUST be disabled by default both at the endpoints and
> intermediaries and MUST be enabled only by authorized users. For example,
> an end user or network administrator must give permission for a terminal
> that supports “log me” marking in order to initiate marking. Similarly, a
> network administrator must enable a configuration at the SIP intermediary
> to perform "log me" marking on behalf of a terminal that doesn’t support
> “log me” marking. The permission MUST be limited to only specific calls of
> interest that are originated in a given time duration.
>

Sure.

S 6.4.2.
>
>     store all the SIP messages that are exchanged within a given dialog.
>     SIP messages can contain the personal identifiers listed in
>     Section 6.4.1 and additionally a user identity, calling party number,
>     IP address, hostname, and other user and device related items.  The
>     SIP message bodies describe the kind of session being set up by the
>     identified end user and device.
>
>
> This seems to have extremely negative consequences when security
> descriptions is used. It seems like you need to prohibit their
> combination or at least call this out.
>
>
> We can add the following lines to Section 8.4.2
>
> When the SIP SDP message body contains security descriptions in the
> “crypto” attribute [RFC4568], the attribute value MUST be masked with a
> dummy value prior to storing the message in a log file. For example, the
> attribute value can be replaced with a string of special characters like
> “X”, “*” and “#” as shown in the example below.
>
> a=crypto:XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
> XXXXXXXXXXXXX
>

That would be OK. It would be useful perhaps, to go through all the
possible contents of SIP messages and sort out which contents would a
problem if disclosed.

-Ekr


>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> S 3.6.
>
>
>  3.6.  Format of Logged Signaling
>
>     The entire SIP message (SIP headers and message body) MUST be logged.
>     Logging SHOULD use common standard formats such as the SIP CLF
>     defined in [RFC6873] and Libpcap.  If SIP CLF format is used, the
>
>
> Reference for libpcap?
>
>
> We can use the reference provided by Adam.
>
> Modified text:
>
> "defined in [RFC6873] and Libpcap [application/vnd.tcpdump.pcap
> <https://www.iana.org/assignments/media-types/application/vnd.tcpdump.pcap>
> ].  If SIP CLF format is used, the….”
>
> Thanks!
> Peter & Arun
>
>
>
>
>
>