Re: [Int-dir] Intdir early review of draft-ietf-tictoc-1588v2-yang-07
Jiangyuanlong <jiangyuanlong@huawei.com> Fri, 15 June 2018 03:34 UTC
Return-Path: <jiangyuanlong@huawei.com>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 11485130DC4; Thu, 14 Jun 2018 20:34:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZsXMtW-Je9Eu; Thu, 14 Jun 2018 20:34:08 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3B93127332; Thu, 14 Jun 2018 20:34:06 -0700 (PDT)
Received: from lhreml709-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id B1DF4BDDA9088; Fri, 15 Jun 2018 04:33:59 +0100 (IST)
Received: from DGGEML406-HUB.china.huawei.com (10.3.17.50) by lhreml709-cah.china.huawei.com (10.201.108.32) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 15 Jun 2018 04:33:44 +0100
Received: from DGGEML512-MBX.china.huawei.com ([169.254.2.130]) by dggeml406-hub.china.huawei.com ([10.3.17.50]) with mapi id 14.03.0382.000; Fri, 15 Jun 2018 11:33:33 +0800
From: Jiangyuanlong <jiangyuanlong@huawei.com>
To: Dave Thaler <dthaler@microsoft.com>, "int-dir@ietf.org" <int-dir@ietf.org>
CC: "draft-ietf-tictoc-1588v2-yang.all@ietf.org" <draft-ietf-tictoc-1588v2-yang.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "tictoc@ietf.org" <tictoc@ietf.org>
Thread-Topic: Intdir early review of draft-ietf-tictoc-1588v2-yang-07
Thread-Index: AQHUBCr1hB8djRDkx0G+86Sna78duqRgpztQ
Date: Fri, 15 Jun 2018 03:33:32 +0000
Message-ID: <3B0A1BED22CAD649A1B3E97BE5DDD68BBC0E7DE7@dggeml512-mbx.china.huawei.com>
References: <152901355790.26571.11611749129899888335@ietfa.amsl.com>
In-Reply-To: <152901355790.26571.11611749129899888335@ietfa.amsl.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.74.202.215]
Content-Type: multipart/mixed; boundary="_002_3B0A1BED22CAD649A1B3E97BE5DDD68BBC0E7DE7dggeml512mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/3J8eLzxvG8Z9bGOJJBoD2zyhgWs>
Subject: Re: [Int-dir] Intdir early review of draft-ietf-tictoc-1588v2-yang-07
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2018 03:34:15 -0000
Dave, Thank you a lot for your thorough review. I have replied in the PDF document (accepted all the editorial ones, and suggested some resolutions to the inconsistent or ambiguous terminologies). I believe all the issues are solved, but please check the appended document. Best regards, Yuanlong -----Original Message----- From: Dave Thaler [mailto:dthaler@microsoft.com] Sent: Friday, June 15, 2018 5:59 AM To: int-dir@ietf.org Cc: draft-ietf-tictoc-1588v2-yang.all@ietf.org; ietf@ietf.org; tictoc@ietf.org Subject: Intdir early review of draft-ietf-tictoc-1588v2-yang-07 Reviewer: Dave Thaler Review result: Ready with Nits I have reviewed draft-ietf-tictoc-1588v2-yang-07 as assigned int-dir reviewer. The draft was readable and technically good (though I am not an expert on either YANG or IEEE 1588-2008. I do have a number of nits indicated in the marked up copy at https://www.microsoft.com/en-us/research/uploads/prod/2018/06/draft-ietf-tictoc-1588v2-yang-07.pdf The most notable piece of feedback is that it's not clear what the units are for several integer objects. Dave
- Re: [Int-dir] Intdir early review of draft-ietf-t… Jiangyuanlong
- [Int-dir] Intdir early review of draft-ietf-ticto… Dave Thaler