Re: [Int-dir] Intdir telechat review of draft-ietf-dnsop-svcb-https-08

Ben Schwartz <bemasc@google.com> Tue, 19 April 2022 18:00 UTC

Return-Path: <bemasc@google.com>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5A8BC3A0FC5 for <int-dir@ietfa.amsl.com>; Tue, 19 Apr 2022 11:00:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.608
X-Spam-Level:
X-Spam-Status: No, score=-17.608 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TjJpJOQkJUlj for <int-dir@ietfa.amsl.com>; Tue, 19 Apr 2022 11:00:06 -0700 (PDT)
Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 36E5A3A0FB0 for <int-dir@ietf.org>; Tue, 19 Apr 2022 11:00:06 -0700 (PDT)
Received: by mail-wm1-x32d.google.com with SMTP id r64so11180875wmr.4 for <int-dir@ietf.org>; Tue, 19 Apr 2022 11:00:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4+xdwL7cS3hTzQHWZizzvEIaY9RWFloGcoeAryENoqU=; b=WG66v16DfTEun2wMV/QtvZHyWq5XFQDwAyVouctVOwtycuLLvtZ969+yPoovFEVyyo 1SjFkGzAeJVzE69fzrMdaMehCNS9IXfyfj6vp6hHte/idzJ+4BkZjd77jj+mwd5KFIKA s2bHiKhd72hCa5udnU6zm4CJZrTLIcerRXcWzMYEGjc4wJ6Gx0w8TvnL4Dg0wqqkIGIo 0lvgLJnTsi9Xi7ZCw+uAayvbXIyr+SyCn1c+pSNdoDPrb/e21Sm+23xGkvOEPyE3hVo4 dKQxfkigEOA3O50iscxAb2BAt1pmFxFkxJoNeaxnM9sPvvCSznSlUR5njkH97fF8oedU lQZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4+xdwL7cS3hTzQHWZizzvEIaY9RWFloGcoeAryENoqU=; b=xWA96AYW/lxjzFxZoVDfRA3i/L55hFvU8TkXgYhg1UHMF0KuHGT5Yxlb1uW13ml59J JLKU3OIzNZ1lAW119EcqGBD7vtIiNwfkhDXhOA4qi14bOBxcgdELQJUmmavPCc3p+6cX dVlFw4NH3V7fp/pMD5h3UFOcU+mvsFxdGNhC9HGUTbWrOfcC0V3Z/0B9VxzKGCWY0OBW ja7fPNkxlYDQ1U2PV62+RwrxLgzu/qILR13NCJmRDf24dKhf3Y4yY19N6GuiPl5SOFFn YMnQ3ItRSQfVPaNezZvbP+rbvD5mX7PmljibXm0hnrKjFZzUM36O3+5LJ69AxcbNIZle tftQ==
X-Gm-Message-State: AOAM533ER9dEZshOJ+z0n+nmDrO88PvUidvH9x4U7uRmUW9xoR485BUe fl9gJFBdwsJmotl1N25Hqo6GXY4rkWFidZ+jrZaYruPKHbaXKA==
X-Google-Smtp-Source: ABdhPJzUR65OKQi2Gvm0aP/TdQucTtrZTI6zzfwO4MreLDRbetj0ZjgfKWEmNntidXNp2qP/lnlQ0pdQrKyVGGMf7kY=
X-Received: by 2002:a7b:c0d5:0:b0:38e:ca29:f40 with SMTP id s21-20020a7bc0d5000000b0038eca290f40mr17163180wmh.205.1650391204192; Tue, 19 Apr 2022 11:00:04 -0700 (PDT)
MIME-Version: 1.0
References: <165038223911.7532.5891611392351457956@ietfa.amsl.com>
In-Reply-To: <165038223911.7532.5891611392351457956@ietfa.amsl.com>
From: Ben Schwartz <bemasc@google.com>
Date: Tue, 19 Apr 2022 13:59:52 -0400
Message-ID: <CAHbrMsBNPaXmPjabrDiwu=WCDxUHCr7jLYD7CvmR1qRwTo3=JQ@mail.gmail.com>
To: Carlos Pignataro <cpignata@cisco.com>
Cc: int-dir@ietf.org, dnsop <dnsop@ietf.org>, draft-ietf-dnsop-svcb-https.all@ietf.org, last-call@ietf.org
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg="sha-256"; boundary="0000000000007e402e05dd05a5a8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/Ks8zJzfEAsqpiQnNm-cxMYSYlwQ>
Subject: Re: [Int-dir] Intdir telechat review of draft-ietf-dnsop-svcb-https-08
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2022 18:00:09 -0000

On Tue, Apr 19, 2022 at 11:30 AM Carlos Pignataro via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Carlos Pignataro
> Review result: Ready with Nits
>
> I am an assigned INT directorate reviewer for draft-ietf-dnsop-svcb-https.
> These comments were written primarily for the benefit of the Internet Area
> Directors. Document editors and shepherd(s) should treat these comments
> just
> like they would treat comments from any other IETF contributors and resolve
> them along with any other Last Call comments that have been received. For
> more
> details on the INT Directorate, see
> https://datatracker.ietf.org/group/intdir/about/
> <https://datatracker.ietf.org/group/intdir/about/>.
>
> This document specifies the "SVCB" and "HTTPS" DNS resource record (RR)
> types
> to facilitate the lookup of information needed to make connections to
> network
> services, such as for HTTP origins.
>
> This document is clear and comprehensive. Specifically, rev -08 improved
> structure, terminology, and readability. It seems ready modulo some nits.
>
> Editorial suggestions:
> * s/followup/follow-up/g
> * "   *  Fallback to the the client's non-Alt-Svc connection behavior" -->
> duplicate "the" * "IANA from the "Resource Record (RR) TYPEs" subregistry"
> -->
> looks like that's a registry, not sub-registry (same with other parts of
> the
> IANA sections) * s/e.g./e.g.,/g * "2 octet field" -> "2-octet field"
>

Thanks for flagging these style issues.  I've proposed these changes in a
Github Pull Request [1], except for the comma changes (which appear to be a
contested point of English style).

[1] https://github.com/MikeBishop/dns-alt-svc/pull/390


> Editorially, I find this construct a bit interesting -- indirections, and
> wonder if a bit more context can be added to S7.5. 7.5.  "mandatory"
>    See Section 8.
> 8.  ServiceMode RR compatibility and mandatory keys
>

Yes, this is a bit odd, as is the forward reference for "ech".  However, it
avoids disrupting the flow of Section 7 with extensive subsections, and
helps to highlight important material.

I have no strong opinions about how this ought to be laid out in the
document.

Thank you for your consideration,
>
> Carlos.
>
>
>