MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Dave Thaler via Datatracker <noreply@ietf.org>
To: <int-dir@ietf.org>
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: 
 <172357089271.963513.5728716417559734076@dt-datatracker-6df4c9dcf5-t2x2k>
Date: Tue, 13 Aug 2024 10:41:32 -0700
Message-ID-Hash: B3HXXORBASLEQZADF2NAOA36G7YR4N2P
CC: bess@ietf.org, draft-ietf-bess-evpn-fast-df-recovery.all@ietf.org,
 last-call@ietf.org
Reply-To: Dave Thaler <dave.thaler.ietf@gmail.com>
Subject: =?utf-8?q?=5BInt-dir=5D_Intdir_telechat_review_of_draft-ietf-bess-evpn-fast-?=
	=?utf-8?q?df-recovery-09?=
Archived-At: 
 <https://mailarchive.ietf.org/arch/msg/int-dir/_k0K5M06_7CSAl2pf2b-iKWKGiw>

Reviewer: Dave Thaler
Review result: Ready with Nits

I am the assigned INTDIR reviewer.  I found the document
well written and easy to read, other than a number of
typos and grammatical errors. 

A PDF with my comments marked up inline can be found at:
https://1drv.ms/b/s!Aqj-Bj9PNivcn_xoEc8XRepNkAgJaQ?e=7keL4H

A few of my comments are listed below, but see the PDF for
many more trivial ones.

Section 1.4: "The fast DF recovery solution maintains backwards-compatibility
      (see Section 4) by ensuring that PEs any unrecognized new BGP
      Extended Community."
I can't parse grammar around "PEs any unrecognized".  Perhaps a
word missing?

Section 2.1: Is it worth adding that the seconds are encoded
in network byte order? This might be assumed by most readers
but might not hurt to say explicitly.  Up to you.

Section 3: "To maintain the preference for minimal loss over duplicate traffic,
   PE1 should carve slightly before PE2 (with skew)."
Should the "should" be MUST or SHOULD?

Section 4: "[RFC7432] and do not rely on the new SCT BGP extended community."
And what?  Seems like something is missing here.

Dave