[Int-dir] Intdir telechat review of draft-ietf-pim-3228bis-06

Dave Thaler via Datatracker <noreply@ietf.org> Thu, 25 July 2024 18:44 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: int-dir@ietf.org
Delivered-To: int-dir@ietfa.amsl.com
Received: from [10.244.2.81] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id A5C6BC151534; Thu, 25 Jul 2024 11:44:47 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Dave Thaler via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.19.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <172193308730.1062129.15289362548122263012@dt-datatracker-659f84ff76-9wqgv>
Date: Thu, 25 Jul 2024 11:44:47 -0700
Message-ID-Hash: 76G5DTXRCHFGQL2SVVMAW3HHPUVDNQVC
X-Message-ID-Hash: 76G5DTXRCHFGQL2SVVMAW3HHPUVDNQVC
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-int-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-pim-3228bis.all@ietf.org, last-call@ietf.org, pim@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Dave Thaler <dave.thaler.ietf@gmail.com>
Subject: [Int-dir] Intdir telechat review of draft-ietf-pim-3228bis-06
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/hNGB_iO4FJNeDu7HAREdizRdH-A>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Owner: <mailto:int-dir-owner@ietf.org>
List-Post: <mailto:int-dir@ietf.org>
List-Subscribe: <mailto:int-dir-join@ietf.org>
List-Unsubscribe: <mailto:int-dir-leave@ietf.org>

Reviewer: Dave Thaler
Review result: Ready with Nits

A PDF with my comments marked up inline can be found at
https://1drv.ms/b/s!Aqj-Bj9PNivcn_tvdayAlL9xJZJgKQ?e=K42XOF

Overall the document is well written, and easy to follow.
That said, I have several specific suggestions:

Section 2.1.2 (MLD): The registry itself is labeled as policy “IETF Review” but
the words “IETF Review” per se never appear in RFC 4443.  I’d recommend
explicitly saying IETF Review here.

Section 2.2 (Resv Bit): This column heading is confusing. In RFC 9279, the
“Resv” field is only 3 bits wide, whereas in RFC 3810 and 3376 it is 4 bits
wide.  And in both 3810bis and 3376bis it is called “Flags”, never “Resv”.  I'd
recommend "Flags Bit" for consistency with 3810bis and 3376bis.

Section 2.2 (values in the Resv Bit column): These values may be hard to
understand. I’d recommend explicitly saying this is the value of the column
header in the packet format diagrams in 3810bis section 5.1 and R376bis section
4.1.

Section 2.3 (values in the Flags Bit column): Likewise I would add a sentence
explaining the bit number corresponds to the column label in the packet format
tables in 3810bis section 5.2 and 3376bis section 4.2.

Section 4 (Contributors): currently says "RFC 3228 ... forms a portion of the
content contained herein".  I recommend changing "forms" to "provided".

Section 5 (Acknowledgements): This is an empty section.  Remove it or fill it
in.

Section 6.2 (Informative References): I think 3376bis and 3810bis are both used
normatively, not informatively.