[Int-dir] Intdir telechat review of draft-ietf-emu-rfc7170bis-16

Haoyu Song via Datatracker <noreply@ietf.org> Fri, 10 May 2024 22:48 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: int-dir@ietf.org
Delivered-To: int-dir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C4869C1DA2E4; Fri, 10 May 2024 15:48:30 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Haoyu Song via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.11.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171538131078.51665.6151553946391130729@ietfa.amsl.com>
Date: Fri, 10 May 2024 15:48:30 -0700
Message-ID-Hash: MXTXDJUDXPDPB6B4XATDVS6IS4FNDQTN
X-Message-ID-Hash: MXTXDJUDXPDPB6B4XATDVS6IS4FNDQTN
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-int-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-emu-rfc7170bis.all@ietf.org, emu@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Haoyu Song <haoyu.song@futurewei.com>
Subject: [Int-dir] Intdir telechat review of draft-ietf-emu-rfc7170bis-16
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/jyDarBq2Vl4ozTCkDb-9SaBSLRs>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Owner: <mailto:int-dir-owner@ietf.org>
List-Post: <mailto:int-dir@ietf.org>
List-Subscribe: <mailto:int-dir-join@ietf.org>
List-Unsubscribe: <mailto:int-dir-leave@ietf.org>

Reviewer: Haoyu Song
Review result: Ready with Nits

I’m the assigned INTDIR reviewer for this document. This document defines the
Tunnel Extensible Authentication Protocol V1 which obsoletes RFC7010.

I couldn’t find any technical issues, but some nits as listed below.

Please spell out the acronyms in the first use, e.g., PKCS

Pg13 “In some cases such as onboarding …”.  It may be necessary to elaborate
the terms used here.

Pg14  “It will therefore no way of correlating the server identity…”  Grammer
check

Pg18 “MUST accompany the TLV with it's own Crypto-Binding TLV”     it’s own ->
its own

Pg18 “to communicate a users password,”   users -> user’s

Pg 20.  “EAP- FAST [RFC4851]”   remove the space after EAP-

Pg 22. “it requires a particular authentication mechanism be run”  be run -> to
be run

Pg. 24 “in all phases of TEAP’  all -> both?

Pg27. “The device authentications, and obtains new credentials via” 
authentications, -> authenticates

Pg31. “If the server didn't initiate …”   didn’t -> did not

Pg 34. “If all TLVs in a message are marked optional and none are understood by
the peer, then a NAK TLV or Result TLV could be sent to the other side in order
to continue the conversation.” The two sentences seem logically conflicting
with each other.

Pg38. “The behavior of the Result TLV is further discussed in Section 3.6.5 and
Section 3.9.3 A Result” missing period before A Result.

Pg.46. “after one or more of the requested items has been processed …”   has ->
have

Pg 60. “The Identity-Hint TLV is an optional TLV which can sent by the peer” 
can sent -> can be sent

Pg 60. “the format and definition of these identities is entirely site local.” 
 is -> are

Pg 64. “Note that using a MSK…” a -> an

Thanks,
Haoyu