Re: [iola-conversion-tool] Bug in Datatracker Agenda Code?

[Henrik Levkowetz <[e-mail]>]

Hi Ryan,

On 2012-03-21 15:17 Ryan Cross said:
> Hi Henrik,
> 
> On Mar 5, 2012, at 10:06 AM, Henrik Levkowetz wrote:
> 
>> 3. Even after I fixed the things above, I went 'round and 'round a
>> couple of times, as I only saw a blank space where the agenda
>> should have been.  This seems to have been caused by the uploaded
>> document having a mac character set encoding and mac line-endings
>> -- Ryan, you maybe should investigate that further, and see if you
>> should do character set and line-ending conversion.  I think what's
>> on disk should either be ascii or unicode -- for drafts we check
>> that it's pure ascii, but the agendas are different, and we should
>> maybe enforce unicode?

> Does this mean the code is parsing the agenda file?  Does it need to
> do this?  I'm happy to add character set validation, but this would
> affect everyone submitting agenda's so I want to be sure that is the
> official requirement.

No, the code isn't parsing the agenda file, but the file is being
displayed through web browsers, and if you tell the browsers it's
latin-1 when it's utf-8, or vice versa, things don't look good.
And for mac line-endings things can get so bad that the browser
doesn't show anything at all in some circumstances -- that seemed to
be what happened above.

Best regards,

	Henrik