Re: [iola-conversion-tool] Bug when Adding a document to the tracker

Robert Sparks <rjsparks@nostrum.com> Wed, 22 February 2012 21:03 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: iola-conversion-tool@ietfa.amsl.com
Delivered-To: iola-conversion-tool@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9E5B621E804B for <iola-conversion-tool@ietfa.amsl.com>; Wed, 22 Feb 2012 13:03:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102
X-Spam-Level:
X-Spam-Status: No, score=-102 tagged_above=-999 required=5 tests=[AWL=-0.600, BAYES_00=-2.599, J_CHICKENPOX_32=0.6, J_CHICKENPOX_35=0.6, SPF_PASS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P+OnEzl0du7L for <iola-conversion-tool@ietfa.amsl.com>; Wed, 22 Feb 2012 13:03:55 -0800 (PST)
Received: from nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id 053D521F864D for <iola-conversion-tool@ietf.org>; Wed, 22 Feb 2012 13:03:54 -0800 (PST)
Received: from dn3-177.estacado.net (vicuna-alt.estacado.net [75.53.54.121]) (authenticated bits=0) by nostrum.com (8.14.3/8.14.3) with ESMTP id q1ML3mvO016377 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 22 Feb 2012 15:03:50 -0600 (CST) (envelope-from rjsparks@nostrum.com)
Message-ID: <4F455834.6050304@nostrum.com>
Date: Wed, 22 Feb 2012 15:03:48 -0600
From: Robert Sparks <rjsparks@nostrum.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1
MIME-Version: 1.0
To: iola-conversion-tool@ietf.org, Ole Laursen <olau@iola.dk>
References: <4F4415E7.9080608@nostrum.com> <CANb2OvKXRUarNY-Vp+CkA+7P5FZ1=_OfqyO67gOnKfx2bAARCQ@mail.gmail.com> <4F453B60.6010406@nostrum.com> <CANb2OvK6o0X58YmRM-JPMOA-L12ZqpCxu8jp+YDYTswvFeL0ag@mail.gmail.com>
In-Reply-To: <CANb2OvK6o0X58YmRM-JPMOA-L12ZqpCxu8jp+YDYTswvFeL0ag@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass (nostrum.com: 75.53.54.121 is authenticated by a trusted mechanism)
Subject: Re: [iola-conversion-tool] Bug when Adding a document to the tracker
X-BeenThere: iola-conversion-tool@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion of the IOLA / DB Schema Conversion Tool Project <iola-conversion-tool.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/iola-conversion-tool>
List-Post: <mailto:iola-conversion-tool@ietf.org>
List-Help: <mailto:iola-conversion-tool-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Feb 2012 21:03:55 -0000

Inline

On 2/22/12 2:52 PM, Ole Laursen wrote:
> 2012/2/22 Robert Sparks<rjsparks@nostrum.com>om>:
>> That's really surprising, and I want to double-check that we haven't
>> accidentally lost something.
> That's a good idea. I was going to say, "this is perhaps a surprise but".
>
>> Your search was on the production code?
> Yes.
>
>> I'm seeing idinternal.area_acronym get used in trunk at
>> idindex/views.py: def all_id2_entry(id):
>>   ....
>> ./idindex/views.py-    if id.idinternal:
>> ./idindex/views.py-        try:
>> ./idindex/views.py:            area = id.idinternal.area_acronym
> This code isn't actually in use as far as I can see. Most of the code
> in idindex is dead.
Ok - I agree (the only path into it is wrapped with code that only runs
when not in production mode).
>
>> and in the search form
>> /idrfc/views_search.py:
>> q_objs.append(Q(area_acronym=query['area']))
> This is a bit tricky, because this part is actually going to query the
> Rfc table (which is, by the way, not used much in the production
> code). I was looking at the code for I-Ds which says:
>
>      elif query['by'] == 'area':
>          q_objs.append(Q(**{prefix+"group__ietfwg__areagroup__area":query['area']}))
Fair enough.

So, I'm going to send a summary of this to the IESG (copying this list) 
to spread that bit of information around.

>
>> What are those replaced with in the new code?
> For the query, basically: either doc.group is WG and doc.group.parent
> is query area, or doc.group is individual submission and doc.ad area
> is query area:
>
>   docs = docs.filter(Q(group__type="wg", group__parent=query["area"]) |
>                                 Q(group__type="individ",
>                                   ad__role__name="ad",
>                                   ad__role__group=query["area"]))
>
>
> Ole
> _______________________________________________
> iola-conversion-tool mailing list
> iola-conversion-tool@ietf.org
> https://www.ietf.org/mailman/listinfo/iola-conversion-tool