Re: [iola-conversion-tool] Bug in discuss/comment email

Henrik Levkowetz <henrik@levkowetz.com> Fri, 17 February 2012 00:17 UTC

Return-Path: <henrik@levkowetz.com>
X-Original-To: iola-conversion-tool@ietfa.amsl.com
Delivered-To: iola-conversion-tool@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 735D721F856C for <iola-conversion-tool@ietfa.amsl.com>; Thu, 16 Feb 2012 16:17:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.556
X-Spam-Level:
X-Spam-Status: No, score=-102.556 tagged_above=-999 required=5 tests=[AWL=0.043, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KJckUHMNXzLM for <iola-conversion-tool@ietfa.amsl.com>; Thu, 16 Feb 2012 16:17:07 -0800 (PST)
Received: from merlot.tools.ietf.org (merlot.tools.ietf.org [IPv6:2a01:3f0:0:31::14]) by ietfa.amsl.com (Postfix) with ESMTP id 38FDD21F8566 for <iola-conversion-tool@ietf.org>; Thu, 16 Feb 2012 16:17:07 -0800 (PST)
Received: from 90-230-136-60-no45.tbcn.telia.com ([90.230.136.60]:54861 helo=[192.168.1.70]) by merlot.tools.ietf.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.77) (envelope-from <henrik@levkowetz.com>) id 1RyBVI-00054N-MH; Fri, 17 Feb 2012 01:16:54 +0100
Message-ID: <4F3D9C67.5010407@levkowetz.com>
Date: Fri, 17 Feb 2012 01:16:39 +0100
From: Henrik Levkowetz <henrik@levkowetz.com>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9
MIME-Version: 1.0
To: Ole Laursen <olau@iola.dk>
References: <4F3BE326.9050000@nostrum.com> <CANb2Ov+GER_HNvYKKY3dA11OGfKyv7YnzaKzj5oARi+oUeTXJA@mail.gmail.com>
In-Reply-To: <CANb2Ov+GER_HNvYKKY3dA11OGfKyv7YnzaKzj5oARi+oUeTXJA@mail.gmail.com>
X-Enigmail-Version: 1.1.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 90.230.136.60
X-SA-Exim-Rcpt-To: olau@iola.dk, iola-conversion-tool@ietf.org, presnick@qualcomm.com, henrik-sent@levkowetz.com
X-SA-Exim-Mail-From: henrik@levkowetz.com
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000)
X-SA-Exim-Scanned: Yes (on merlot.tools.ietf.org)
Cc: Pete Resnick <presnick@qualcomm.com>, iola-conversion-tool@ietf.org
Subject: Re: [iola-conversion-tool] Bug in discuss/comment email
X-BeenThere: iola-conversion-tool@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion of the IOLA / DB Schema Conversion Tool Project <iola-conversion-tool.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/iola-conversion-tool>
List-Post: <mailto:iola-conversion-tool@ietf.org>
List-Help: <mailto:iola-conversion-tool-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Feb 2012 00:17:21 -0000

On 2012-02-16 17:44 Ole Laursen said the following:
> 2012/2/15 Robert Sparks <rjsparks@nostrum.com>om>:
>> When adding a discuss to a document the mail that's generated is wrong (the
>> subject line misses the discuss and the body doesn't have the discuss text.
>> However the body says I entered a discuss.
>>
>> This is something I tested before and didn't see a problem. There is an
>> automated test that should have caught this too.
> 
> I expanded the test slightly, and sure enough, fail. I was checking
> the wrong attribute. Fixed now. Thanks to both of you!

Deployed!

	Henrik