Re: [IPFIX] Review of draft-irtf-nmrg-location-ipfix-07.txt

PJ Aitken <pjaitken@brocade.com> Fri, 03 March 2017 11:26 UTC

Return-Path: <paitken@Brocade.com>
X-Original-To: ipfix@ietfa.amsl.com
Delivered-To: ipfix@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F0A9A1297ED; Fri, 3 Mar 2017 03:26:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.519
X-Spam-Level:
X-Spam-Status: No, score=-1.519 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, KHOP_DYNAMIC=1.08, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BgAEqkFgYc8i; Fri, 3 Mar 2017 03:26:39 -0800 (PST)
Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [IPv6:2620:100:9001:7a::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D74DC1296F0; Fri, 3 Mar 2017 03:26:39 -0800 (PST)
Received: from pps.filterd (m0000542.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v23BQA2M016073; Fri, 3 Mar 2017 03:26:39 -0800
Received: from brmwp-exmb11.corp.brocade.com ([208.47.132.227]) by mx0a-000f0801.pphosted.com with ESMTP id 28xshuk031-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 03 Mar 2017 03:26:39 -0800
Received: from EMEAWP-EXMB11.corp.brocade.com (172.29.11.85) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 3 Mar 2017 04:26:36 -0700
Received: from [10.252.49.6] (10.252.49.6) by EMEAWP-EXMB11.corp.brocade.com (172.29.11.85) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 3 Mar 2017 12:26:30 +0100
To: Abdelkader Lahmadi <abdelkader.lahmadi@loria.fr>
References: <BBA82579FD347748BEADC4C445EA0F21A2260FE9@NKGEML515-MBX.china.huawei.com> <318bf874-2700-640e-e0c1-0ea7953b448f@gmail.com> <64CC7F98-8868-4BE5-ABE3-F6F01BF2FFF6@loria.fr> <cbc29c8a-5e11-7918-0afe-dfebafe0cd2c@gmail.com> <808e677f-f0ed-37de-2084-9f2074359658@brocade.com> <9F2B4045-D838-4D94-8B55-1599879537E2@loria.fr> <c056c266-5206-e87c-3535-d765e94b58ed@brocade.com> <24A6EB4E-2AED-4A31-A066-8D6EDB8E7C73@loria.fr>
From: PJ Aitken <pjaitken@brocade.com>
Message-ID: <f7a240af-05ba-a7c0-7238-f40a7a9cf249@brocade.com>
Date: Fri, 3 Mar 2017 11:26:23 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <24A6EB4E-2AED-4A31-A066-8D6EDB8E7C73@loria.fr>
Content-Type: multipart/alternative; boundary="------------EB37E06F49CFE2F45FDCA17B"
X-Originating-IP: [10.252.49.6]
X-ClientProxiedBy: hq1wp-excas11.corp.brocade.com (10.70.36.102) To EMEAWP-EXMB11.corp.brocade.com (172.29.11.85)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-03-03_08:, , signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703030102
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipfix/J-J9LT75R1zUstrrjZvjT5TMDv8>
Cc: "draft-irtf-nmrg-location-ipfix.authors@ietf.org" <draft-irtf-nmrg-location-ipfix.authors@ietf.org>, "Eggert, Lars" <lars@netapp.com>, "opsawg-chairs@ietf.org" <opsawg-chairs@ietf.org>, "IPFIX@ietf.org" <IPFIX@ietf.org>, "nmrg-chairs@ietf.org" <nmrg-chairs@ietf.org>
Subject: Re: [IPFIX] Review of draft-irtf-nmrg-location-ipfix-07.txt
X-BeenThere: ipfix@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IPFIX WG discussion list <ipfix.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipfix>, <mailto:ipfix-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipfix/>
List-Post: <mailto:ipfix@ietf.org>
List-Help: <mailto:ipfix-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipfix>, <mailto:ipfix-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Mar 2017 11:26:41 -0000

Great, thanks.

P.

On 03/03/17 11:17, Abdelkader Lahmadi wrote:
> Ok, more clear now.
> So, we work on a new text to resolve ALL the raised issues and send you a version.
>
> Best,
>> On 03 Mar 2017, at 12:07, PJ Aitken <pjaitken@brocade.com>; wrote:
>>
>> Abdelkader, it was me who did the IE-doctors review. That's only concerned with the IANA request; it's not an IPFIX review of the document.
>>
>> P.
>>
>>
>> On 03/03/17 11:01, Abdelkader Lahmadi wrote:
>>> Hello,
>>> We haven’t really get a "proper review" of the document by IPFIX experts. Recently, we had a discussion with IANA and they asked IE-doctors to make a review, since that we received some points to be fixed regarding the proposed IE. I can forward to you the other comments from IE-doctors that we have received by IANA.
>>>
>>> Thank you for your comments, Ok we will fix the raised issues in the document.
>>> Best regards.
>>>
>>>
>>>> On 03 Mar 2017, at 11:42, PJ Aitken <pjaitken@brocade.com>; wrote:
>>>>
>>>> Authors, has this document been reviewed by any IPFIX experts?
>>>>
>>>> I see a request on November 23rd, but no reviews. So let me sign up for that.
>>>>
>>>>
>>>> First, I took a quick look at the Figures in Appendix B:
>>>>
>>>> Figure 1: the Field Count should be 5, not 2.
>>>>
>>>> Figure 2: the size of the optional Padding field is wrong: the figure shows 9 bits rather than 8.
>>>>
>>>> Figure 4: the Length of 32 should be 28. The "geospatialLocationPosLat" Information Element isn't defined.
>>>>
>>>> Figure 5: the Field Count of 2 should be 3.
>>>>
>>>> Figure 7: The "geospatialLocationPostLng" and "geospatialLocationtLng" Information Elements aren't defined.
>>>>
>>>> Figure 9: The sizes of the "CivicValue" data fields are not shown correctly. eg, "Inria Nancy-Grand Est" is depicted in 6 octets when it should contain 21. Therefore the Figure is misleading and difficult to understand; it is not a good example. Please redraw the figure correctly. Please mark the variable-lengths eg "vlen = 21".
>>>>
>>>> Figure 11:
>>>>     The Set IDs (311, 312, 313) do not correspond to the Template IDs in Figure 10 (306, 307, 308).
>>>>     Again, the "Inria Nancy-Grand Grand Est" field is depicted in 6 octets rather than the requisite 27. Without the repeated "Grand", the 21 would be correct. Please write "vlen=21"
>>>>     The "Civic location Attr length" of 25 seems wrong.
>>>>
>>>>
>>>> This document is not ready for publication. Please post an updated version so I can check that all the IPFIX details are correct.
>>>>
>>>> Thanks,
>>>> P.
>> _______________________________________________
>> IPFIX mailing list
>> IPFIX@ietf.org
>> https://www.ietf.org/mailman/listinfo/ipfix
>
>
> _______________________________________________
> IPFIX mailing list
> IPFIX@ietf.org
> https://www.ietf.org/mailman/listinfo/ipfix