[IPFIX] review of draft-ietf-ipfix-mib-variable-export-07

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Wed, 17 December 2014 14:18 UTC

Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: ipfix@ietfa.amsl.com
Delivered-To: ipfix@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 41DB21A1B42 for <ipfix@ietfa.amsl.com>; Wed, 17 Dec 2014 06:18:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.56
X-Spam-Level:
X-Spam-Status: No, score=-1.56 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_EQ_DE=0.35, RCVD_IN_DNSWL_NONE=-0.0001, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OJKNEqZl4OqS for <ipfix@ietfa.amsl.com>; Wed, 17 Dec 2014 06:18:37 -0800 (PST)
Received: from atlas3.jacobs-university.de (atlas3.jacobs-university.de [212.201.44.18]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D45CF1A1AA4 for <ipfix@ietf.org>; Wed, 17 Dec 2014 06:18:36 -0800 (PST)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas3.jacobs-university.de (Postfix) with ESMTP id 2B7BB703 for <ipfix@ietf.org>; Wed, 17 Dec 2014 15:18:35 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas3.jacobs-university.de ([10.70.0.220]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10030) with ESMTP id 0tcnAdfYgbp8 for <ipfix@ietf.org>; Wed, 17 Dec 2014 15:18:19 +0100 (CET)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "Jacobs University CA - G01" (verified OK)) by atlas3.jacobs-university.de (Postfix) with ESMTPS for <ipfix@ietf.org>; Wed, 17 Dec 2014 15:18:34 +0100 (CET)
Received: from localhost (demetrius4.jacobs-university.de [212.201.44.49]) by hermes.jacobs-university.de (Postfix) with ESMTP id 0D6012002C for <ipfix@ietf.org>; Wed, 17 Dec 2014 15:18:34 +0100 (CET)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius4.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id FqwZWTPZCUWr; Wed, 17 Dec 2014 15:18:33 +0100 (CET)
Received: from elstar.local (elstar.jacobs.jacobs-university.de [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id A8D4720017; Wed, 17 Dec 2014 15:18:32 +0100 (CET)
Received: by elstar.local (Postfix, from userid 501) id BF6242FF917F; Wed, 17 Dec 2014 15:18:31 +0100 (CET)
Date: Wed, 17 Dec 2014 15:18:30 +0100
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: ipfix@ietf.org
Message-ID: <20141217141829.GA67945@elstar.local>
Mail-Followup-To: ipfix@ietf.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
Archived-At: http://mailarchive.ietf.org/arch/msg/ipfix/bwkTaNW5QpEzU9XNWBuX24HXw-k
Subject: [IPFIX] review of draft-ietf-ipfix-mib-variable-export-07
X-BeenThere: ipfix@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
List-Id: IPFIX WG discussion list <ipfix.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipfix>, <mailto:ipfix-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ipfix/>
List-Post: <mailto:ipfix@ietf.org>
List-Help: <mailto:ipfix-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipfix>, <mailto:ipfix-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Dec 2014 14:18:39 -0000

Hi,

here is my review of draft-ietf-ipfix-mib-variable-export-07. Most of
the comments are editorial or bug fixes. There is only one real
technical concern related to the encoding of BITS. The current I-D
uses a 64-bit unsigned integer, which limits things to 64 bit
positions. The SMIv2 does not have this limit - it only warns about
bit positions in excess of 128.

- RFC4293 is listed as a normative reference but as far as I can tell
  it is only used in an example. I suggest to make this an informative
  reference.

- p3: 2nd paragraph Introduction: I am not sure the statement "there
  are no dependencies between the SMIv2 and the SNMP protocol" is
  correct.  Perhaps the simplest fix is to simply delete the whole
  paragraph.

- p4: 1st paragraph Motivation: The 2nd sentence is hard to follow.

- p5: s/does not specify SNMP notifications/does not specify how to
  carry SNMP notifications in IPFIX/

- p9: s/in a certain MIB/in a certain MIB module/

- p10: s/may be also be/may also be/

- p10: s/described by the MIB./described by the MIB module./

- p14: s/when when/when/

- p14: s/references sections/referenced sections/

  The fact that every listed item refers to two sections may be a bit
  confusing, perhaps change to

  o  mibIndexIndicator (defined in Section 5.8.5, example in Section 11.2.2.3)

- p20: It took me a while to spot the difference between Fig. 7 and
  Fig.8 (I did not immediately spot that the fields are
  swapped). Perhaps mention this more explicitly in the last paragraph
  on p19?

     Figure 7 shows an IPFIX Options Template Set using Scope Existing
     IFPIX IE and a Non Scope mibObjectValueInteger IE, while Figure 8
     shows an IPFIX Options Template Set using a Scope
     mibObjectValueInteger IE and a Non Scope Existing IFPIX IE.

- p12: s/name of the MIB/name of the MIB module/

- p26: s/present the same order/present in the same order/

- p32: s/not defined as possible/not possible/

- p37: s/CISCO-PROCESS_MIB/CISCO-PROCESS-MIB/

- p45: s/ifMTU/ifMtu/ (this shows up several time, do a global replace)

- p46: Why is the Field Length of mibObjectValueOctetString set to 16?
       The interface names in general have variable length.

- p47: why 'ifName = ""'?

- p52: s/index by IEs:/indexed by IEs:/

- p58: The VLEN and the OID value seem to be wrong. I think this should
       be VLEN=10 and the OID value 06082B060102010E0A01.

- p61: I would have named SNMPtotalCounter simply snmpCounter and I
       would have named SNMPgauge snmpGauge. If this change is
       adopted, then these names needs to be changed in several
       places.

- p64: The encoding of mibObjectValueBits may need to specify how the
       bit positions are counted. That said, there is an issue here
       with using unsigned64. RFC 2578 does not restrict the bit
       positions, it only warns that using bit positions in excess of
       128 may cause interoperability problems. The IPFIX I-D
       essentially limits this to 64 bits. The obvious solution is to
       follow the SNMP encoding rules that encode bits into an octet
       string (an octetArray in IPFIX speak).

- p67: s/as defined in a MIB//

- p68: OLD

       Description: A non-negative sub-identifier.  One Sub number from
       an Object Identifier (OID).

       NEW

       Description: A non-negative sub-identifier of an Object
       Identifier (OID).

- p69: s/was retrieved from SNMP/was retrieved from the MIB/

- p70: s/could be sampled by SNMP/has been sampled/

- p70: s/SNMP sampling time/sampling time/

/js

-- 
Juergen Schoenwaelder           Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1, 28759 Bremen, Germany
Fax:   +49 421 200 3103         <http://www.jacobs-university.de/>