Re: [ippm] Zaheduzzaman Sarker's No Objection on draft-ietf-ippm-rfc8889bis-02: (with COMMENT)

Giuseppe Fioccola <giuseppe.fioccola@huawei.com> Thu, 14 July 2022 08:21 UTC

Return-Path: <giuseppe.fioccola@huawei.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 34813C1594AE; Thu, 14 Jul 2022 01:21:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.906
X-Spam-Level:
X-Spam-Status: No, score=-1.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h7SqjmBBX3gm; Thu, 14 Jul 2022 01:21:04 -0700 (PDT)
Received: from sinmsgout01.his.huawei.com (sinmsgout01.his.huawei.com [119.8.177.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1831BC1527AF; Thu, 14 Jul 2022 01:21:04 -0700 (PDT)
Received: from fraeml710-chm.china.huawei.com (unknown [172.18.156.148]) by sinmsgout01.his.huawei.com (SkyGuard) with ESMTP id 4Lk6ks4cJgz9xFJ7; Thu, 14 Jul 2022 16:16:05 +0800 (CST)
Received: from fraeml714-chm.china.huawei.com (10.206.15.33) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 14 Jul 2022 10:20:55 +0200
Received: from fraeml714-chm.china.huawei.com ([10.206.15.33]) by fraeml714-chm.china.huawei.com ([10.206.15.33]) with mapi id 15.01.2375.024; Thu, 14 Jul 2022 10:20:55 +0200
From: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
To: Zaheduzzaman Sarker <Zaheduzzaman.Sarker@ericsson.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-ippm-rfc8889bis@ietf.org" <draft-ietf-ippm-rfc8889bis@ietf.org>, "ippm-chairs@ietf.org" <ippm-chairs@ietf.org>, "ippm@ietf.org" <ippm@ietf.org>, "tpauly@apple.com" <tpauly@apple.com>
Thread-Topic: Zaheduzzaman Sarker's No Objection on draft-ietf-ippm-rfc8889bis-02: (with COMMENT)
Thread-Index: AQHYlvSDz0HHLPZ+R0+UJiYi4gSNv61840EQ
Date: Thu, 14 Jul 2022 08:20:55 +0000
Message-ID: <dc6d6c3a66354b7e990eff00e1c6f708@huawei.com>
References: <165774298444.31688.2835923603390855098@ietfa.amsl.com>
In-Reply-To: <165774298444.31688.2835923603390855098@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.81.214.207]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/-3amhgPkXlwn-nEYpQQPUSwFKMQ>
Subject: Re: [ippm] Zaheduzzaman Sarker's No Objection on draft-ietf-ippm-rfc8889bis-02: (with COMMENT)
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2022 08:21:08 -0000

Hi Zaheduzzaman,
Thank you for the revision,
Please find my reply inline tagged as [GF].
I will also address your comments in the next version.

Best Regards,

Giuseppe

-----Original Message-----
From: Zaheduzzaman Sarker via Datatracker <noreply@ietf.org> 
Sent: Wednesday, July 13, 2022 10:10 PM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-ippm-rfc8889bis@ietf.org; ippm-chairs@ietf.org; ippm@ietf.org; tpauly@apple.com; tpauly@apple.com
Subject: Zaheduzzaman Sarker's No Objection on draft-ietf-ippm-rfc8889bis-02: (with COMMENT)

Zaheduzzaman Sarker has entered the following ballot position for
draft-ietf-ippm-rfc8889bis-02: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ippm-rfc8889bis/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thanks for working on this specification.

I am supporting Roman, John, Alvaro's discuss.

I have following comments which I believe would improve the document quality,
if addressed.

## Section 2: I really didn't get the definition of the flow. May be it is my
lack of expertise in English language or the technology used here but when the
definition of flow is defined by flow ( is says- a flow can be
multipoint-to-multipoint flow) it becomes very difficult to understand. Are we
defining flow or identification of flow? It would be great to get a better
description of the definition of  "flow". I also agree with John's comment that
if a flow does not have traffic, is this also a flow? May be we merely defining
the link between network nodes as flow, then I would say the term flow is
overloaded.

Actually section 3 has a much better definition of flow. why don't we use that?

       "a flow can be defined by a set of selection rules used to
   match a subset of the packets processed by the network device.  These
   rules specify a set of Layer 3 and Layer 4 header fields
   (identification fields) and the relative values that must be found in
   matching packets"

[GF]: I see your point. To avoid confusion it is better to use only a single definition. I tend to agree that the definition in section 3 is more general and can be used to avoid misunderstanding.

## Section 2: according to the definition of the cluster, any single node can
be a cluster and measure of the that cluster will be same as point to point
measure defined in rfc8321bis (like node packet loss). is that correct
interpretation? if yes, rfc8321bis becomes a subset of this specification, is
that the intention?

[GF]: Yes it is correct.

## Section 2.1 : as group to group segments are not used to define cluster in
this specification, I would suggest following change -

       OLD text: the spatial metrics, used for measuring the performance of
       segments of a source to destination path, are applied here to
       group-to-group segments (called clusters).

       NEW text : the spatial metrics, used for measuring the performance of
       segments of a source to destination path, are applied here to
       clusters.

[GF]: Ok.

## Section 4.2 : What is "Non-initial fragments"?

[GF]: This definition is in RFC8321bis and means fragments originated by nodes within the domain. I have to add more explanation here or refer to RFC8321bis

## I think it is confusing when terms defined in the terminology section get
redefined in the later sections in a different way than how it is defined in
the terminology section. the term "cluster" is an example of such case. can we
stick to one single definition of cluster and other terms used in this document?

[GF]: Yes, as also raised in other reviews, I think it is better to define cluster only in the Terminology section and refer to it where needed. The same applies to the other terms.