Re: [ippm] Comments on draft-ietf-ippm-explicit-flow-measurements-00

"Lubashev, Igor" <ilubashe@akamai.com> Sun, 24 April 2022 18:13 UTC

Return-Path: <ilubashe@akamai.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8ED143A1228 for <ippm@ietfa.amsl.com>; Sun, 24 Apr 2022 11:13:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.103
X-Spam-Level:
X-Spam-Status: No, score=-2.103 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=akamai.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0-UbHHifkgEm for <ippm@ietfa.amsl.com>; Sun, 24 Apr 2022 11:13:11 -0700 (PDT)
Received: from mx0a-00190b01.pphosted.com (mx0a-00190b01.pphosted.com [IPv6:2620:100:9001:583::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE1F93A1227 for <ippm@ietf.org>; Sun, 24 Apr 2022 11:13:11 -0700 (PDT)
Received: from pps.filterd (m0050095.ppops.net [127.0.0.1]) by m0050095.ppops.net-00190b01. (8.17.1.5/8.17.1.5) with ESMTP id 23OFeKEv021247; Sun, 24 Apr 2022 19:13:06 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=jan2016.eng; bh=02pAHtNMuGtdbnayAZ2Q7NUjrH6S63u35Y/mCfpCplo=; b=NcbcbVxFhlWpQjVDl4SAdjKX/XtGUz3BZA5DZ1OGVxOGFJXjMYaeCRF5c/dVeoXAKsj0 pVEBYhvx3AN4woXsJOHxPWfnu3HbBJUwfsKEROXT+HBxnS6bsRcfZIkFnd2a//KeiJBT 60efWLaywcVhu2LD10Tdh2RH8PrcSnZf9/6guD/Ui3EhrwS5flzDu8ZbdTruaRe32LtI VR2W4UOvutjblS7+yKy3aHr9d1LuypHaTaaxFEABffgb6QoP7aZ0bf5ztLSIWgxNyzuj 2FaG2H4mhL6yWsV7TzZwCQbykkt2Cu4a/lK+FxrPoJcmWUeDEdxqhB0ZhryBIyEHnz9w ug==
Received: from prod-mail-ppoint1 (prod-mail-ppoint1.akamai.com [184.51.33.18] (may be forged)) by m0050095.ppops.net-00190b01. (PPS) with ESMTPS id 3fm907f3ae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 24 Apr 2022 19:13:06 +0100
Received: from pps.filterd (prod-mail-ppoint1.akamai.com [127.0.0.1]) by prod-mail-ppoint1.akamai.com (8.16.1.2/8.16.1.2) with SMTP id 23OI7EwO031475; Sun, 24 Apr 2022 14:13:04 -0400
Received: from email.msg.corp.akamai.com ([172.27.123.34]) by prod-mail-ppoint1.akamai.com with ESMTP id 3fmcsyt6np-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 24 Apr 2022 14:13:04 -0400
Received: from USTX2EX-DAG1MB2.msg.corp.akamai.com (172.27.165.120) by usma1ex-dag4mb3.msg.corp.akamai.com (172.27.91.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.22; Sun, 24 Apr 2022 14:13:04 -0400
Received: from USTX2EX-DAG1MB5.msg.corp.akamai.com (172.27.165.123) by ustx2ex-dag1mb2.msg.corp.akamai.com (172.27.165.120) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Sun, 24 Apr 2022 13:13:03 -0500
Received: from USTX2EX-DAG1MB5.msg.corp.akamai.com ([172.27.165.123]) by ustx2ex-dag1mb5.msg.corp.akamai.com ([172.27.165.123]) with mapi id 15.00.1497.033; Sun, 24 Apr 2022 13:13:02 -0500
From: "Lubashev, Igor" <ilubashe@akamai.com>
To: Ike Kunze <Ike.Kunze@comsys.rwth-aachen.de>
CC: "ippm@ietf.org" <ippm@ietf.org>
Thread-Topic: Comments on draft-ietf-ippm-explicit-flow-measurements-00
Thread-Index: AQHYOt+nl5Uwav6ptEKpYcsL7mxprKz/j7kA
Date: Sun, 24 Apr 2022 18:13:02 +0000
Message-ID: <9566cff65b8a445d98fc54f9194df885@ustx2ex-dag1mb5.msg.corp.akamai.com>
References: <121B3179-60F7-410D-B8BC-EFC321E5DE83@comsys.rwth-aachen.de>
In-Reply-To: <121B3179-60F7-410D-B8BC-EFC321E5DE83@comsys.rwth-aachen.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.27.118.139]
Content-Type: multipart/alternative; boundary="_000_9566cff65b8a445d98fc54f9194df885ustx2exdag1mb5msgcorpak_"
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.858 definitions=2022-04-23_01:2022-04-22, 2022-04-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204240091
X-Proofpoint-ORIG-GUID: hmbfdGhsUMLAEFGQIGWA6IJ2IozbXt-v
X-Proofpoint-GUID: hmbfdGhsUMLAEFGQIGWA6IJ2IozbXt-v
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-23_01,2022-04-22_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 malwarescore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204240092
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/H3NLhHYMdb1RIXdGBjHEXrCEa3I>
Subject: Re: [ippm] Comments on draft-ietf-ippm-explicit-flow-measurements-00
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Apr 2022 18:13:17 -0000

Ike,

Thank you very much for reading the draft and your very useful comments. It is especially important to understand where readers may get misled.  We are working on addressing your comments and suggestions for the next version.

As for the organization of the document, especially separating the sections describing individual bits and combinations of bits, we can certainly do better.  But I wonder if it is wise to separate the discussion of measurements facilitated by R bit from the discussion of measurements facilitated by R+Q bits, because R bit requires Q bit for its implementation.  The L bit allows for some useful measurements by itself, but its most valuable measurements are realized in combination with Q bit.

So the only “clean” alternatives I see are:

  1.  Discussing measurements facilitated by L+Q and R+Q bits as sub-sections of L and R bit sections, or
  2.  Leaving only the discussion of the mechanics of bit generation and observation in the bit sections and moving all the measurement discussions to a separate section (with “T bit measurements”, “Q bit measurements” , “L bit measurements”, “L+Q bit measurements”, “R+Q bit measurements” as subsections).

I am worried that alternative B may be more confusing for the reader, since it would keep the details of the algorithms far from the algorithms’ indented purpose.  But I welcome input here.

Many thanks!


  *   Igor


From: Ike Kunze <Ike.Kunze@comsys.rwth-aachen.de>
Sent: Friday, March 18, 2022 11:49 AM
To: ippm@ietf.org
Subject: [ippm] Comments on draft-ietf-ippm-explicit-flow-measurements-00

Hi all,

in my mail supporting adoption of the efm draft, I mentioned that "the descriptions of the approaches could be a bit more precise”.
In the past weeks, I have discussed these aspects with Mauro, Massimo, and Fabio and would like to quickly summarize my main “concerns” here so that (hopefully) everyone can profit.

R-Bit:
To me, the exact behavior when updating the R block length if a new Q block has been completed during the R block transmission is not entirely clear.
While the text on this is technically correct, I believe that it could be beneficial to explicitly describe the behavior, e.g., when the new R block length is shorter than the previous one.

T-Bit:
I believe that the description of the T-Bit could profit from a more detailed presentation of two aspects:

First, I misinterpreted that the generation token counter is reset each time a new generation phase starts.
This then led to several additional false inferences.
Consequently, I think that the description of the concrete behavior of the generation token counter could be more precise.

Second, the concrete choice of “2 spin bit periods” for the T-Bit phases (in connection with the misinterpretation of the generation token counter) again led to
several false inferences on my part.
Thus, I think that some discussion on why this phase length is chosen might be beneficial to avoid such misinformed reasoning.

Additionally, the T-Bit algorithm is currently presented once at a semi-high-level at the start of Section 4.1 and then again in Section 4.1.2.
This made me jump between the sections several times as it is not obvious which part contains which information.
My suggestion would be to either (i) merge the two parts or to (ii) make the description at the start of 4.1 more general so that it is clear that it is only intended as a rough overview and not as potentially containing critical implementation aspects.
That could help so that all information is found in one place and one place only.

General comment:
In addition to these aspects directly concerning two of the mechanisms, I also have a more high-level proposal regarding the structure of the loss bit section.
In Section 4, the combination of L+Q comes as Section 4.4. after the T, Q and L Bits have been presented.
The R-Bit is then presented in Sec 4.5 and the combination of R+Q in subsection of 4.5.1.
I think it would be cleaner if all of the loss bits would be presented first.
The different possible combinations could then be presented in a joint Section 4.5.
In my opinion, this would make it easier to fully grasp the different possible combinations and, especially, allow for a sensible comparison between the possibilities.

Hope this helps!
Cheers,
Ike