Re: [ippm] Section 6 - draft-fz-ippm-alt-mark-deployment-01

Giuseppe Fioccola <giuseppe.fioccola@huawei.com> Mon, 30 October 2023 10:53 UTC

Return-Path: <giuseppe.fioccola@huawei.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D7BAC151065; Mon, 30 Oct 2023 03:53:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.904
X-Spam-Level:
X-Spam-Status: No, score=-1.904 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C04Etz_hIez5; Mon, 30 Oct 2023 03:53:51 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DDF3AC14CF15; Mon, 30 Oct 2023 03:53:50 -0700 (PDT)
Received: from frapeml100008.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SJqm06fXbz6JB1L; Mon, 30 Oct 2023 18:49:52 +0800 (CST)
Received: from frapeml500006.china.huawei.com (7.182.85.219) by frapeml100008.china.huawei.com (7.182.85.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 30 Oct 2023 11:53:47 +0100
Received: from frapeml500006.china.huawei.com ([7.182.85.219]) by frapeml500006.china.huawei.com ([7.182.85.219]) with mapi id 15.01.2507.031; Mon, 30 Oct 2023 11:53:47 +0100
From: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
To: tom petch <ietfa@btconnect.com>, Nilo Massimo <massimo.nilo@telecomitalia.it>, "Thomas.Graf@swisscom.com" <Thomas.Graf@swisscom.com>, "ippm@ietf.org" <ippm@ietf.org>, "draft-fz-ippm-alt-mark-deployment.authors@ietf.org" <draft-fz-ippm-alt-mark-deployment.authors@ietf.org>
Thread-Topic: Section 6 - draft-fz-ippm-alt-mark-deployment-01
Thread-Index: AdnvorM7OAaThpJqSiCXHe8g9y5AaANefEUQAi31OdAAAChi8AC6mKrSAAsLNRYAAJ2JsA==
Date: Mon, 30 Oct 2023 10:53:47 +0000
Message-ID: <b60aeb6b873c4967a409e5d5f1d4844b@huawei.com>
References: <b04df19096e446ab99b51303517f7315@swisscom.com> <VI1PR0701MB680000344B535968CA6CF0DCE5D3A@VI1PR0701MB6800.eurprd07.prod.outlook.com> <081b1c25ec81444a81cf2b7d7549eb99@huawei.com> <4e05edd3c2ca4bbe9d873443543fa883@huawei.com> <DB7PR07MB5546728F57B6C647B2250277A2DCA@DB7PR07MB5546.eurprd07.prod.outlook.com> <DB7PR07MB5546BCED71ABC1FFA7D3439AA2DCA@DB7PR07MB5546.eurprd07.prod.outlook.com>
In-Reply-To: <DB7PR07MB5546BCED71ABC1FFA7D3439AA2DCA@DB7PR07MB5546.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-originating-ip: [10.45.153.194]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/M0LEnnhderYla-aXAX-UzF1Euo4>
Subject: Re: [ippm] Section 6 - draft-fz-ippm-alt-mark-deployment-01
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Oct 2023 10:53:55 -0000

Hi Tom,
Thank you for your feedback. We plan to revise the draft soon to address your comments.
Please find my replies inline tagged as [GF].

Regards,

Giuseppe


-----Original Message-----
From: tom petch <ietfa@btconnect.com> 
Sent: Friday, October 27, 2023 5:43 PM
To: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>; Nilo Massimo <massimo.nilo@telecomitalia.it>; Thomas.Graf@swisscom.com; ippm@ietf.org; draft-fz-ippm-alt-mark-deployment.authors@ietf.org
Subject: Re: Section 6 - draft-fz-ippm-alt-mark-deployment-01

And I get a bounce from
o swkim@etri.re.kr 
Cannot see it among the expansions for this I-D but I expect that it is there somewhere

I had the same in August when commenting on an Erratum

Tom Petch

________________________________________
From: ippm <ippm-bounces@ietf.org> on behalf of tom petch <ietfa@btconnect.com>
Sent: 27 October 2023 11:49
To: Giuseppe Fioccola; Nilo Massimo; Thomas.Graf@swisscom.com; ippm@ietf.org; draft-fz-ippm-alt-mark-deployment.authors@ietf.org
Cc: opsawg@ietf.org
Subject: Re: [ippm] Section 6 - draft-fz-ippm-alt-mark-deployment-01

From: ippm <ippm-bounces@ietf.org> on behalf of Giuseppe Fioccola <giuseppe.fioccola=40huawei.com@dmarc.ietf.org>
Sent: 23 October 2023 18:27

Hi again,
I forgot to mention that, in relation to this document, we also published two new drafts:

  *   IPFIX Alternate-Marking Information (https://datatracker.ietf.org/doc/draft-gfz-opsawg-ipfix-alt-mark/)
  *   YANG Data Model for the Alternate Marking Method (https://datatracker.ietf.org/doc/draft-gfz-ippm-alt-mark-yang/)
These documents complement the AltMark deployment document for what concerns the configuration (YANG) and data export (IPFIX) aspects.

Your reviews are welcomed.

<tp>
YANG is mostly lower case whereas I note that the file name is upper case.

[GF]: Sure, we will revise the use of the term YANG.

Also, I find prefix long - here it is longer than the file name.  Perhaps 'amm:' or altmk:'.  Some models have path statements which are nested ten deep and then the length of the prefix can significantly affect legibility. I think that 3-4-5 characters is good.

[GF]: Ok, thank you for pointing that out. Maybe 'amm' can work.

YANG imports must be Normative References in the I-D; you need to add 8353 8532.   Common practice is to have a section 4.1 saying the YANG module imports from [RFC8532], [RFC8353] and makes reference to ...

[GF]: Good suggestion. We will review it and include a new section.

I suggest mentioning RFC9341 RFC9342 in the Abstract (but not as an XML link).

[GF]: Yes, it makes sense.

Note that users can augment this module
Well yes, how can you stop them?  I suggest adding something about what augmentations are likely and where they are likely to be.  Sometimes authors add empty containers as anchors for potential augmentations.

[GF]: Good suggestions. We will consider this point and provide guidance for possible future augmentations.

the reference in the revision clause is not quite the same as the document title

[GF]: Ok, we will revise.

support for a function is often indicated by a presence container as opposed to feature; this is widespread in routing modules.

[GF]: Ok, we will fix it.

what are the units of period?

[GF]: Ok, we will define it.

not sure if opsawg are interested in this

[GF]: Right. Since this discussion is related only to the draft in IPPM (draft-gfz-ippm-alt-mark-yang), I'm removing OPSAWG from the list of recipients.

Tom Petch

Regards,

Giuseppe
(on behalf of the coauthors)


From: Giuseppe Fioccola
Sent: Monday, October 23, 2023 7:19 PM
To: 'Nilo Massimo' <massimo.nilo@telecomitalia.it>; Thomas.Graf@swisscom.com; ippm@ietf.org; draft-fz-ippm-alt-mark-deployment.authors@ietf.org
Cc: opsawg@ietf.org
Subject: RE: Section 6 - draft-fz-ippm-alt-mark-deployment-01

Dear All,
Please note that we just submitted a new version of draft-fz-ippm-alt-mark-deployment to address the comments received.

Inputs and suggestions are always welcome.

Regards,

Giuseppe
(on behalf of the coauthors)


From: Nilo Massimo <massimo.nilo@telecomitalia.it<mailto:massimo.nilo@telecomitalia.it>>
Sent: Thursday, October 12, 2023 5:22 PM
To: Thomas.Graf@swisscom.com<mailto:Thomas.Graf@swisscom.com>; ippm@ietf.org<mailto:ippm@ietf.org>; draft-fz-ippm-alt-mark-deployment.authors@ietf.org<mailto:draft-fz-ippm-alt-mark-deployment.authors@ietf.org>
Cc: opsawg@ietf.org<mailto:opsawg@ietf.org>
Subject: RE: Section 6 - draft-fz-ippm-alt-mark-deployment-01

Hi Thomas,
thank you for your feedback.
I have a couple of comments.
In section 6.1 for IPFIX, in order to calculate loss you said to use for packets the entity octetDeltaCount(IE1). But might it be better to use the entity packetDeltaCount(IE2)?

Moreover I suggest for the delay to add the use of existing entities flowEndSeconds, flowEndMilliseconds, flowEndMicroseconds, flowEndNanoseconds.

Best Regards,

Massimo




Gruppo TIM - Uso Interno - Tutti i diritti riservati.
From: ippm <ippm-bounces@ietf.org<mailto:ippm-bounces@ietf.org>> On Behalf Of Thomas.Graf@swisscom.com<mailto:Thomas.Graf@swisscom.com>
Sent: lunedì 25 settembre 2023 13:23
To: ippm@ietf.org<mailto:ippm@ietf.org>; giuseppe.fioccola@huawei.com<mailto:giuseppe.fioccola@huawei.com>; draft-fz-ippm-alt-mark-deployment.authors@ietf.org<mailto:draft-fz-ippm-alt-mark-deployment.authors@ietf.org>
Cc: opsawg@ietf.org<mailto:opsawg@ietf.org>
Subject: [EXT] [ippm] Section 6 - draft-fz-ippm-alt-mark-deployment-01

Dear draft-fz-ippm-alt-mark-deployment authors, Dear IPPM working group,

First of all I think draft-fz-ippm-alt-mark-deployment is a valuable document describing the deployment of Alternat Marking.

I have reviewed https://datatracker.ietf.org/doc/draft-fz-ippm-alt-mark-deployment/ the Network Telemetry aspect described in Section 6 and wrote a proposal for -01 as following:

https://raw.githubusercontent.com/network-analytics/draft-fz-ippm-alt-mark-deployment/main/draft-fz-ippm-alt-mark-deployment-01.txt
https://raw.githubusercontent.com/network-analytics/draft-fz-ippm-alt-mark-deployment/main/draft-fz-ippm-alt-mark-deployment-01.xml

The new section describes how the export could be performed with existing IPFIX entities where decomposition is performed at the data collection and what needs to be consider for new IPFIX entities. I also described the publication with YANG push and what needs to be considered in terms of subscription, data publication and modeling.

Here the current diff: https://author-tools.ietf.org/diff?url_1=https://www.ietf.org/archive/id/draft-fz-ippm-alt-mark-deployment-00.txt&url_2=https://raw.githubusercontent.com/network-analytics/draft-fz-ippm-alt-mark-deployment/main/draft-fz-ippm-alt-mark-deployment-01.txt

I hope this makes sense and is helpful for the community. Feedback and comments welcome.

Best wishes
Thomas



________________________________

Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.

This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks.

Rispetta l'ambiente. Non stampare questa mail se non è necessario.


_______________________________________________
ippm mailing list
ippm@ietf.org
https://www.ietf.org/mailman/listinfo/ippm