[ippm] draft-ippm-ioam-data-09 WGLC comments

Martin Duke <martin.h.duke@gmail.com> Tue, 26 May 2020 23:23 UTC

Return-Path: <martin.h.duke@gmail.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 16CD63A0BB5; Tue, 26 May 2020 16:23:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Io00TSl6D3Ae; Tue, 26 May 2020 16:23:56 -0700 (PDT)
Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F32B33A0BB3; Tue, 26 May 2020 16:23:52 -0700 (PDT)
Received: by mail-il1-x12e.google.com with SMTP id y17so20041127ilg.0; Tue, 26 May 2020 16:23:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=GUrqNujiv26Jx4WuSKyG0ZjQsUjEEoJT1d8DcsK/fyU=; b=Ex9NoIblAH+EzFkQGBmKXtpZMScM5pM+Nsldx7ykxhJ68CRTSn9mG4Vxqj6jOBb+Fk YW08hXZ6v/CQpOLTyY+6JEb5M9M0/9yArqzQaPFwEU4UBabovB1FoXQ8dwD1TJTydv6v NYoilXbWLHKUDX0oaw5N564LmumxEJ0OoJZN0sD23vAgYGqyvGrNoQ3v6l/3Kq5tg5gy P3dOavjnJmPIxkNvF6ZTbvA12tLlX0ipsO3/UdlTyWud8Tnj5VAfuXxmXwmXoGgLRY6/ L7bxrDZzFbI+m1BUKxKe2ASPXiW4kccxzWSxrN5HNXNuWFAbBoy2HX2n494ysFjtvdHo hPzw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=GUrqNujiv26Jx4WuSKyG0ZjQsUjEEoJT1d8DcsK/fyU=; b=lh7zCeuXl4bUw2ZadxwR8hxjK2KnDabYXweQP1vR/zsS9PxTspG5tFVVNG4F9nttK3 /9jydM33wRjQoXXiQiFIe7L4qynx/vRVK12c74exYz4doKmFaur4a/o2N3YcqlKlwiD+ hoVBGogOY6g0Y8iL2XkH7tqSmNXLxDk+8nC2hw2rWxUt0WWk1QvtHZhyYRoK1bOECHrn MECgt86yVpcUxzqDPwSM8QaYzIH1qFYlC7mT4Ksdj7ErhefXAV9rIDbVm1j7qZD36ZgS oXisDOvkt0+46AYavkrJWjrSmOaGRIqQiKUEhYt+c2EBDFb7NE1otSikBebF6hUFLGUz hC5g==
X-Gm-Message-State: AOAM532jRJG12dON/c/9Nrnf3jjID29/jZyKqf5Zlokousq48Fj0eEX8 3NXYjqJmzTMYNm5+LVgVLV3piQci78P+Rt0aUQWjV9NR
X-Google-Smtp-Source: ABdhPJzfZD3gRF+30D0ij4LvxPHrOnedDp763LiiyKqPnUjB8bg4iCF/Hcn4bFElkMFl/pYB7KjrL68Sblw1fvHYyi4=
X-Received: by 2002:a92:8d4d:: with SMTP id s74mr3477020ild.287.1590535430891; Tue, 26 May 2020 16:23:50 -0700 (PDT)
MIME-Version: 1.0
From: Martin Duke <martin.h.duke@gmail.com>
Date: Tue, 26 May 2020 16:23:39 -0700
Message-ID: <CAM4esxT2DdaeQO5DVQJftdcjAG3ZX6S3PYJXu1+5Bt3v=Ctsng@mail.gmail.com>
To: draft-ietf-ippm-ioam-data.all@ietf.org, ippm@ietf.org
Content-Type: multipart/alternative; boundary="0000000000005c725705a69563d4"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/MGocV7XC9RYXUJrE9uj3b3Ouqvo>
Subject: [ippm] draft-ippm-ioam-data-09 WGLC comments
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2020 23:23:58 -0000

This document is almost ready. I have a few review comments and a trail of
nits.

Comments:
1. It's RFC Ed policy to have no more than 5 authors, and you have 12.
Please follow these guidelines
<https://www.rfc-editor.org/policy.html#policy.authlist> to trim the list
down.
2. Throughout the document, there are many lower-case 'must', 'should', or
'may.' These should be reviewed, and most of them changed to upper-case.
Non-upper-case should generally use synonyms like 'might' or 'could'.
3. Section 4.2 says that transit nodes "will update at most one of these
Option Types". I think you mean "at least one of each of these option
types", at least if I'm reading 4.4 correctly.
4. Section 4.4.1 has many normative requirements for the options. What
should transit nodes do if these are not followed (e.g. remainingLen is a
garbage number)? Perhaps there should be an "error flag" in addition to the
Overflow flag?
5. does the pre-allocated option have any sort of initial value the
encapsulation node should set all the trace option data to? Would this
allow the transit nodes to detect if there was a mistake in RemainingLen?

Nits:
Sec 3.
s/using for example packet/using, for example, packet
s/but do not have to share/but do not have to, share
s/data-plane/data planes

Sec 4.3 s/at average/on average

Sec 4.4
s/hardware and software implementations IOAM/hardware and software
implementations, IOAM
s/data.The/data. The
s/devices which either/devices with either

Sec 4.4.1
suggest the sentence
'This bit is set by the network element if there are not enough octets left
to
         record node data, no field is added and the overflow "O-bit"
         must be set to "1" in the IOAM-Trace-Option header.'
be rewritten as
'If there are not enought octets left to record node data, the network
element MUST NOT add a field and MUST set the overflow "O-bit" to "0" in
the IOAM-Trace-Option header.'

s/When set indicates/When set, indicates [multiple times in this section]

Sec 4.4.2
This section could use some subheaders for each node data field

s/hence recommend/and hence RECOMMEND
s/standard unit/standard units

Sec 4.5
Please add a reference for SSSS

Sec 5.3
s/run Linux/run the Linux

Sec 7.8
RFC 8126 says you are supposed to provide guidelines for the expert
reviewer.

-- Martin