Re: [ippm] Working Group Last Call on draft-ietf-ippm-stamp-05

David Ball <daviball@cisco.com> Tue, 23 April 2019 21:59 UTC

Return-Path: <daviball@cisco.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF764120615 for <ippm@ietfa.amsl.com>; Tue, 23 Apr 2019 14:59:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S355wVv1Y3_W for <ippm@ietfa.amsl.com>; Tue, 23 Apr 2019 14:59:57 -0700 (PDT)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 250A4120608 for <ippm@ietf.org>; Tue, 23 Apr 2019 14:59:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=10415; q=dns/txt; s=iport; t=1556056797; x=1557266397; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=rguU3DfsYJZlwsGRcnXIgBXm5UsotfmfZiqPyA3NuIg=; b=g2BeLoVgs8Z4Tw6Y283+EEVg3Yl2RsBoXzjmUssfUqJXP47BD97kzgBB fpLsfCSeUt+Zm9gTQVzMgxPbcYeVm9uv9bTuflBj+N7WRCpvv3znhPCH2 Ln8aYTwNIAXDWQwpgCxOjLgj4jZ2LubD24PWke2mtwrvHIftT7yBX+RXS E=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ADAABmib9c/xbLJq1mGQEBAQEBAQEBAQEBAQcBAQEBAQGBUQQBAQEBAQsBgnhRATIohA6IHF+MPZJRhXqBexAYAQyESAKGSjQJDgEDAQEEAQECAQJtHAyFSwEBAQMBASFLCxALGCcDAgInHxEGAQwGAgEBgx4BgggPqQ2BLx+FKIRiBoEyAYZHhRmBQD+BESeCaz6CYQEBAgGBSIMgglcEmVqMGGQJggqGD4wVBhuCC4Ypg0GJH4wEgR6FH4Yyh3SBTzgogS4zGggbFTuCbIsShUA+AzABkHEBAQ
X-IronPort-AV: E=Sophos; i="5.60,387,1549929600"; d="scan'208,217"; a="11570767"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 23 Apr 2019 21:59:53 +0000
Received: from [10.61.167.55] ([10.61.167.55]) by aer-core-1.cisco.com (8.15.2/8.15.2) with ESMTP id x3NLxqKj002019; Tue, 23 Apr 2019 21:59:52 GMT
To: Greg Mirsky <gregimirsky@gmail.com>, Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Cc: IETF IPPM WG <ippm@ietf.org>
References: <3600b860-32f8-0636-7093-eaddd2fb380d@cisco.com> <CA+RyBmWBWisBSM2AGe+GWxNKCFGyopqjGeL5QE4LaKUfjD6c8Q@mail.gmail.com>
From: David Ball <daviball@cisco.com>
Message-ID: <2a9df237-d43f-fc31-ff2f-455aa66016cf@cisco.com>
Date: Tue, 23 Apr 2019 22:59:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CA+RyBmWBWisBSM2AGe+GWxNKCFGyopqjGeL5QE4LaKUfjD6c8Q@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------8FDF7C8F74C13DFDE78B1707"
Content-Language: en-US
X-Outbound-SMTP-Client: 10.61.167.55, [10.61.167.55]
X-Outbound-Node: aer-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/YdLwN32qDknAYJkh07RWDYZoGkQ>
Subject: Re: [ippm] Working Group Last Call on draft-ietf-ippm-stamp-05
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2019 22:00:00 -0000

Looks good, thanks Greg.


     David


On 23/04/2019 21:41, Greg Mirsky wrote:
> Hi David,
> apologies for the delayed update. I've prepared the new version of the 
> draft to address your comments and comments by the draft Shepherd Tal 
> Mizrahi. Please find the diff, the updated new version attached. Also, 
> I've added a couple explaining notes in-line below under the GIM>> tag.
> Much appreciate your feedback.
>
> Regards,
> Greg
>
>
> On Tue, Mar 5, 2019 at 8:26 AM David Ball <daviball@cisco.com 
> <mailto:daviball@cisco.com>> wrote:
>
>     Hi,
>
>     I have reviewed the document and am fine with it progressing.
>
>     A few nits:
>
>       * The text at the start of Sn 4.1.1 should be before the 4.1.1
>         heading (after the 4.1 heading).
>
> GIM>> Accepted and done.
>
>       * Sn 4.1.1 - the bullet about Server Octets has a spurious extra
>         part-sentence: "The Reflect Octets capability defined in
>         [RFC6038]." - this should be deleted.
>
> GIM>> The comment from Shepherd suggested re-wording the sentence. 
> Please let me know if the following change is acceptable:
> OLD TEXT:
> The Reflect Octets capability defined in [RFC6038].
> NEW TEXT:
> This field is used for the Reflect Octets capability defined in 
> [RFC6038].
>
>      *
>
>
>       * Fig 4 shows a min length of 112 (if I counted right); but text
>         at the start of 4.1.1 says the min length in authenticated
>         mode is 48.
>
> GIM>> Great catch, thank you! It must be 112 - corrected the text.
>
>       * The wording/grammar in the paragraph after bullets in Sn 4.4
>         is a little awkward - suggested edits below:
>
>        "In the former case,the  Session-Sender MAY not be aware that its Session-
>         Reflector does not support STAMP.  For example,a  TWAMP Light Session-
>         Reflector may not support the use of UDP port 862 as defined in
>         [I-D.ietf-ippm-port-twamp-test  <https://tools.ietf.org/html/draft-ietf-ippm-stamp-05#ref-I-D.ietf-ippm-port-twamp-test>].  Thus, the  STAMP Session-Sender MUST be
>         able to send test packets to destination UDP port numbers  taken  from the
>         Dynamic and/or Private Ports range 49152-65535. The  test management
>         system should finda  port number that both devices can use.If any
>         ofthe  TLV-based STAMP extensions are used, the TWAMP Light Session-
>         Reflector will view them as Packet Padding field.  The Session-Sender
>         SHOULD use the default format for its timestamps(NTP) but  it MAY
>         use PTPv2 timestamp format."
>
> GIM>> Many thanks. Accepted.
>
>         David
>
>
>     -- 
>     David Ball
>     <daviball@cisco.com>  <mailto:daviball@cisco.com>
>
>     _______________________________________________
>     ippm mailing list
>     ippm@ietf.org <mailto:ippm@ietf.org>
>     https://www.ietf.org/mailman/listinfo/ippm
>
-- 
David Ball
<daviball@cisco.com>