Re: [ippm] 1st AD review of rfc8889bis

Giuseppe Fioccola <giuseppe.fioccola@huawei.com> Mon, 06 December 2021 10:06 UTC

Return-Path: <giuseppe.fioccola@huawei.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8298E3A09AE; Mon, 6 Dec 2021 02:06:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H2p4MiI-iGdR; Mon, 6 Dec 2021 02:06:31 -0800 (PST)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 436B33A09C0; Mon, 6 Dec 2021 02:06:31 -0800 (PST)
Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4J6zYr5vzgz67LSP; Mon, 6 Dec 2021 18:04:48 +0800 (CST)
Received: from fraeml714-chm.china.huawei.com (10.206.15.33) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 11:06:29 +0100
Received: from fraeml714-chm.china.huawei.com ([10.206.15.33]) by fraeml714-chm.china.huawei.com ([10.206.15.33]) with mapi id 15.01.2308.020; Mon, 6 Dec 2021 11:06:29 +0100
From: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
To: Martin Duke <martin.h.duke@gmail.com>
CC: "draft-fioccola-rfc8889bis.all@ietf.org" <draft-fioccola-rfc8889bis.all@ietf.org>, IETF IPPM WG <ippm@ietf.org>
Thread-Topic: 1st AD review of rfc8889bis
Thread-Index: AQHX5wkHYv0aySGXIUe9C9+wJquXw6we/jEggACG/4CAAUn5cIAAKySAgARHkqA=
Date: Mon, 06 Dec 2021 10:06:28 +0000
Message-ID: <08c64473796c462aa40b5e41d88d4f7c@huawei.com>
References: <CAM4esxSq3bY+LATXWhgM5Xth+PwUJYPv0cxWFZk6LDPDcJUAHA@mail.gmail.com> <6ef48bea72684e4984e496c906a7723e@huawei.com> <CAM4esxRmLhpOT+M47i7yDw+bA6sOvbA50eaKQzkHcQOHHiQyZA@mail.gmail.com> <96d4b56ae87c4c59ae9332d124f50da7@huawei.com> <CAM4esxQB3m0M=Ftn_SgyKjJMV6wZBKGzX3Aq-00GZn318CxX2w@mail.gmail.com>
In-Reply-To: <CAM4esxQB3m0M=Ftn_SgyKjJMV6wZBKGzX3Aq-00GZn318CxX2w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.48.216.135]
Content-Type: multipart/alternative; boundary="_000_08c64473796c462aa40b5e41d88d4f7chuaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/idbmvkEVoKJFagLyFs0twDFASbU>
Subject: Re: [ippm] 1st AD review of rfc8889bis
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Dec 2021 10:06:35 -0000

Hi Martin,
Sure, I will update this draft as well in the coming weeks.

Regards,

Giuseppe

From: Martin Duke <martin.h.duke@gmail.com>
Sent: Friday, December 3, 2021 6:38 PM
To: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
Cc: draft-fioccola-rfc8889bis.all@ietf.org; IETF IPPM WG <ippm@ietf.org>
Subject: Re: 1st AD review of rfc8889bis



On Fri, Dec 3, 2021 at 6:59 AM Giuseppe Fioccola <giuseppe.fioccola@huawei.com<mailto:giuseppe.fioccola@huawei.com>> wrote:
Hi Martin,
My answers inline as [GF].


I agree that there are many possibilities, but a standard should either provide guidance or (at least) work through the implications of each. It should be more prescriptive; marking nodes and measurement nodes need to have common expectations about the marking rules, although they can deterministically depend on whether or not one can mark fragments (which is obviously deployment-dependent).

I'm happy to be corrected by an expert, but after thinking about it for a few minutes I would propose the following:
(i) marking nodes MUST mark all fragments if there is a codepoint to use (i.e. it is in the IP header or encapsulation), as if they were separate packets.
(ii) routers that fragment packets in a network under test MUST NOT replicate marks (thus signalling that it was fragmented internally), but SHOULD mark the first fragment if they have the capability to do so.
(iii) Measurement points MAY simply ignore unmarked fragments and count marked fragments as full packets. However, if resources allow, Measurement Points SHOULD make note of marked initial fragments and only increment its counter if (a) other fragments are also marked, or (b) it observes all other fragments and they are unmarked.

[GF]: I fully agree with your proposals. The marking node MUST mark all the fragments except in the case of fragmentation within the network domain; in this case it is suggested to mark only the first packet. The condition about the counters also makes sense so it could be possible to keep track of both marked and unmarked fragments. I can include these considerations in the next version.

Alright, please think it through and write up some text if you think it checks out.

- I don't understand the L determination when there are multiple marking nodes (Sec 7). "The source measurement intervals can be of different lengths and with different offsets" Some questions:
(a) What is a "source measurement interval"? Does it have anything to do with L?
(b) So let's say that source nodes start marking at arbitrary times. Isn't the "offset" then directly a function of L? And if so, how can we scale L based on the offset m?
(c) if the idea is that there is a clock time when marking should begin, then why isn't the value of A [clock skew] embedded in d sufficient?

[GF]: For a multipoint-to-multipoint flow, you may have multiple marking nodes, so there is an additional contribution to take into account. Indeed, the marking nodes may apply the markings at different moments and this time offset does not depend from the clock error or from the network delay but it is an intrinsic delay of the router.
Regarding your questions:
a) it is the marking period. I will replace it to be aligned with the terminology of the rest of the document.
b) yes, there is the formula: L - 2m - 2d > 0
c) m is not given by clock skew, indeed A is already included in d.

I wasn't clear enough about (b). Let's say node A has period L1, and node B is trying to set its L but is going to start at an arbitrary time. What is m for node B? It is a uniform distribution over [0, L1]. so L2 has to be >> L1. But the same is true of A! The only way to disambiguate the blocks is for each L to be much bigger than all the other Ls, which is of course impossible.

The only way I can see for this to work is for the marking nodes to agree a clock time to switch blocks, with fixed L, and then you're only constrained by the clock skew and delay as in 8321.

To me this is the central problem 8889 is trying to solve, and it's under-baked. Maybe there's a constraint I'm not seeing?

[GF]: Yes, the only way is that the marking nodes switch blocks with fixed L based on a clock time. In theory the formula in RFC8321 applies also in case of multipoint network. But we wanted to generalize that formula and let me explain the rationale. Since we have more marking nodes in a multipoint environment, there can be an additional mismatch to consider since different nodes are marking the traffic and the batches get mixed in a multipoint flow. For example, a marking node may apply the marking with a delay because it is overloaded while the other marking nodes are not. To take into account this possible additional gap between the sources we introduced “m” even if m can be negligible in most of the cases. Also note that the formula (L - 2m - 2d > 0) is exactly the same of RFC8321 if m=0, indeed in case of a point-to-point flow we only have one marking node and m=0. Maybe more explanation in the draft could help here.


Agreed, let's more precisely define what m is, and clarify that marking nodes are switching colors based on synchronized clock time.