Re: [ippm] AD review of draft-ietf-ippm-stamp

Shahram Davari <shahram.davari@broadcom.com> Mon, 08 July 2019 21:02 UTC

Return-Path: <shahram.davari@broadcom.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3F18120073 for <ippm@ietfa.amsl.com>; Mon, 8 Jul 2019 14:02:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.704
X-Spam-Level:
X-Spam-Status: No, score=-0.704 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, PDS_NO_HELO_DNS=1.295, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=broadcom.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AcD2LG5VbGpK for <ippm@ietfa.amsl.com>; Mon, 8 Jul 2019 14:02:09 -0700 (PDT)
Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE6E812008C for <ippm@ietf.org>; Mon, 8 Jul 2019 14:02:08 -0700 (PDT)
Received: by mail-pg1-x534.google.com with SMTP id i8so8263054pgm.13 for <ippm@ietf.org>; Mon, 08 Jul 2019 14:02:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=5H48EY7Yz2mygBt6RvO8UEd3yBfKkcWw8r3ejX6Shg4=; b=V7HzKwWciP/Cj+FKNzAPO8J6h1l7SUpN1C0t2oMdMm72V5UGo3xgTEUQLoRc+oiJT4 xlGPtqHvN1mZt1t6Zmw1Ym1U7Mi6QBtJxq/HwtgKS/zQ7sKX1OsHbjqWj5n8SNmON9QG ONkMexRkTuf5oNULj+SqvFwTU03LudMwqdO/I=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=5H48EY7Yz2mygBt6RvO8UEd3yBfKkcWw8r3ejX6Shg4=; b=gM8hfPhARB71UvkQ+EmYNPLtQ1aqhXQv6dVRUEEUTBkHhN9AiecV1mOYzDVp5KGSyJ +e/T88IpJ6+qOkZIVPz8lMFpr9iSkhl6Dyt7LNJkoAagm2F5UTioMwAZ2AEXnMLXgR8h G/alpX5Te9+xP4h8ZWIrIhUUGjq59Dl53tylsQ4l6lYf9ovgG7dDl//Yg7r3HMn/ZdUk dOR+sVsofZFRsRdLBA3v3mlR8MtQiZs73lATCE7wwKRvOYhb/w0S5T/tPvOkdI3Ymkzn Nii4R9k7INZXMvKRWH72jTDVxVAKNaqOWB2wBv85BCQNEZvZSYhi0q9Of6zjUiTTnkq8 yypw==
X-Gm-Message-State: APjAAAVXpL3N7B6QMx0UMO0fRuU5BmqEuqhBe5/UIA1gjLIPpPZ2QwkM 6fpPDRh7FlR/tiA45cuef/vghw==
X-Google-Smtp-Source: APXvYqzqowjqw5mMaGsfEKt8SY1S0Wa9usZ606SFrQhtX/VMUy1DaJLM6XouosDq6Uz7cPmNsD3+uQ==
X-Received: by 2002:a17:90a:1b4c:: with SMTP id q70mr27509094pjq.69.1562619728178; Mon, 08 Jul 2019 14:02:08 -0700 (PDT)
Received: from c02rq0djfvh9.wifi.broadcom.net ([192.19.222.250]) by smtp.gmail.com with ESMTPSA id t8sm23181982pfq.31.2019.07.08.14.02.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2019 14:02:07 -0700 (PDT)
From: Shahram Davari <shahram.davari@broadcom.com>
Message-Id: <F167C330-76F4-48FC-B720-415CA190239C@broadcom.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_29049B5E-A088-4364-AC6D-97D25D6FBE96"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Mon, 08 Jul 2019 14:02:02 -0700
In-Reply-To: <CA+RyBmXPCe7TZQqPgsKsVnifZDG8O8wGafDn-nzYfGpx2OiaXQ@mail.gmail.com>
Cc: Mirja Kuehlewind <ietf@kuehlewind.net>, IPPM Chairs <ippm-chairs@ietf.org>, IETF IPPM WG <ippm@ietf.org>, draft-ietf-ippm-stamp@ietf.org
To: Greg Mirsky <gregimirsky@gmail.com>
References: <B617B303-6EBE-4E3B-AE5C-1438FF1C5D7F@kuehlewind.net> <CA+RyBmVEmKQu=LGp9eVT+x5e01LCSk_A4tQD=RE8Ett-R35BVg@mail.gmail.com> <11938018-8A65-483B-8176-A6E1C2A265A3@kuehlewind.net> <CA+RyBmX=Jx2yXrMXu4Y2VKX36iKphymb1Hkyfy0XhPGFmsUGzQ@mail.gmail.com> <B8047CA0-2F5E-48F8-9BE4-3FA41D742F12@kuehlewind.net> <CA+RyBmXPCe7TZQqPgsKsVnifZDG8O8wGafDn-nzYfGpx2OiaXQ@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/lYbwdT7Zzo-wQMK6ZHSfgh9H9gc>
Subject: Re: [ippm] AD review of draft-ietf-ippm-stamp
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jul 2019 21:02:12 -0000

HI Greg

I read your draft and have the following questions:

1) Does it require any UDP/TCP port number or it reuses the one from TWAMP? if it reuses from TWAMP then  how does the receiver differentiate between TWAMP and STAMP?
2) What is the benefit of STAMO compared to TWAMP?
3) Why is there so much MBZ byte?

Thx
Shahram

> On Jul 8, 2019, at 10:17 AM, Greg Mirsky <gregimirsky@gmail.com> wrote:
> 
> Hi Mirja,
> thank you for the suggested text. The new paragraph now reads as:
>       Load of STAMP test packets offered to a network MUST be carefully
>       estimated, and the possible impact on the existing services MUST
>       be thoroughly analyzed before launching the test session.
>       [RFC8085] section 3.1.5 provides guidance on handling network load
>       for UDP-based protocol.  While the characteristic of test traffic
>       depends on the test objective, it is highly recommended to stay in
>       the limits as provided in [RFC8085].
> 
> If it is acceptable, I'd like to upload the updated version of draft-ieff-ippm-stamp before the cut-off deadline.
> 
> Regards,
> Greg
> 
> On Mon, Jul 8, 2019 at 8:58 AM Mirja Kuehlewind <ietf@kuehlewind.net <mailto:ietf@kuehlewind.net>> wrote:
> Hi Greg,
> 
> See below.
> 
> > On 8. Jul 2019, at 16:54, Greg Mirsky <gregimirsky@gmail.com <mailto:gregimirsky@gmail.com>> wrote:
> > 
> > Hi Mirja,
> > thank you for the reference to RFC 8085. I agree that the document is very much relevant and a reference to RFC 8085 in STAMP is useful. While reading Section 3.1.3 I came to think that the discussion and guidance in other sections of RFC 8085, particularly, Section 3.1.5 Implications of RTT and Loss Measurements on Congestion Control. Would adding the reference to that section in the new text proposed for the Security Considerations section work? I'll put RFC 8085 as Informational reference as it is BCP.
> > NEW TEXT:
> >       Load of STAMP test packets offered to a network MUST be carefully
> >       estimated, and the possible impact on the existing services MUST
> >       be thoroughly analyzed using [RFC8085] and its Section 3.1.5 in
> >       particular before launching the test session..
> 
> 
> Not sure if “using” is the right word but otherwise fine for me. Or you could have a separate sentence like:
> 
> “RFC8085 section 3.1.5 provides guidance on handling network load for UDP-based protocol. While the characteristic of test traffic depends on the test objective, it is highly recommended to say in the limits as provided in RFC8085.”
> 
> Or something similar…
> 
> BCP is the same maturity level as PS. So it wouldn’t be a downref. However, I think having this as informational ref is fine.
> 
> Mirja
> 
> 
> 
> > 
> > Regards,
> > Greg
> > 
> > On Mon, Jul 8, 2019 at 2:37 AM Mirja Kuehlewind <ietf@kuehlewind.net <mailto:ietf@kuehlewind.net>> wrote:
> > Hi Greg,
> > 
> > Thanks a lot for you reply. Changes are good. I wonder if it would be useful to provide a reference to RFC8085 because it has a lot of information about congestion control of UDP based traffic? It recommends to send not more than 1 packet per 3 seconds (if RTT is unknown). I guess it doesn’t make sense to require this for testing traffic, however, it could maybe still be a good recommendation? What do you think?
> > 
> > Also I’ve just resend my review to the IPPM list, as I unfortunately cc’ed only the IPPM chairs instead of the whole list. Can you resend you proposed changes to the list, so other people are aware of these changes. Sorry for the unconvience.
> > 
> > Mirja
> > 
> > 
> > > On 6. Jul 2019, at 17:46, Greg Mirsky <gregimirsky@gmail.com <mailto:gregimirsky@gmail.com>> wrote:
> > > 
> > > Hi Mirja,
> > > thank you for your thorough review, very pointed and helpful comments. Please find my responses in-lined and tagged GIM>>. Attached the diff.
> > > 
> > > Regards,
> > > Greg
> > > 
> > > On Thu, Jul 4, 2019 at 9:10 AM Mirja Kuehlewind <ietf@kuehlewind.net <mailto:ietf@kuehlewind.net>> wrote:
> > > Hi authors, hi all,
> > > 
> > > Thanks for this well-written document and very good shepherd write-up! I would like discuss one point before I start IETF last call.
> > > 
> > > I believe this document should say something about network load and congestion (control). OWAMP and TWAMP discuss quite a bit sender scheduling, however, as this is a simplified version, so I think it could at least be good to put a waring in this document that packet sending should be somehow rate limited. I know it might be hard to provide more concrete guidance but at least having some discussion or warning in this document could be good.
> > > GIM>>  Thank you for your suggestion. Security Considerations section points to the fact that STAMP does not include control and management components:
> > >    Because of the control
> > >    and management of a STAMP test being outside the scope of this
> > >    specification only the more general requirement is set:
> > > adding the new text here:
> > >       Load of STAMP test packets offered to a network MUST be carefully
> > >       estimated, and the possible impact on the existing services MUST
> > >       be thoroughly analyzed before launching the test session.
> > > 
> > > 
> > > Another comment: You only say at the very end that a certain UDP port is used, which implies that STAMP runs over UDP. However, I think you should mention at the very beginning that this is a UDP-based protocol. Just to make things crystal clear.
> > > GIM>> Adding the reference to "UDP transport" into the first sentence of Theory of  Operations section:
> > >    STAMP Session-Sender transmits test packets over UDP transport toward STAMP Session-Reflector.
> > > 
> > > Mirja
> > > 
> > > P.S.:
> > > Nit: s/This document defines active performance measurement test protocol/ This document defines an active performance measurement test protocol/
> > > -> “an” missing
> > > GIM>> Thank you. Done. 
> > > <Diff_ draft-ietf-ippm-stamp-06.txt - draft-ietf-ippm-stamp-07..txt.html>
> > 
> 
> _______________________________________________
> ippm mailing list
> ippm@ietf.org
> https://www.ietf.org/mailman/listinfo/ippm