[ippm] Re: draft-ietf-ippm-asymmetrical-pkts-07 early Tsvart review

Greg Mirsky <gregimirsky@gmail.com> Wed, 04 June 2025 00:36 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: ippm@mail2.ietf.org
Delivered-To: ippm@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id F1A3A3078801; Tue, 3 Jun 2025 17:36:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -2.088
X-Spam-Level:
X-Spam-Status: No, score=-2.088 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01] autolearn=ham autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i_UpBbfpI0lf; Tue, 3 Jun 2025 17:36:10 -0700 (PDT)
Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id A63AF30787F7; Tue, 3 Jun 2025 17:36:07 -0700 (PDT)
Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-3114560d74aso6394074a91.0; Tue, 03 Jun 2025 17:36:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748997367; x=1749602167; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fFa8etnvpMsR9ZG9bFBth9xZNnI//FNt6vIVKZzqekg=; b=dlLXAnm54nwHiRaRwDkMZNH5QHGHbePe0DlPuQ2IP9AP8RG0xXCocDZJr7xvdeV1gJ G8S4tHAwSmbnxHWiFqsMyA1DX+BaHzEKld/eAeNpTP6k12nK74LFqHZGhAAhA+SvcB19 2FJR79S9J+VdqNUfrvdvaMnA3m5lxv6sIPo3vZidO/c+BKJPuuHcB4BJ3q9i5XLiR+76 dpAFKwldG4w/Lzc58E49kW/ctZb0RA8KpVXeaWBZEOuRxmrObPLi8G9R2tLJVW3JLbYs ChpXs1C07pH67AhSfqdm+3LcninbKZTSkwnfMn+9jY+A7pjW9noKiT+kklvCTiRYWVKd wxbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748997367; x=1749602167; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fFa8etnvpMsR9ZG9bFBth9xZNnI//FNt6vIVKZzqekg=; b=SZl03y3fKPOc3G8krUPnLF+bxA/DrV1+VgdKilaiWhThqkcm4UO6WwOlhvdcRji/Dy 9nnJRwXfjNaOHDckczinIbyIZXUqR+VfcR9YKPgzGNBzWTDGXLVLm++Lb6nkel81hB6W Y5xWUfZpPtSd4mxbHJHBpOG7mR3Y1WRBHcaGNawLLDhP9+O7BHU1Azm+P9Ci917QQAYQ /lTzrbwSTqTuL5CPHcIhn5KXwc332ohFWa/ZKMGXTP59HWaSKG88lVD/xDwzMwzQ/PAn N5sU8uoXxtPVjaqkpfKnyNUOJ92rz4hDMNpGpVeGobf6dPrUsN2Y9un6jJcDUq4VyzFP 6fAg==
X-Forwarded-Encrypted: i=1; AJvYcCWu/ZXEHtKtOjotcRrvmFAUe0YfVW8BJ6jGiQULPQdVf8AncxFLPiwK1WWyUNLqfM2j6bx5fw==@ietf.org, AJvYcCXaKOeep7Yilc/NdPOUIpCCVJg2zqOEsFj5Z4oXVg8Fw9RHVEqnDDQWPSHdsfl9NNUkRrabdnen6JPdulfF5WLAK6r882cWSTbmUXt7VxQ0GD6hkjni@ietf.org
X-Gm-Message-State: AOJu0YxvhZcomnxvUr7eqBnkGuLOuUHaDE6f1v1t2TRM2QEZsNsqsulF HTr/7hgaD1b7D6F9+TTbVSBS65o/Cq1SXrvRxtymh0bmr/CUVVUz1klXEpTj7T611kmbAUtRPLz hdcJVGGF+N356eZrk3RJSQWo3T47Bjnx9xAB3xb0=
X-Gm-Gg: ASbGncucLRTsNoHWDG4bxxKzuBirVGn7vXH8YKe4Vk2tOCMCCxdbhBY3xM8ln52N6lY /kT5U3u4D1JjfQDnMBuCdI9ypJ4UjPyUibYkEoHlF8Q10x+v6pFdCaaLfpCmz5opOg2AarxJise HVhLHRffCQyPcdYUZUWZWuafMhsR8nig==
X-Google-Smtp-Source: AGHT+IGxFiK+Z8oSMrPw1sfpElS8c0zs3KngF1jnCNLNf3kqFJan0zEnaH8CHNTWl2uoVl4S8kvMz0eD93O6mQG6GWM=
X-Received: by 2002:a17:90b:4fca:b0:311:ad7f:329c with SMTP id 98e67ed59e1d1-3130cd97108mr1664715a91.18.1748997366472; Tue, 03 Jun 2025 17:36:06 -0700 (PDT)
MIME-Version: 1.0
References: <174895024824.2740627.17855291019432436704@dt-datatracker-59b84fc74f-84jsl>
In-Reply-To: <174895024824.2740627.17855291019432436704@dt-datatracker-59b84fc74f-84jsl>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Wed, 04 Jun 2025 09:35:55 +0900
X-Gm-Features: AX0GCFu2F6UuL7_H_G3LW5J3IbJMol4pG4jfUjoTBRqMpFLklTaDKyIiAVE2KSk
Message-ID: <CA+RyBmWNQEb2gLmkoBfaMBDtMtou4AHfsAaLuMzQYyPW8pfzPA@mail.gmail.com>
To: Lars Eggert <lars@eggert.org>
Content-Type: multipart/mixed; boundary="000000000000be6bf40636b42e98"
Message-ID-Hash: T75HS6JUFHBTF22TWSOYUZK4K2H2E4MI
X-Message-ID-Hash: T75HS6JUFHBTF22TWSOYUZK4K2H2E4MI
X-MailFrom: gregimirsky@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-ippm.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: tsv-art@ietf.org, draft-ietf-ippm-asymmetrical-pkts.all@ietf.org, ippm@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [ippm] Re: draft-ietf-ippm-asymmetrical-pkts-07 early Tsvart review
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/t5AIwHHvsLlrZ371Dg6q-HsENAQ>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Owner: <mailto:ippm-owner@ietf.org>
List-Post: <mailto:ippm@ietf.org>
List-Subscribe: <mailto:ippm-join@ietf.org>
List-Unsubscribe: <mailto:ippm-leave@ietf.org>

Hi Lars,
thank you for the review, comments, and suggestions. Please find my notes
below tagged GIM>>. I attached the diff that highlights updates applied in
the new working version.

Regards,
Greg

On Tue, Jun 3, 2025 at 8:30 PM Lars Eggert via Datatracker <noreply@ietf.org>
wrote:

> Document: draft-ietf-ippm-asymmetrical-pkts
> Title: Performance Measurement with Asymmetrical Traffic Using STAMP
> Reviewer: Lars Eggert
> Review result: On the Right Track
>
> # tsvart-early review of draft-ietf-ippm-asymmetrical-pkts-07
>
> CC @larseggert
>
> This document has been reviewed as part of the transport
> area review team's ongoing effort to review key IETF
> documents. These comments were written primarily for the
> transport area directors, but are copied to the
> document's authors and WG to allow them to address any
> issues raised and also to the IETF discussion list for
> information.
>
> When done at the time of IETF Last Call, the authors
> should consider this review as part of the last-call
> comments they receive. Please always CC tsv-art@ietf.org
> if you reply to or forward this review.
>
> ## Comments
>
> This is a readable document in decent shape. I have no particular concerns.
>
> ### DOWNREFs
>
> DOWNREF `[RFC7497]` from this Proposed Standard to Informational `RFC7497`.
>
GIM>> We consider a good understanding of RFC 7497 is useful to a reader of
the draft, and an implementer of the STAMP extensions defined. But we are
open to the suggestion to move RFC 7497 to the Informational references
list.

>
> ## Nits
>
> All comments below are about very minor potential issues that you may
> choose to
> address in some way - or ignore - as you see fit. Some were flagged by
> automated tools (via https://github.com/larseggert/ietf-reviewtool) so
> there
> will likely be some false positives. There is no need to let me know what
> you
> did with these suggestions.
>
> ### Typos
>
> #### Section 3.3, paragraph 3
> ```
> -    multicast network with monitoring the onsistency of Differentiated
> +    multicast network with monitoring the consistency of Differentiated
>
GIM>> Thank you for the catch, fixed.

> +                                          +
> ```
>
> ### Outdated references
>
> Document references `draft-ietf-ippm-capacity-protocol-15`, but `-18` is
> the
> latest available revision.
>
GIM>> I suspect that this is transitive inconsistency. The working version
should catch up with the latest version of
draft-ietf-ippm-capacity-protocol.

>
> ### Grammar/style
>
> #### Section 3.3, paragraph 2
> ```
>  test packet reflection, e.g., extremely small intervals and/or too many
> conc
>                                ^^^^^^^^^^^^^^^
> ```
> Consider using an extreme adjective for "small".
>
GIM>> Would s/extremely small/minuscule/ be acceptable?
Also, propose s/too many concurrent sessions/ an excessive number of
concurrent sessions/
WDYT?

>
> #### Section 4, paragraph 3
> ```
> A of [RFC9097] offers an example pseudo-code for a UDP load rate
> adjustment a

                                 ^^^^^^^^^^^
> ```
> This word is normally spelled as one.
>
GIM>> Removed "an example". WDYT?

>
> ## Notes
>
> This review is in the ["IETF Comments" Markdown format][ICMF]. You can use
> the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
>
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments
> [IRT]: https://github.com/larseggert/ietf-reviewtool
>
>
>