Re: [ippm] Lars Eggert's No Objection on draft-ietf-ippm-explicit-flow-measurements-03: (with COMMENT)

Giuseppe Fioccola <giuseppe.fioccola@huawei.com> Fri, 26 May 2023 08:52 UTC

Return-Path: <giuseppe.fioccola@huawei.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60C55C151074; Fri, 26 May 2023 01:52:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.894
X-Spam-Level:
X-Spam-Status: No, score=-1.894 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9GLFArS0xNtr; Fri, 26 May 2023 01:52:15 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19F8CC14CF1C; Fri, 26 May 2023 01:52:15 -0700 (PDT)
Received: from frapeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QSJXL6tVpz67kyX; Fri, 26 May 2023 16:50:10 +0800 (CST)
Received: from frapeml500006.china.huawei.com (7.182.85.219) by frapeml500005.china.huawei.com (7.182.85.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 26 May 2023 10:52:11 +0200
Received: from frapeml500006.china.huawei.com ([7.182.85.219]) by frapeml500006.china.huawei.com ([7.182.85.219]) with mapi id 15.01.2507.023; Fri, 26 May 2023 10:52:11 +0200
From: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
To: Lars Eggert <lars@eggert.org>, The IESG <iesg@ietf.org>
CC: "draft-ietf-ippm-explicit-flow-measurements@ietf.org" <draft-ietf-ippm-explicit-flow-measurements@ietf.org>, "ippm-chairs@ietf.org" <ippm-chairs@ietf.org>, "ippm@ietf.org" <ippm@ietf.org>, "marcus.ihlar@ericsson.com" <marcus.ihlar@ericsson.com>
Thread-Topic: Lars Eggert's No Objection on draft-ietf-ippm-explicit-flow-measurements-03: (with COMMENT)
Thread-Index: AQHZjuXOLAxyaBoUO0ytWdQDSwkBCq9rLXTA
Date: Fri, 26 May 2023 08:52:11 +0000
Message-ID: <78d04a6d555b4b49af756546d870414b@huawei.com>
References: <168500454565.39487.3719377445641453937@ietfa.amsl.com>
In-Reply-To: <168500454565.39487.3719377445641453937@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.81.200.79]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/v_pdCyrWzx8UuPgj3qTVSXyq4Ao>
Subject: Re: [ippm] Lars Eggert's No Objection on draft-ietf-ippm-explicit-flow-measurements-03: (with COMMENT)
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2023 08:52:19 -0000

Hi Lars,
Thanks for your review.
Please see my reply inline tagged as [GF].

Regards,

Giuseppe

-----Original Message-----
From: Lars Eggert via Datatracker <noreply@ietf.org> 
Sent: Thursday, May 25, 2023 10:49 AM
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-ippm-explicit-flow-measurements@ietf.org; ippm-chairs@ietf.org; ippm@ietf.org; marcus.ihlar@ericsson.com; marcus.ihlar@ericsson.com
Subject: Lars Eggert's No Objection on draft-ietf-ippm-explicit-flow-measurements-03: (with COMMENT)

Lars Eggert has entered the following ballot position for
draft-ietf-ippm-explicit-flow-measurements-03: No Objection

When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ippm-explicit-flow-measurements/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-ippm-explicit-flow-measurements-03

CC @larseggert

## Comments

### Too many authors

The document has eight authors, which exceeds the recommended author limit. Has
the sponsoring AD agreed that this is appropriate?

[GF]: Yes, we explained the motivations and Martin agreed. This document comes from a merge of two drafts and it was noted that this case warrants an exception.

### Inclusive language

Found terminology that should be reviewed for inclusivity; see
https://www.rfc-editor.org/part2/#inclusive_language for background and more
guidance:

 * Term `crippling`; alternatives might be `broken`, `damaged`, `defective`,
   `deformed`, `impaired`

[GF]: Ok, we will check and revise the terminology.

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

[GF]: We will review all the nits below and try to address them. 

### Outdated references

Document references `draft-ietf-tcpm-accurate-ecn-23`, but `-24` is the latest
available revision.

Document references `draft-ietf-tsvwg-udp-options-19`, but `-20` is the latest
available revision.

### Grammar/style

#### "Table of Contents", paragraph 1
```
headers (e.g. TCP sequence and acknowledgment numbers) to allow for quantitat
                               ^^^^^^^^^^^^^^
```
Do not mix variants of the same word ("acknowledgment" and "acknowledgement")
within a single text.

#### Section 1, paragraph 2
```
ination. Each technique uses a small number of bits and exposes a specific m
                             ^^^^^^^^^^^^^^^^^
```
Specify a number, remove phrase, use "a few", or use "some".

#### Section 1, paragraph 2
```
this document proposes adding a small number of dedicated measurement bits to
                              ^^^^^^^^^^^^^^^^^
```
Specify a number, remove phrase, use "a few", or use "some".

#### Section 2.1, paragraph 7
```
on. The delay sample lifetime is comprised of two phases: initialization and
                              ^^^^^^^^^^^^^^^
```
Did you mean "comprises" or "consists of" or "is composed of"?

#### Section 2.2.1, paragraph 5
```
used to produce a delay measure. Therefore the value of T_Max must also be k
                                 ^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Therefore".


#### Section 3.3.2.2, paragraph 1
```
Therefore, recommendations in section Section 3.2.3.1 apply equally to impro
                              ^^^^^^^^^^^^^^^
```
Possible typo: you repeated a word.

#### Section 3.4.3.1, paragraph 1
```
unting packets in this direction with a E bit equal to 1. The upstream CE-ma
                                      ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 3.4.3.2, paragraph 4
```
 header, the available metrics using an unidirectional or bidirectional obse
                                     ^^
```
Use "a" instead of "an" if the following word doesn't start with a vowel sound,
e.g. "a sentence", "a university".

#### Section 3.4.3.4, paragraph 6
```
 4 bits, i.e. QL or QR + SD, allow to have more complete and resilient measur
                                   ^^^^^^^
```
Did you mean "having"? Or maybe you should add a pronoun? In active voice,
"allow" + "to" takes an object, usually a pronoun.

#### Section 3.5, paragraph 1
```
various situations. The choice of the the methods also depends on the specif
                                  ^^^^^^^
```
Possible typo: you repeated a word.

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool