Re: [IPsec] AD review of draft-ietf-ipsecme-qr-ikev2-08

Paul Wouters <paul@nohats.ca> Wed, 06 November 2019 14:42 UTC

Return-Path: <paul@nohats.ca>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B7451208B6 for <ipsec@ietfa.amsl.com>; Wed, 6 Nov 2019 06:42:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nohats.ca
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GpBYB1FaL8mM for <ipsec@ietfa.amsl.com>; Wed, 6 Nov 2019 06:42:55 -0800 (PST)
Received: from mx.nohats.ca (mx.nohats.ca [IPv6:2a03:6000:1004:1::68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3CF51200F9 for <ipsec@ietf.org>; Wed, 6 Nov 2019 06:42:54 -0800 (PST)
Received: from localhost (localhost [IPv6:::1]) by mx.nohats.ca (Postfix) with ESMTP id 477Tlx5CH0zFby; Wed, 6 Nov 2019 15:42:53 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nohats.ca; s=default; t=1573051373; bh=lDAXHi5FUcnox3VtYQyBr7ROnwuQ4RUNGTqRTmEO41Q=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=cqs5vOw9V/VkY+ZVt28Oy3lDPycarJvqCwzwq4fQIuCxsPIl9W765foX48MD/F7KQ hOsjeyPC1FVCs63ees6n59tX3TzfqdEPM8ctC7Di42yEkbhjs3I07Gix4GdDEAXrCJ e260O14qDL/YuMNTdtUV8BoJ5N8vQ0XHse/Tutyg=
X-Virus-Scanned: amavisd-new at mx.nohats.ca
Received: from mx.nohats.ca ([IPv6:::1]) by localhost (mx.nohats.ca [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id floLxigcrcqx; Wed, 6 Nov 2019 15:42:52 +0100 (CET)
Received: from bofh.nohats.ca (bofh.nohats.ca [76.10.157.69]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.nohats.ca (Postfix) with ESMTPS; Wed, 6 Nov 2019 15:42:52 +0100 (CET)
Received: by bofh.nohats.ca (Postfix, from userid 1000) id 964DF6001610; Wed, 6 Nov 2019 09:42:51 -0500 (EST)
Received: from localhost (localhost [127.0.0.1]) by bofh.nohats.ca (Postfix) with ESMTP id 92B5423D09A; Wed, 6 Nov 2019 09:42:51 -0500 (EST)
Date: Wed, 06 Nov 2019 09:42:51 -0500
From: Paul Wouters <paul@nohats.ca>
To: Valery Smyslov <svan@elvis.ru>
cc: "ipsec@ietf.org WG" <ipsec@ietf.org>
In-Reply-To: <06de01d59477$97f347e0$c7d9d7a0$@elvis.ru>
Message-ID: <alpine.LRH.2.21.1911060940430.10926@bofh.nohats.ca>
References: <20191105023831.GH55993@kduck.mit.edu> <058d01d593e5$0be7eb80$23b7c280$@elvis.ru> <20191105195939.GH61969@kduck.mit.edu> <alpine.LRH.2.21.1911051731400.15597@bofh.nohats.ca> <06de01d59477$97f347e0$c7d9d7a0$@elvis.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"; format="flowed"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/Agjn-gTFGWCLSoQiY5GKJK7ERNU>
Subject: Re: [IPsec] AD review of draft-ietf-ipsecme-qr-ikev2-08
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 14:42:56 -0000

On Wed, 6 Nov 2019, Valery Smyslov wrote:

> Do you think the current diagrams are confusing?

Yes. Because often I go back to RFCs and only look at the diagrams
expecting it to be what I need to implement. So for optional/required
payloads, I would mostly look at the diagram, and perhaps read a bit
of text.

>> That is, the diagrams should represent the state machine, not an
>> example of the state machine.
>
> Hmmmm... It's an open question :-) Aa a counter-example,
> the EAP and non-EAP case of IKEv2 are not shown
> on the same diagrams - these are different diagrams,
> however the state machine for IKE_AUTH is the same.

Sure.

> I think diagrams (at least in IKE) don't replace state machine
> description and are mostly used for clarity.

We even put the diagrams in some of our code comments. It's used
for more than just clarity by us :)

Paul