Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-eddsa-04

Yoav Nir <ynir.ietf@gmail.com> Mon, 27 November 2017 18:52 UTC

Return-Path: <ynir.ietf@gmail.com>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC24D1292CE; Mon, 27 Nov 2017 10:52:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8kDOm-KRJRbc; Mon, 27 Nov 2017 10:52:02 -0800 (PST)
Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 166C71270A3; Mon, 27 Nov 2017 10:51:59 -0800 (PST)
Received: by mail-wm0-x229.google.com with SMTP id v186so36981622wma.2; Mon, 27 Nov 2017 10:51:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cH/zE46AO3nlnKLOl73KViBYRVJ/HvNksL6Sc05yNX4=; b=OUnzZZoZcZuBdXprcM8Q/rqpVUA1/VW5fsT50kDwiCukZgGyoHp3LGAf/cDZ7VS+r1 KbkVSgEqC2ArU4mJC1WtkSB+s8vRbgW0IgiorOHEdL37MC3KgT5G617f8M0pGsp/mifS PxwomtjuTHBgSPLHth91g7Czu9bRdf3VIVo2+DwItXAJRcLJ912h7IMbxqVGNK8dmouw Rlr0aHKGQdOVjnnGdy8YGv3aFCBi01x3/kE5qc46Kn1Yhgvt3L9cBXikCca/H/51G8wF s0LRoq8/d5cZ3E16AHi+uBsi1wctuQ0xcRUE/eQp97VgkJYV0PxRozSVEWYbToCxt6uo klOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cH/zE46AO3nlnKLOl73KViBYRVJ/HvNksL6Sc05yNX4=; b=sXBDYa/UBrlbR5jEjeWhpmaep2VMbpZy7Vd+Quy886fMAbEiCkrwj06F+PSu32We1Z AI4mP9DsgOOpJmCLiKZbaxENn+yHC+y1pX0QkR5gdidJCxDJRiP9w2qVe2lHMQCR497g k8JKcgmLbTJqJ5GnP0/8vsHTy/L++kuwMVzCSUOqWMIPI159AB9HCvqSOMCuvNeUmPjz rDOawhdfWROwRO/sGum3mVFAt7VAImS+GY4EguZxre86eRE3ntoxeYfCcDhutqpmBVU9 /jNibaL74Z2Fij05XO31No+hiMXvVmh1OO9sVX0reQDZq/xZ14V63pdca7q40iSzb8S9 YnYQ==
X-Gm-Message-State: AJaThX5HdSNaBcJJK36QtU46PofXbWOEWmH+/GTaR2vY6wGrSfOCAze5 gFS3rkrRtRBvno89vEb4Ijg=
X-Google-Smtp-Source: AGs4zMairR2sfNUYRGiwRdZC8XpTXzr30A0qTFwp5i3M+IJSUpwJI2H0MctvCCuS8Fjoep4YSTOj1w==
X-Received: by 10.28.138.12 with SMTP id m12mr19458997wmd.134.1511808717614; Mon, 27 Nov 2017 10:51:57 -0800 (PST)
Received: from [192.168.1.18] ([46.120.57.147]) by smtp.gmail.com with ESMTPSA id i55sm9385454wra.60.2017.11.27.10.51.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 10:51:56 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
From: Yoav Nir <ynir.ietf@gmail.com>
In-Reply-To: <151179175411.30910.13010385715015417131@ietfa.amsl.com>
Date: Mon, 27 Nov 2017 20:51:54 +0200
Cc: secdir <secdir@ietf.org>, ipsec@ietf.org, ietf@ietf.org, draft-ietf-ipsecme-eddsa.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <23E34FAC-BF15-4523-91CE-88E3B2A7AA46@gmail.com>
References: <151179175411.30910.13010385715015417131@ietfa.amsl.com>
To: Adam Montville <adam.w.montville@gmail.com>
X-Mailer: Apple Mail (2.3445.4.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/FfIWa_27ECYYWYJrgx5ywq6F7lw>
Subject: Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-eddsa-04
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Nov 2017 18:52:04 -0000


> On 27 Nov 2017, at 16:09, Adam Montville <adam.w.montville@gmail.com> wrote:
> 
> Reviewer: Adam Montville
> Review result: Ready
> 
> I have reviewed this document as part of the security directorate's ongoing
> effort to review all IETF documents being processed by the IESG.  These
> comments were written primarily for the benefit of the security area directors.
> Document editors and WG chairs should treat these comments just like any other
> last call comments.
> 
> This document is ready.
> 
> A very straightforward, short document defining a new value in
> SIGNATURE_HASH_ALGORITHMS notification of IKE, so that non-hashing signature
> methods (specifically the Edwards-curve digital signature algorithm) can be
> used.

Thanks, Adam.

> 
> One nit: s/or/of/ in last sentence of second introduction paragraph, so that it
> reads, "See section 8.5 of RFC 8032…”

Unless something else comes up, I’ll leave this to AUTH48 (although the RFC Editor are likely to find it and fix it anyway).

Yoav