Re: [IPsec] I-D Action: draft-ietf-ipsecme-add-ike-07.txt

Tero Kivinen <kivinen@iki.fi> Tue, 31 January 2023 14:54 UTC

Return-Path: <kivinen@iki.fi>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 950C5C1524AC for <ipsec@ietfa.amsl.com>; Tue, 31 Jan 2023 06:54:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.1
X-Spam-Level:
X-Spam-Status: No, score=-7.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=iki.fi
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L_jHmykzhvD6 for <ipsec@ietfa.amsl.com>; Tue, 31 Jan 2023 06:54:36 -0800 (PST)
Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 44B42C1524BC for <ipsec@ietf.org>; Tue, 31 Jan 2023 06:54:36 -0800 (PST)
Received: from fireball.acr.fi (fireball.acr.fi [83.145.195.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kivinen@iki.fi) by meesny.iki.fi (Postfix) with ESMTPSA id A2FB2200D7; Tue, 31 Jan 2023 16:54:31 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1675176871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0jEqr84ph2eT5wEX5hWq7SaC327om8QBN5yHq8lyJmQ=; b=xTyl8Tt+ynwDV+HCSP7ReVj5ux/XPEYp+iajMfS/+bxZLLmvwtgUABG1vx7vccILOr27cR b6AP9iwmCFFnOuKLL4aUvPssV6b3a2ctn+GgRegcZys5LWoXmOo9TDqY+W22CmN9gPKpxf iMAcwmVnfMzc4NJybhwNx0FreQhI8A8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1675176871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0jEqr84ph2eT5wEX5hWq7SaC327om8QBN5yHq8lyJmQ=; b=wCGM0z+fUz+2kbs26LaI9fFaAITsQrlkuPT3Z0+27D5BL2Qv0iPZvw2jvkN/DE49nnSTqm lSf3XuONMbmw3YJRzIC7QWBX7cz2HIs3FGw1aL4x8gYNr2dzU/8m5kmqsY+J43xkdJuWik 6ngmf7FQ7kh90nF4V0EsJVuORKFtg8s=
ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=kivinen@iki.fi smtp.mailfrom=kivinen@iki.fi
ARC-Seal: i=1; s=meesny; d=iki.fi; t=1675176871; a=rsa-sha256; cv=none; b=gIVF9wFEsI5yywoMbVAfVBVXeKPA+df5eSM5ltQYekq1wuAOfRQ9kMxXXUTps7J3dh6KkJ dwZUIrIU/VBFfsEOgMwmR4O0xQOG5OD8YKj8F1UNGuFs9RHFShM7zxlKxOfj3bPf6ZBj1O yCOpMwANmCMkAhxShaFeI6/I0kpZpnE=
Received: by fireball.acr.fi (Postfix, from userid 15204) id 1F56725C1300; Tue, 31 Jan 2023 16:54:31 +0200 (EET)
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-ID: <25561.11175.76466.937014@fireball.acr.fi>
Date: Tue, 31 Jan 2023 16:54:31 +0200
From: Tero Kivinen <kivinen@iki.fi>
To: mohamed.boucadair@orange.com
Cc: "ipsec@ietf.org" <ipsec@ietf.org>
In-Reply-To: <17966_1675174995_63D92453_17966_383_3_2000a34a0ce54dde9cb97d99924d3cde@orange.com>
References: <167517474984.55048.8470595929422809144@ietfa.amsl.com> <17966_1675174995_63D92453_17966_383_3_2000a34a0ce54dde9cb97d99924d3cde@orange.com>
X-Mailer: VM 8.2.0b under 26.3 (x86_64--netbsd)
X-Edit-Time: 8 min
X-Total-Time: 8 min
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/duOB-C2yuM5uExCVilTWr5Bit6Y>
Subject: Re: [IPsec] I-D Action: draft-ietf-ipsecme-add-ike-07.txt
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jan 2023 14:54:37 -0000

mohamed.boucadair@orange.com writes:
> This version takes into account Tero's review, mainly:
> 
> * Indicate the encoding of the addresses
> * Split the ENCDNS_DIGEST_INFO figure into two
> * Add some text about CFG_ACK
> * clarify how the digest is computed
> * Add some examples
> 
> and some other minor edits. 

Can you add the other examples we had in our email exachange for
different requests, I think they provide useful information.

Also in examples it is useful to actually use names instead of
numbers, thats why I had (SHA2-256, SHA2-384, SHA2-512), and not (2,
3, 4). We are not using numbers for CP, CFG_REQUEST, or any other
fields...

Using only numbers would get really annoying:

   47(1) =
     8()
     10()
     TBA2()
     TBA3(0, (2, 3, 4))

:-)

And the ADN length field of the CFG_REPLY example is wrong, it says
16, but "doh.example.com" is only 15 characters long. Thats why my
example was using doh1.example.com :-)

I.e. it should be:

   CP(CFG_REPLY) =
     INTERNAL_IP6_ADDRESS(2001:db8:0:1:2:3:4:5/64)
     ENCDNS_IP6(1, 1, 15,
                   (2001:db8:99:88:77:66:55:44),
                   "doh.example.com",
                   (alpn=h2 dohpath=/dns-query{?dns}))
     ENCDNS_DIGEST_INFO(0, SHA2-256,
                           8b6e7a5971cc6bb0b4db5a71...)

-- 
kivinen@iki.fi