Re: [IPsec] draft-fluhrer-qr-ikev2 AUTH issue

Derrell Piper <ddp@electric-loft.org> Fri, 18 August 2017 20:56 UTC

Return-Path: <ddp@electric-loft.org>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8260C13234E for <ipsec@ietfa.amsl.com>; Fri, 18 Aug 2017 13:56:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hYBvai2VNQnD for <ipsec@ietfa.amsl.com>; Fri, 18 Aug 2017 13:56:28 -0700 (PDT)
Received: from Mail.Yoyodyne.COM (mail.yoyodyne.com [139.60.72.138]) by ietfa.amsl.com (Postfix) with SMTP id E5AF9132332 for <ipsec@ietf.org>; Fri, 18 Aug 2017 13:56:27 -0700 (PDT)
Received: from [192.168.1.73] ([172.8.232.61]) by Mail.Yoyodyne.COM via Internet for <ipsec@ietf.org>; Fri, 18 Aug 2017 13:56:27 PDT
From: Derrell Piper <ddp@electric-loft.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Date: Fri, 18 Aug 2017 13:56:27 -0700
References: <alpine.LRH.2.21.1708162147570.26093@bofh.nohats.ca> <22933.40647.462618.166901@fireball.acr.fi> <alpine.LRH.2.21.1708171113120.3833@bofh.nohats.ca>
To: "ipsec@ietf.org WG" <ipsec@ietf.org>
In-Reply-To: <alpine.LRH.2.21.1708171113120.3833@bofh.nohats.ca>
Message-Id: <BBCE47D6-F761-415E-B376-F92B0B2F7B8D@electric-loft.org>
X-Mailer: Apple Mail (2.3273)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/nkkdhMelVDf2qOzftQOWSzRvsKs>
Subject: Re: [IPsec] draft-fluhrer-qr-ikev2 AUTH issue
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Aug 2017 20:56:29 -0000

Notes on draft-fluhrer-qr-ikev2-04, mostly nits:

pp. 1
"...pose a serious challenge to cryptography algorithms [deployed?] widely today."

pp. 2
"when might one be implemented" -> "when one might be implemented"

pp. 3
The Changes section wording confuses me.  Does that mean, relative to the last draft?  Or 
does it mean those were the change in -03?

pp. 4
"...then it must check if has a..." -> "...if it has a..."

pp. 8

"Algorithm=urn:ietf:params:xml:ns:keyprov:pskc:pin"

RE: rfc6030, any chance we can not refer to an RFC with XML in it?  I strongly
object to XML.  Does IKEv2 reference any XML?  (sticks fingers in ears...)

pp. 9

RE: rfc6023 text

I would prefer text here that suggests exactly how to achieve post-quantum ID
confidentiality.  This is vague and that means people will implement it all
over the map.  I also don't think Child SAs should ever have been made
mandatory, so refering to rfc6023 is fine.

Overall, I think this document should advance.  This is nice and simple, more
or less.

Derrell