[IPsec] AD review of draft-ietf-ipsecme-rfc4307bis

Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com> Fri, 09 December 2016 18:33 UTC

Return-Path: <kathleen.moriarty.ietf@gmail.com>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 800231294F1 for <ipsec@ietfa.amsl.com>; Fri, 9 Dec 2016 10:33:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NqEARRAS5Gav for <ipsec@ietfa.amsl.com>; Fri, 9 Dec 2016 10:33:41 -0800 (PST)
Received: from mail-vk0-x229.google.com (mail-vk0-x229.google.com [IPv6:2607:f8b0:400c:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B3CC1129988 for <ipsec@ietf.org>; Fri, 9 Dec 2016 10:33:32 -0800 (PST)
Received: by mail-vk0-x229.google.com with SMTP id x186so12960399vkd.1 for <ipsec@ietf.org>; Fri, 09 Dec 2016 10:33:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=EzGEOd7VSo11lJOsqrulzkX2o7E/0LzDTP+P5/wPTLY=; b=hD1ktK182nMsO1WIrjLL9yHfGVmU7OnbFk26+ivz+x2l43Al/4sdarCoGtgkBtzbXu c//ouWVMqt707YaKaHAsxO1RkadtfThH/8EzWB0C7EC0Ke224NNHQ8GsJ7c+3b3yo2XT WhKcW/0z2gawt95eL5vQwJiqB5Ofm3Ox4IPbexPhLeOPjPaLfQYwpqcMfrkxb3OEdQdl yehvo1BwZ1etixNfUGPkuYdXa4vn1nIpfEmhdCZ7/0mymHhe2/6p60Kc0VMHDfwCVe1q oFR66JNEgbzVA17qN1DBdRjWEF2+dxiPbz3nRDPaLo5Zr1w5izYvVyt6M+rQDB8rQKhl NGaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=EzGEOd7VSo11lJOsqrulzkX2o7E/0LzDTP+P5/wPTLY=; b=T9AE3bNFuJQq7APlYY+s8V1hHeIG/e0d2VYauFEFb2hlzlbRa/PWd+BYH9kWHMSRFi oqPL4DjNE7TQnmXq2jQ5c8/2lL97wQe9yaDFt6tZZkVUWHTM0DXpHXyqX5cHesANWUQO tx1sEl5bVI9NhBjvIzyQO+HWOFMcSWupmaa7EINjc1DGGLguSyKQmp9CQWCXYJhyvsxG pQAhl/IGMsJ0ii9YWOS9dKGfhgzfQAQIXQVmc4vIIvmK8gYtjDqywchGX/VEDKL0RG4R N6u0EQZg9p2ZkWGFz5EdrkWtfbktUuTbaDXLIbPnaO56mpEeh9haAFMe0qv+7Yrc4gWv PC3w==
X-Gm-Message-State: AKaTC026C6YUl5RyDUrJMXPQMInSanyB7ePZOBSiXPgo8ohohTcTGjchwaq8ZWTA5psu+Q9fq8Xe6VeGBkMIjA==
X-Received: by 10.31.32.213 with SMTP id g204mr32334054vkg.152.1481308411589; Fri, 09 Dec 2016 10:33:31 -0800 (PST)
MIME-Version: 1.0
Received: by 10.176.82.232 with HTTP; Fri, 9 Dec 2016 10:33:31 -0800 (PST)
From: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>
Date: Fri, 09 Dec 2016 13:33:31 -0500
Message-ID: <CAHbuEH4pqTK-kc65FVh98X-t+YsVe+9=J7_PjB8hESsY+5=-PQ@mail.gmail.com>
To: "ipsec@ietf.org" <ipsec@ietf.org>
Content-Type: multipart/alternative; boundary="001a11c01c36acf93205433dfd61"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/yiaDpkk03ZzRSY07VkVDBhlbVf4>
Subject: [IPsec] AD review of draft-ietf-ipsecme-rfc4307bis
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Dec 2016 18:33:43 -0000

Hello,

Thanks for your work on draft-ietf-ipsecme-rfc4307bis.  I reviewed the
draft and just have a few questions, the first is a nit.


Nit:
In the second paragraph of 1.3, you can drop the last two words of this
sentence as they are redundant:

   This document does not give any recommendations for the use of
   algorithms, it only gives implementation recommendations for
   implementations.



In section 3.2 & 3.3, why isn't there a bigger jump down to SHOULD or
SHOULD- for:

PRF_HMAC_SHA1     | MUST-    |

| AUTH_HMAC_SHA1_96      | MUST-

The justifications seems like a bigger jump would be appropriate.


Thank you!

-- 

Best regards,
Kathleen