Re: [Gen-art] Genart last call review of draft-ietf-6man-icmp-limits-07

Alissa Cooper <alissa@cooperw.in> Mon, 09 March 2020 16:19 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: ipv6@ietfa.amsl.com
Delivered-To: ipv6@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DE3863A1369; Mon, 9 Mar 2020 09:19:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=uC0l6xlw; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=HHfPj5fZ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BTcyc75d0Jsw; Mon, 9 Mar 2020 09:19:38 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF30F3A1354; Mon, 9 Mar 2020 09:19:37 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E659A22033; Mon, 9 Mar 2020 12:19:36 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 09 Mar 2020 12:19:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm2; bh=0ptS4pmJIdmML9rXeGwYck7 BElie7y3GCeuL5REtXbM=; b=uC0l6xlwC8AuD8JXfSsHTFjoJcp8KqvlVJWqVLp HbcMFErf7BWYJhJ4q5/1rhO0kXOGiW29QA2fe0fwEz8coT19wrquO/OTfelWpgPe Bgwmb3FiGhFx8Edn2nYUpeQ8D1swjfBY/Yo7uUZuVwpjk4wgLoGJbfaZL6xDCbpJ yvc29A0yWKQr09xIUzMvF9twKxxC+oTxGF00g+sFbhmhwJGQrU2NyzcAh8U5JkJo O1WNXmW51YZ3PPjq4jJMJ89JasdwbwSGmaVvqI2LKmvtLeH2wME0plBo9+bqg5u9 U11b324n5mPpO27J+ZmZSF/mD6ijhSP+lpIzlPbOcTck9Lg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0ptS4p mJIdmML9rXeGwYck7BElie7y3GCeuL5REtXbM=; b=HHfPj5fZLQLYsh5adNBEnV zd08Aumsk2Ewugudz5tc2zPu82KuN1FI2Vy78UYJPkU9d1V9G2JMUqu1cgj5Mdsk vTm4oMxnig9XYowom0YW3/bF0rzK87wQjyyh2bh7Lz/NUPT/SNpdJHtfCz/9pWZN OkG02MwQdwH0L2glZhaebpNP1kK/ayc0S4kYwIAsyCWYISRpiBZqq/cWL1RUCrZG W2Z81K6dS9omS1kRrAjE/j7Sn96VUJrsB9ePz4WliiyBKAY01H6uo/0XRloa3D4w BHiLP+aBAIdNZfhfepXptRhEj9Vx67gWhB6xVUJS46oyeNOKnawFNHL8I8/EmDYA ==
X-ME-Sender: <xms:mGxmXq0GvRD8QR0mmkWd387uWcTSCdS6SAl5xjSIGs_6eYi45vLz7A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddukedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgfvfhfosegrtdhmrehhtddvnecuhfhrohhmpeetlhhishhs rgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomhgrih hnpehivghtfhdrohhrghenucfkphepjeehrddutdegrdeikedrudelgeenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhishhsrgestghooh hpvghrfidrihhn
X-ME-Proxy: <xmx:mGxmXqnL866H-otz6-c6_lXXToF_T-ybkTcca6XIehdoa0Y20Egl_Q> <xmx:mGxmXhqd1VnywrFTamsO7oXZ4SRltzUrjspi4BswhNSNFcl7V82kfw> <xmx:mGxmXgjOcBpbOVnMr1txzW7Iz3hu7db5XXK5T4xFe6UCrdEU6YzdKQ> <xmx:mGxmXj-AHrOr7VbRl-BMXueuGmSf4CRb4AfKXmBfKM40eQ2y6oGPJA>
Received: from [172.27.4.81] (unknown [75.104.68.194]) by mail.messagingengine.com (Postfix) with ESMTPA id D43053280066; Mon, 9 Mar 2020 12:19:29 -0400 (EDT)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <9A9896B4-AD01-4F77-B3D5-76643F4AF5D1@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_76DC3860-2D3E-4764-891A-2FF282753A6D"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: [Gen-art] Genart last call review of draft-ietf-6man-icmp-limits-07
Date: Mon, 9 Mar 2020 12:19:27 -0400
In-Reply-To: <CAPDqMer7yT4mr2OcQy0Kmn-JXgfN0rH6kOmWQqUOh45KC469VA@mail.gmail.com>
Cc: last-call@ietf.org, General Area Review Team <gen-art@ietf.org>, ipv6@ietf.org, draft-ietf-6man-icmp-limits.all@ietf.org
To: Tom Herbert <tom@quantonium.net>, Pete Resnick <resnick@episteme.net>
References: <158196611989.24025.16967350964547632805@ietfa.amsl.com> <CAPDqMer7yT4mr2OcQy0Kmn-JXgfN0rH6kOmWQqUOh45KC469VA@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipv6/_0Tw0D5pM1XgOAD9WWIkyrTDt0g>
X-BeenThere: ipv6@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "IPv6 Maintenance Working Group \(6man\)" <ipv6.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipv6>, <mailto:ipv6-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipv6/>
List-Post: <mailto:ipv6@ietf.org>
List-Help: <mailto:ipv6-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipv6>, <mailto:ipv6-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Mar 2020 16:19:41 -0000

Pete, thanks for your review. Tom, thanks for your response. I entered a DISCUSS ballot to get the maturity level fixed. 

Best,
Alissa


> On Mar 5, 2020, at 2:17 PM, Tom Herbert <tom@quantonium.net> wrote:
> 
> Hi Pete,
> 
> Thanks for the review. Comments inline.
> 
> On Mon, Feb 17, 2020 at 11:02 AM Pete Resnick via Datatracker
> <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
>> 
>> Reviewer: Pete Resnick
>> Review result: Ready with Nits
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>> 
>> For more information, please see the FAQ at
>> 
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>> 
>> Document: draft-ietf-6man-icmp-limits-07
>> Reviewer: Pete Resnick
>> Review Date: 2020-02-17
>> IETF LC End Date: 2020-02-25
>> IESG Telechat date: Not scheduled for a telechat
>> 
>> Summary:
>> 
>> Nice simple document, easy to read, and pretty much ready to go. The one
>> "issue" I have listed below is a process nit, but one that should be taken care
>> of.
> 
> Thanks!
> 
>> 
>> Major issues:
>> 
>> None.
>> 
>> Minor issues:
>> 
>> The tracker and the shepherd writeup say that the status of the document is
>> "Proposed Standard", but the header of the document says "Standard". That's why
>> the nits checker is complaining about downrefs; it thinks that this is going
>> for Full Standard. The header should either say "Standards Track" (which is
>> normal) or "Proposed Standard". (I hereby give Bob crap for missing that one as
>> shepherd, and I think he should owe me a beer. ;-) )
> 
> Will fix.
> 
>> 
>> Nits/editorial comments:
>> 
>> The Abstract and 1.1 both indicate that a source host that receives such an
>> ICMPv6 error may be able to modify what it sends, which sounds to me like it
>> means "on the fly". While that might be true, it seems more likely to me that
>> it will be used for diagnostics to modify future behavior of either the sender
>> or the receiver at a later date, as mentioned in 4.2. I think it's worth
>> mentioning up at the top.
> 
> Yes, I would expect these are most useful for offline diagnostics at
> least at the beginning. Will mention that.
>> 
>> Section 1.3: You should probably update to the RFC 8174 text.
>> 
> Okay.
> 
>> Section 5.1: "RECOMMENDS" isn't one of the keywords. It's not a problem in
>> itself, but if people search the document for the keywords (and they do),
>> they'll miss this one. Suggest reformulating the sentence to use RECOMMENDED.
> 
> Will fix, thanks for being pedantic!
> 
>> 
>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org <mailto:Gen-art@ietf.org>
> https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>