Re: [Last-Call] Tsvart last call review of draft-ietf-6man-icmp-limits-07

Tom Herbert <tom@herbertland.com> Wed, 26 February 2020 04:27 UTC

Return-Path: <tom@herbertland.com>
X-Original-To: ipv6@ietfa.amsl.com
Delivered-To: ipv6@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32D993A0C61 for <ipv6@ietfa.amsl.com>; Tue, 25 Feb 2020 20:27:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=herbertland-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0X0IF9OPAgHz for <ipv6@ietfa.amsl.com>; Tue, 25 Feb 2020 20:27:16 -0800 (PST)
Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5E3A83A0C5D for <ipv6@ietf.org>; Tue, 25 Feb 2020 20:27:16 -0800 (PST)
Received: by mail-ed1-x531.google.com with SMTP id v28so2053038edw.12 for <ipv6@ietf.org>; Tue, 25 Feb 2020 20:27:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=herbertland-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G1tiTc7O6i/4F233cK5j5MzowS4fSaXevWTfrgA68Cc=; b=sCGCnzu5k6IXC3R0wUQpe/+/dyt5PvjTUrOHpgIOnrLwECDEOiideQFW+Qq6xIqp+e NKX0UNJDylcITSuFCYYP5apvwf9JJF9WdkZs7+IRxcIlUtEl6LFCQzaZE+SDBAcORDHB wyfwF/Hovw1ZmVK2vQDSBzH/ulmn8AEIYVlxWyktxJ3z/wSs//T8z5/wJLjwvwFiXGVd uQc6EHwmW60W0UeQvnN3urLyhYaub838zCNjTUzQVR7jbbslrwyVvHGgb7T5XFTMMwTN VsqWV5gwuS8ra/cBuyLx/fNpBssEHJL+5jBB+yRmKnkTkro1kFRAkVYdKuMeK6xTErlg X79Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G1tiTc7O6i/4F233cK5j5MzowS4fSaXevWTfrgA68Cc=; b=KnW3c6rg9Tgd3x4GiSYfRirysWDPOflaAxQdxv9aqGWCiTDH9Saxwut4Lbu0XrPq8l o4lXWy/BJLUmzU/FQYEvT7X4WeitIzLyotMjfj0pZF72Bs014x/2xgH36uo6dKiPBiR4 Ze/217vFK6lnFE/4KRWavyy8z4ArSDPmCswO7WN2MpeKIhcVxP0pgpF2WRv51tZaRBjP aW975KNL3Rwascfg1WoUOIkL+8z4Em4vWvFtxM7OmbDUSK19j6u7IEd2w6RtKdArCLPY DbFtrRZfWgBCRM9XaH4gTiNeYaoICmtBR6gYoOkM9zLl6bDXLtfpZifrNhhr1vF/jzfS mZfQ==
X-Gm-Message-State: APjAAAXdmHbJJXuvWjc3IIJ/rz9r4lOr32gJohpyXQfdyVmfwVOJw2D6 c8LeLp8ZJcRorOQJsHHseQCBnvJ0cgwZHk4CGm8VPg==
X-Google-Smtp-Source: APXvYqzs4r6NBCyLS5+gqrC1ummZHxBcORBz52BSzkcsHHXzoB6ejHAvZaTr86UJ2CEmYbazXf99LyxqxbSj4ayAidk=
X-Received: by 2002:a17:906:1a0c:: with SMTP id i12mr2309301ejf.295.1582691234491; Tue, 25 Feb 2020 20:27:14 -0800 (PST)
MIME-Version: 1.0
References: <158205974177.14048.8752559981047005317@ietfa.amsl.com> <20200225193403.GC56312@kduck.mit.edu> <C5D0D4A7-D9B1-46E6-B0D7-9C10A7DFA31A@gmail.com>
In-Reply-To: <C5D0D4A7-D9B1-46E6-B0D7-9C10A7DFA31A@gmail.com>
From: Tom Herbert <tom@herbertland.com>
Date: Tue, 25 Feb 2020 20:27:03 -0800
Message-ID: <CALx6S37Q-MCFXzYh1Av4vRdGJQ9dN0eR=r_ZPkaAcCxzQ-cDTA@mail.gmail.com>
Subject: Re: [Last-Call] Tsvart last call review of draft-ietf-6man-icmp-limits-07
To: Suresh Krishnan <suresh.krishnan@gmail.com>
Cc: Bernard Aboba <bernard.aboba@gmail.com>, Benjamin Kaduk <kaduk@mit.edu>, tsv-art@ietf.org, 6man <ipv6@ietf.org>, last-call@ietf.org, draft-ietf-6man-icmp-limits.all@ietf.org
Content-Type: multipart/alternative; boundary="000000000000d25137059f73040f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipv6/hDSH1RCJKLFLR-fi5ObMp8RagvQ>
X-BeenThere: ipv6@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "IPv6 Maintenance Working Group \(6man\)" <ipv6.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipv6>, <mailto:ipv6-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipv6/>
List-Post: <mailto:ipv6@ietf.org>
List-Help: <mailto:ipv6-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipv6>, <mailto:ipv6-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Feb 2020 04:27:20 -0000

Pointer is probably an unfortunate term. Would have been better if this was
originally described as an offset. In any case, the text is clear, the
offset of the byte in error (pointer) can be beyond the extent of the
packet, and the implementation needs to correctly deal with that.

Tom

On Tue, Feb 25, 2020, 8:02 PM Suresh Krishnan <suresh.krishnan@gmail.com>
wrote:

> Hi Bernard/Ben,
>   Thanks for your review. Just responding to one point below.
>
> On Feb 25, 2020, at 2:34 PM, Benjamin Kaduk <kaduk@MIT.EDU> wrote:
>
> On Tue, Feb 18, 2020 at 01:02:21PM -0800, Bernard Aboba via Datatracker
> wrote:
>
> Reviewer: Bernard Aboba
> Review result: Ready with Issues
>
> TSV-ART Review of draft-ietf-6man-icmp-limits
> Bernard Aboba
>
> Result: Ready with Issues
>
> This document specifies several new ICMPv6 errors that can be sent
> when a node discards a packet due to it being unable to process the
> necessary protocol headers because of processing constraints or
> limits.  Reasons include:
>
>      Code (pertinent to this specification)
>         1 - Unrecognized Next Header type encountered
>         TBA - Extension header too big
>         TBA - Extension header chain too long
>         TBA - Too many options in extension header
>         TBA - Option too big
>
> ICMP Reliability
>
> Section 5.2 states:
>
> "  ICMP is fundamentally an unreliable protocol and in real deployment
>   it may consistently fail over some paths. As with any other use of
>   ICMP, it is assumed that the errors defined in this document are only
>   best effort to be delivered. No protocol should be implemented that
>   relies on reliable delivery of ICMP messages. If necessary,
>   alternative or additional mechanisms may used to augment the
>   processes used to to deduce the reason that packets are being
>   discarded. Such alternative mechanisms are out of scope of this
>   specification."
>
> [BA] The last sentence is a bit vague. My assumption is that this is
> referring to techniques such as are used in Path MTU discovery (e.g.
> tweaking of packets so as to determine potential reasons why packets
> are being discarded).  However, a reference might be helpful.
>
> Security Concerns
>
> Pointer field
>
> In Section 3.1, the description of the Pointer field states:
>
> "      Pointer
>         Identifies the octet offset within the invoking packet where
>         the problem occurred.
>
>         The pointer will point beyond the end of the ICMPv6 packet if
>         the field having a problem is beyond what can fit in the
>         maximum size of an ICMPv6 error message."
>
> [BA] I worry about attackers using the Pointer field for
> mischief, such as buffer overflows.  The draft currently
> does not provide advice to implementers about validating
> the Pointer field (e.g. checking it against the length of
> the offending packet). Do we really need a 32-bit Pointer field?
>
>
> Very reminiscent of heartbleed, even with the note that "The pointer will
> point beyond the end of the ICMPv6 packet if the field having a problem is
> beyond what can fit in the maximum size of an ICMPv6 error message."
>
>
> Hmm. This is exactly how base ICMPv6 (RFC4443 and prior to that RFC2463
> and RFC1885) defines and uses the Pointer field. And the intent is
> specifically to be able to point past the end of the packet since the
> “offending” packet may not be able to fit into the reporting packet. Is
> there something specific that you think is being enabled by this draft and
> needs to be addressed?
>
> Regards
> Suresh
>
> --------------------------------------------------------------------
> IETF IPv6 working group mailing list
> ipv6@ietf.org
> Administrative Requests: https://www.ietf.org/mailman/listinfo/ipv6
> --------------------------------------------------------------------
>