Re: I-D Action: draft-ietf-6man-icmp-limits-05.txt

Bob Hinden <bob.hinden@gmail.com> Tue, 17 September 2019 20:21 UTC

Return-Path: <bob.hinden@gmail.com>
X-Original-To: ipv6@ietfa.amsl.com
Delivered-To: ipv6@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E0E2112010D for <ipv6@ietfa.amsl.com>; Tue, 17 Sep 2019 13:21:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id np_zI60uQ2IW for <ipv6@ietfa.amsl.com>; Tue, 17 Sep 2019 13:21:24 -0700 (PDT)
Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 95B1B120072 for <ipv6@ietf.org>; Tue, 17 Sep 2019 13:21:23 -0700 (PDT)
Received: by mail-wm1-x335.google.com with SMTP id o184so4627018wme.3 for <ipv6@ietf.org>; Tue, 17 Sep 2019 13:21:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=zOwC3WkvKH5PTF9Ojdx+gxR5vW0TDl4tcFiDJ6nhbj4=; b=jwlLgewbGKX0XJ1D+kiLs4ma1CDQjIqT2Y1Onc76Vsit8j6vOXsaqSX+uoeh71+z8A R+2LLi3hoDz94BSN2vzoxUKvYGMqbhmnHktNlHbU/ckyhfXvnItBM1QHALDR0xGuO3uP sJ1wxp0dKceMBrajJcWrGyjW+hZIbpEChQm5L+9nWqu5reRyzFFc8cXydfMSychFLn58 XxHZH+IpcKcn18KP6WJnxF+dLEgVq4lRcoJXlZ4uXhwcbXfBMGvl2tkCFjznBAq2jle5 2yh/uD37XKBZsvv4dYIweJOkv46+6L3MbhWdq25BRzE/NEKf3Z3D6VdFXAA5Sx/cUCxm 7TcQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=zOwC3WkvKH5PTF9Ojdx+gxR5vW0TDl4tcFiDJ6nhbj4=; b=jbno26H5ahiIXhMsEjqei/P1qDcP+asl1cuZPHLHnMdwrIDpf+mm/2TYm3SA348fz0 ROMwtlX1vzG21WafQs5ZlydRrjlGgdihS3ofMz3PEUfP7tkRm5ohXvFK/bXQijda5CAN LQ0lNwxbXCq5MPD9/P0S9pNbwUy4sDJWwo06/p9mnE0v9p9tfDwqjc3DzRWUPwHZtDXA SEtkS4LS0e7AzIP1e+w2y/THJzh2EgiqsTAT7dTNEYAvs+g3xVr7YZqc+JJCd0iz1ZDg FDEOy20Xq8cKUWM5cMQlk5TtF5jN/BX+4EWWVtQIsXPH08FZOQ4hTOcav5ni+h+WZYXU QB0Q==
X-Gm-Message-State: APjAAAWOWcJprho08CSXrmc9UgZkF8mGXSpEIQI5zJXSZS1WS2SEdkZ1 z/s7p15tM2hysG83/PnUDig=
X-Google-Smtp-Source: APXvYqxBWkzRZdwaR10HJeJ0E++f3z/uHQtM3t6U+uO6c1IkmJnlnSXSjlVYYC/pKfajK6xiBQL1/g==
X-Received: by 2002:a1c:1d84:: with SMTP id d126mr4873638wmd.58.1568751682013; Tue, 17 Sep 2019 13:21:22 -0700 (PDT)
Received: from ?IPv6:2601:647:5a00:ef0b:cc6c:ad29:c523:1733? ([2601:647:5a00:ef0b:cc6c:ad29:c523:1733]) by smtp.gmail.com with ESMTPSA id r9sm4883604wra.19.2019.09.17.13.21.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 13:21:21 -0700 (PDT)
From: Bob Hinden <bob.hinden@gmail.com>
Message-Id: <54CA04FA-2DC0-4506-9522-1F363D3724CC@gmail.com>
Content-Type: multipart/signed; boundary="Apple-Mail=_F4C97E20-3488-459D-8CD0-C89A28F76913"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: I-D Action: draft-ietf-6man-icmp-limits-05.txt
Date: Tue, 17 Sep 2019 13:21:15 -0700
In-Reply-To: <CALx6S35z4mHoQOwSQTH2+a4Uu2fA5qBjMMn-pJH1OV_NTTqatA@mail.gmail.com>
Cc: Bob Hinden <bob.hinden@gmail.com>, IPv6 List <ipv6@ietf.org>
To: Tom Herbert <tom@herbertland.com>
References: <156813714123.27560.11545725069258655310@ietfa.amsl.com> <CALx6S35z4mHoQOwSQTH2+a4Uu2fA5qBjMMn-pJH1OV_NTTqatA@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipv6/p8loTFJ5BYbfw2ba86f3Mj_raKQ>
X-BeenThere: ipv6@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "IPv6 Maintenance Working Group \(6man\)" <ipv6.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipv6>, <mailto:ipv6-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipv6/>
List-Post: <mailto:ipv6@ietf.org>
List-Help: <mailto:ipv6-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipv6>, <mailto:ipv6-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Sep 2019 20:21:26 -0000

Tom,

I took a look at the new draft.  Thanks for fixing most of the issues I raised.  Much better.

I think there is still an issue with Section 3 that defines a new code point for the Destination unreachable message.

RFC4884 Section 4.4 "ICMPv6 Destination Unreachable” in the header format includes:

     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
     |                    As much of invoking packet                 |
     +                as possible without the ICMPv6 packet          +
     |                exceeding the minimum IPv6 MTU [RFC4443]       |

but in draft-ietf-6man-icmp-limits-05 shows:

  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ M
  |                       Original Datagram                       | P
  ~     Internet Header + leading octets of original datagram     ~ |
  |                                                               | |

This is a change from RFC4884.  Further, the draft has:

     Original Datagram
        As much of invoking packet as possible without exceeding the
        minimum ICMPv6 packet minus twelve bytes (for the ICMP
        extension structure and the ICMP extension object) and any
        necessary padding. The Original Datagram field MUST be zero
        padded to the nearest 64-bit boundary [RFC4884]. If the
        original datagram did not contain 128 octets, the Original
        Datagram field MUST be zero padded to 128 octets.

I can’t find anything in RFC4884 that says to reduce the size of the original datagram to allow the extensions to fit.   This is a change from what RFC4884 specifies.    RFC4884 specifically says:

   The syntax and semantics of all fields are unchanged from RFC 4443.
   However, a length attribute is added to the second word.  The length
   attribute represents length of the padded "original datagram" field,
   measured in 64-bit words.

I think this change to RFC4884 is out of scope for a document that wants to define a new code point.

I think a possible solution (beside not changing the RFC4884 format) is to say the new extensions can only be sent with packets that don’t exceed the minimum IPv6 MTU.   Or else, add a code point to the Parameter Problem as Ron suggested, even though it’s not idea for the reasons you pointed out.

Bob



> On Sep 10, 2019, at 10:47 AM, Tom Herbert <tom@herbertland.com> wrote:
> 
> Hello,
> 
> I've submitted this draft to address the comments in the chairs' review.
> 
> Thanks,
> Tom
> 
> On Tue, Sep 10, 2019 at 10:40 AM <internet-drafts@ietf.org> wrote:
>> 
>> 
>> A New Internet-Draft is available from the on-line Internet-Drafts directories.
>> This draft is a work item of the IPv6 Maintenance WG of the IETF.
>> 
>>        Title           : ICMPv6 errors for discarding packets due to processing limits
>>        Author          : Tom Herbert
>>        Filename        : draft-ietf-6man-icmp-limits-05.txt
>>        Pages           : 15
>>        Date            : 2019-09-10
>> 
>> Abstract:
>>   Network nodes may discard packets if they are unable to process
>>   protocol headers of packets due to processing constraints or limits.
>>   When such packets are dropped, the sender receives no indication so
>>   it cannot take action to address the cause of discarded packets. This
>>   specification defines several new ICMPv6 errors that can be sent by a
>>   node that discards packets because it is unable to process the
>>   protocol headers. A node that receives such an ICMPv6 error may be
>>   able to modify what it sends in future packets to avoid subsequent
>>   packet discards.
>> 
>> 
>> The IETF datatracker status page for this draft is:
>> https://datatracker.ietf.org/doc/draft-ietf-6man-icmp-limits/
>> 
>> There are also htmlized versions available at:
>> https://tools.ietf.org/html/draft-ietf-6man-icmp-limits-05
>> https://datatracker.ietf.org/doc/html/draft-ietf-6man-icmp-limits-05
>> 
>> A diff from the previous version is available at:
>> https://www.ietf.org/rfcdiff?url2=draft-ietf-6man-icmp-limits-05
>> 
>> 
>> Please note that it may take a couple of minutes from the time of submission
>> until the htmlized version and diff are available at tools.ietf.org.
>> 
>> Internet-Drafts are also available by anonymous FTP at:
>> ftp://ftp.ietf.org/internet-drafts/
>> 
>> --------------------------------------------------------------------
>> IETF IPv6 working group mailing list
>> ipv6@ietf.org
>> Administrative Requests: https://www.ietf.org/mailman/listinfo/ipv6
>> --------------------------------------------------------------------
> 
> --------------------------------------------------------------------
> IETF IPv6 working group mailing list
> ipv6@ietf.org
> Administrative Requests: https://www.ietf.org/mailman/listinfo/ipv6
> --------------------------------------------------------------------