Re: [Isis-wg] draft-ietf-isis-yang-isis-cfg-07

<stephane.litkowski@orange.com> Wed, 25 November 2015 17:01 UTC

Return-Path: <stephane.litkowski@orange.com>
X-Original-To: isis-wg@ietfa.amsl.com
Delivered-To: isis-wg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D5A621A21BE for <isis-wg@ietfa.amsl.com>; Wed, 25 Nov 2015 09:01:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, J_CHICKENPOX_74=0.6, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OQqdv61OBnrt for <isis-wg@ietfa.amsl.com>; Wed, 25 Nov 2015 09:01:50 -0800 (PST)
Received: from relais-inet.francetelecom.com (relais-ias91.francetelecom.com [193.251.215.91]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E1BDC1A21B0 for <isis-wg@ietf.org>; Wed, 25 Nov 2015 09:01:49 -0800 (PST)
Received: from omfedm07.si.francetelecom.fr (unknown [xx.xx.xx.3]) by omfedm13.si.francetelecom.fr (ESMTP service) with ESMTP id 10F7532461B; Wed, 25 Nov 2015 18:01:48 +0100 (CET)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [10.114.31.2]) by omfedm07.si.francetelecom.fr (ESMTP service) with ESMTP id CD5284C06B; Wed, 25 Nov 2015 18:01:47 +0100 (CET)
Received: from OPEXCLILMA4.corporate.adroot.infra.ftgroup ([fe80::65de:2f08:41e6:ebbe]) by OPEXCLILM21.corporate.adroot.infra.ftgroup ([fe80::e92a:c932:907e:8f06%19]) with mapi id 14.03.0248.002; Wed, 25 Nov 2015 18:01:47 +0100
From: <stephane.litkowski@orange.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, Radha Danda <rdanda@Brocade.com>, "isis-wg@ietf.org" <isis-wg@ietf.org>
Thread-Topic: draft-ietf-isis-yang-isis-cfg-07
Thread-Index: AdEnmJwdFwRr22YfQTqx+4BMOFFAcQAAW2IAAAI1MrA=
Date: Wed, 25 Nov 2015 17:01:46 +0000
Message-ID: <6396_1448470907_5655E97B_6396_1001_21_9E32478DFA9976438E7A22F69B08FF921678D058@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
References: <5d1815f82559463abe2197b10f84954b@BRMWP-EXMB11.corp.brocade.com> <384cdb90ae534966afede0962769209f@XCH-ALN-001.cisco.com>
In-Reply-To: <384cdb90ae534966afede0962769209f@XCH-ALN-001.cisco.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.1]
Content-Type: multipart/alternative; boundary="_000_9E32478DFA9976438E7A22F69B08FF921678D058OPEXCLILMA4corp_"
MIME-Version: 1.0
X-PMX-Version: 6.2.1.2478543, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.11.24.110316
Archived-At: <http://mailarchive.ietf.org/arch/msg/isis-wg/GTzgvv2iEV--5yNQ6M_EEPnHriQ>
Subject: Re: [Isis-wg] draft-ietf-isis-yang-isis-cfg-07
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/isis-wg/>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2015 17:01:54 -0000

Hi,

The NSEL within the system-id is a mistake, I fixed it, so in the next revision , it will be removed.

Thanks for pointing it.

Best Regards,

Stephane


From: Isis-wg [mailto:isis-wg-bounces@ietf.org] On Behalf Of Les Ginsberg (ginsberg)
Sent: Wednesday, November 25, 2015 17:03
To: Radha Danda; isis-wg@ietf.org
Subject: Re: [Isis-wg] draft-ietf-isis-yang-isis-cfg-07

Radha -

From: Isis-wg [mailto:isis-wg-bounces@ietf.org] On Behalf Of Radha Danda
Sent: Wednesday, November 25, 2015 7:49 AM
To: isis-wg@ietf.org<mailto:isis-wg@ietf.org>
Subject: [Isis-wg] draft-ietf-isis-yang-isis-cfg-07


Hi,

I was going through draft-ietf-isis-yang-isis-cfg-07 and I have below comments.



1. system-id definition should not contain selector. As per NSAP definition, system-ID is 6 bytes and it has below mentioned format and it is only of length 6 bytes.





[Les:] I agree - selector should NOT be part of system-id.



typedef system-id {

    type string {

      pattern

       '[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}';

    }

    description

     "This type defines ISIS system id using pattern,

      system id looks like : 0143.0438.AeF0";

  }



2. Also we need support to configure net-address as shown below.



[Les:] No. The model correct supports the config of one system-id (as modified above) and one or more area addresses.

There are implementations which combine the configuration into a single CLI "net" - but if multiple area addresses are supported the same system-id MUST be entered on each line - so functionally what you have are multiple (synonymous) area addresses and a single system-id. The model has it correct in that regard.



   Les



       typedef net-address {

                type string {

                        pattern

                                '[0-9A-Fa-f]{2}\.([0-9A-Fa-f]{4}\.){0,3}[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.00';

                        configd:pattern-help "XX.XXXX. ... .XXXX.XX";

                        configd:help "Network entity title (NET)";

                }

        }



Please let me know if you need more details. This is my first post, so please excuse me in case if I miss to provide some details.



Best Regards,

Radha


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.