Re: [Isis-wg] draft-ietf-isis-yang-isis-cfg-07

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Wed, 25 November 2015 19:08 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: isis-wg@ietfa.amsl.com
Delivered-To: isis-wg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 775891B2AF8 for <isis-wg@ietfa.amsl.com>; Wed, 25 Nov 2015 11:08:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.485
X-Spam-Level:
X-Spam-Status: No, score=-14.485 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, J_CHICKENPOX_74=0.6, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.585, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OD2F8K3UwCqV for <isis-wg@ietfa.amsl.com>; Wed, 25 Nov 2015 11:07:58 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D24A1B2A82 for <isis-wg@ietf.org>; Wed, 25 Nov 2015 11:07:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=19627; q=dns/txt; s=iport; t=1448478478; x=1449688078; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=Me2pktztrFDPFHUdfkxnzPR5PvsJ/kvDdXiZHXK1/Z0=; b=k5ZGF/AVOIq7DP9JTTKqXazrR23ZLeMOw0Vpnjixpdn1OoG2zbS6EHFl P89tWzkRO3jHQbwVAaKSlmInHXpXxVwwcOlwTsl3L5BFm++QXDHnaBsB4 gFc3UPz6rYMVEFxVU34lXo+eiFd4Zrte/2mgaF+x/DBUzvNQiwaJA07dU 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D5AQABBlZW/4cNJK1egm5NU28GvjMBD?= =?us-ascii?q?YFmhg8CgUM4FAEBAQEBAQGBCoQ0AQEBBC1cAgEIDgMEAQEoBzIUCQgBAQQBEgi?= =?us-ascii?q?IJr42AQEBAQEBAQEBAQEBAQEBAQEBAQEBGIZUhH6FEYQoBZJZFoNoAY0tgWOEQ?= =?us-ascii?q?YQejjGDcQEfAQFCgg4ggVZyg2QlHIEHAQEB?=
X-IronPort-AV: E=Sophos;i="5.20,343,1444694400"; d="scan'208,217";a="212305904"
Received: from alln-core-2.cisco.com ([173.36.13.135]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Nov 2015 19:07:56 +0000
Received: from XCH-ALN-003.cisco.com (xch-aln-003.cisco.com [173.36.7.13]) by alln-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id tAPJ7tBa000308 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 25 Nov 2015 19:07:55 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-ALN-003.cisco.com (173.36.7.13) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 25 Nov 2015 13:07:55 -0600
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1104.000; Wed, 25 Nov 2015 13:07:55 -0600
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Radha Danda <rdanda@Brocade.com>, "isis-wg@ietf.org" <isis-wg@ietf.org>
Thread-Topic: draft-ietf-isis-yang-isis-cfg-07
Thread-Index: AdEnmJwdFwRr22YfQTqx+4BMOFFAcQAAW2IAAA5KhYAAB8VqQA==
Date: Wed, 25 Nov 2015 19:07:55 +0000
Message-ID: <84f3e78ad4d748f7a9fc57a058f55097@XCH-ALN-001.cisco.com>
References: <5d1815f82559463abe2197b10f84954b@BRMWP-EXMB11.corp.brocade.com> <384cdb90ae534966afede0962769209f@XCH-ALN-001.cisco.com> <568f541a5489469383198806aa7185f7@BRMWP-EXMB11.corp.brocade.com>
In-Reply-To: <568f541a5489469383198806aa7185f7@BRMWP-EXMB11.corp.brocade.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.30.223]
Content-Type: multipart/alternative; boundary="_000_84f3e78ad4d748f7a9fc57a058f55097XCHALN001ciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/isis-wg/MWj41fkhKtduQ_yKy-tgT66JEsc>
Subject: Re: [Isis-wg] draft-ietf-isis-yang-isis-cfg-07
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/isis-wg/>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2015 19:08:01 -0000

Radha -

You are making the mistake of thinking that vendor specific CLI determines how we define the YANG model.

The protocol functionality is:

1)Define system-id for an IS-IS instance
2)Define one or more area addresses for the IS-IS instance

Whether a particular vendor uses a "net" config or  a "system-id" and "area address" config isn't relevant.

   Les

(Of course I work for a vendor that uses "net" config. :) )


From: Radha Danda [mailto:rdanda@Brocade.com]
Sent: Wednesday, November 25, 2015 8:47 AM
To: Les Ginsberg (ginsberg); isis-wg@ietf.org
Subject: RE: draft-ietf-isis-yang-isis-cfg-07

Thanks Les.

Regarding the net-address configuration. Find the sample configuration from Cisco router
router isis
net 49.0001.1720.1600.1001.00
net 50.0001.1720.1600.1001.00

net-address here consists of area-address, system-id and selector. Even Juniper router has similar configuration. So I think yang should be modelled to support these existing configurations.
And validation should be done to ensure the uniqueness of system-id.

In the above mentioned net configurations, system-id is unique.

If we don't support net-address configuration in yang, I am afraid back-end implementation of protocols might have to be changed. Please let me know your thoughts.

Also the way yang model is currently designed (assuming the selector is removed from system-id), there is no way to input selector now.

And separate area-address is not needed if we support net-address configuration.

Best Regards,
Radha

From: Les Ginsberg (ginsberg) [mailto:ginsberg@cisco.com]
Sent: Wednesday, November 25, 2015 9:33 PM
To: Radha Danda; isis-wg@ietf.org<mailto:isis-wg@ietf.org>
Subject: RE: draft-ietf-isis-yang-isis-cfg-07

Radha -

From: Isis-wg [mailto:isis-wg-bounces@ietf.org] On Behalf Of Radha Danda
Sent: Wednesday, November 25, 2015 7:49 AM
To: isis-wg@ietf.org<mailto:isis-wg@ietf.org>
Subject: [Isis-wg] draft-ietf-isis-yang-isis-cfg-07


Hi,

I was going through draft-ietf-isis-yang-isis-cfg-07 and I have below comments.



1. system-id definition should not contain selector. As per NSAP definition, system-ID is 6 bytes and it has below mentioned format and it is only of length 6 bytes.





[Les:] I agree - selector should NOT be part of system-id.



typedef system-id {

    type string {

      pattern

       '[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}';

    }

    description

     "This type defines ISIS system id using pattern,

      system id looks like : 0143.0438.AeF0";

  }



2. Also we need support to configure net-address as shown below.



[Les:] No. The model correct supports the config of one system-id (as modified above) and one or more area addresses.

There are implementations which combine the configuration into a single CLI "net" - but if multiple area addresses are supported the same system-id MUST be entered on each line - so functionally what you have are multiple (synonymous) area addresses and a single system-id. The model has it correct in that regard.



   Les



       typedef net-address {

                type string {

                        pattern

                                '[0-9A-Fa-f]{2}\.([0-9A-Fa-f]{4}\.){0,3}[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.[0-9A-Fa-f]{4}\.00';

                        configd:pattern-help "XX.XXXX. ... .XXXX.XX";

                        configd:help "Network entity title (NET)";

                }

        }



Please let me know if you need more details. This is my first post, so please excuse me in case if I miss to provide some details.



Best Regards,

Radha