Re: [Isis-wg] RtgDir review: draft-ietf-isis-fs-lsp

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Wed, 04 June 2014 02:29 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: isis-wg@ietfa.amsl.com
Delivered-To: isis-wg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B442D1A019D; Tue, 3 Jun 2014 19:29:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.151
X-Spam-Level:
X-Spam-Status: No, score=-15.151 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.651, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PzwkIncU_lO8; Tue, 3 Jun 2014 19:29:29 -0700 (PDT)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9717E1A01A6; Tue, 3 Jun 2014 19:29:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=40196; q=dns/txt; s=iport; t=1401848963; x=1403058563; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=H4pZjTaHcxF5ABBpRVXzUnCN+LVjN+Ei1UIg1q9QE10=; b=jyeD3/FLzpB+uWXGa2EPU4C16f3p9bGi3RqQQ7Qua1EVosyWaNUHslTx usB5tf1h6yb0Y3wet623p4i3i9wPwOt++Y1sG6LGMomFr7ApbppleAwqX Zc5LNOUu7G2iYPyul5FE7DtyCsnyvVttVvKdYUK5sRmDxUZTYNo0ivBrs Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ArgFAIiDjlOtJV2U/2dsb2JhbABZgkJFUlUDgmy3DYh7ARlxFnSCJQEBAQQjCj4OEAIBCA4DAwEBAQsWAQYDAgICMBQJCAIEAQ0FCBOIJw2sL6VXF4xigRgnIBEGAYJ1NoEVBJtIkXWDOGyBAUI
X-IronPort-AV: E=Sophos;i="4.98,970,1392163200"; d="scan'208,217";a="330332711"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-8.cisco.com with ESMTP; 04 Jun 2014 02:29:21 +0000
Received: from xhc-aln-x15.cisco.com (xhc-aln-x15.cisco.com [173.36.12.89]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id s542TLHM021301 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 4 Jun 2014 02:29:21 GMT
Received: from xmb-aln-x02.cisco.com ([169.254.5.121]) by xhc-aln-x15.cisco.com ([173.36.12.89]) with mapi id 14.03.0123.003; Tue, 3 Jun 2014 21:29:20 -0500
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Ross Callon <rcallon@juniper.net>, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Thread-Topic: RtgDir review: draft-ietf-isis-fs-lsp
Thread-Index: AQHPf4m85EAbI0Lr3EKuCz3dI7ZY55tgMUfg
Date: Wed, 4 Jun 2014 02:29:20 +0000
Message-ID: <F3ADE4747C9E124B89F0ED2180CC814F23DF6CE2@xmb-aln-x02.cisco.com>
References: <63953eac4ee842eda7f2a36439567dad@CO2PR05MB636.namprd05.prod.outlook.com>
In-Reply-To: <63953eac4ee842eda7f2a36439567dad@CO2PR05MB636.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [128.107.163.140]
Content-Type: multipart/alternative; boundary="_000_F3ADE4747C9E124B89F0ED2180CC814F23DF6CE2xmbalnx02ciscoc_"
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/isis-wg/TiNki4e3yBIYK1ji51EhZ-y-Vww
Cc: "draft-ietf-isis-fs-lsp.all@tools.ietf.org" <draft-ietf-isis-fs-lsp.all@tools.ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "isis-wg@ietf.org" <isis-wg@ietf.org>
Subject: Re: [Isis-wg] RtgDir review: draft-ietf-isis-fs-lsp
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/isis-wg/>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jun 2014 02:29:31 -0000

Ross –

Thank you for your thoughtful review.
Inline.

From: rtg-dir [mailto:rtg-dir-bounces@ietf.org] On Behalf Of Ross Callon
Sent: Tuesday, June 03, 2014 5:13 PM
To: rtg-ads@tools.ietf.org
Cc: draft-ietf-isis-fs-lsp.all@tools.ietf.org; rtg-dir@ietf.org; isis-wg@ietf.org
Subject: [RTG-DIR] RtgDir review: draft-ietf-isis-fs-lsp

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-isis-fs-lsp
Reviewer: Ross Callon
Review Date: June 3, 2014
IETF LC End Date: June 3, 2014
Intended Status: Standards Track

Summary: This document is basically ready for publication, but has nits that should be considered prior to publication.

Comments:

The draft is well written, clear, and very readable. I have only a few minor thoughts or questions that the authors might consider along with any other comments received.

Major Issues:  None

Minor Issues:

These are mostly actually questions or very minor clarity issues that the authors could optionally think about.


Section 1 (“Introduction”), second paragraph, second to last sentence. This reads:

   When the information content is large this is inefficient
   and still does not provide a guarantee of reliability.

Actually, I think that it does provide a guarantee of reliability, since the data is resent periodically and therefore if the network is operating should *eventually* get there. What it does not guarantee is timely reliability. Therefore I would suggest that the word “reliability” should be replaced with either “timeliness” or “timely reliability”.

LES: I am going to disagree with you here. ☺
Reliability to me means not just that you know that somehow you will (eventually) receive all of the current information but also that you have a way of determining whether the information you currently have is up to date or not.  Imagine that it takes 2 hellos to contain all of the AF information. My neighbor will repeatedly send IIH-1 and IIH-2. So even if I drop IIH-2, I should eventually receive it – which I think is your point. But when I do receive IIH-2, it is also possible that IIH-1 has recently changed and I managed to drop the most recent IIH-1. So how do I know at a given moment in time that I really do have the latest information? Answer – I don’t.

So the term “timely reliability” to me is a bit of a misnomer. The current scheme works because drops are (usually) rare and repetition makes up for the occasional drop – but this is qualitatively different than saying it is reliable.

I prefer to leave the text unchanged.

Section 1, third paragraph: I did eventually figure out (when reading sections 9 and 12) that the solution to the “limited LSP set carrying capacity”, extended TLVs, also apply to the existing scopes. I even see this briefly mentioned in the abstract. It might add clarity slightly if the last sentence of the third paragraph is changed from “This capability is also defined in this document” to something such as “This capability is also defined in this document and may be applied to both existing and new scopes”.

LES: I added the phrase “alternative solution to the limited LSP set carrying capacity of Level 1 and Level 2 LSPs as part of the extensions defined in this document.”

I wasn’t comfortable with the term “existing scopes” as it seemed to confuse existing L1/L2 LSPs with the new PDUs (FS-LSPs) .

Section 3.1 (“Flooding Scoped LSP Format”), description of the Scope:

Received
     FS-LSPs with a scope of 0 MUST be ignored.

Is it commonly understood that “ignored” includes “do NOT forward”? If there is any chance that anyone might get confused we could change this to:

Received
     FS-LSPs with a scope of 0 MUST NOT be forwarded and MUST be ignored.

LES: Point taken. The new text reads:
  “Received   FS-LSPs with a scope of 0 MUST be ignored and MUST NOT
     be flooded.”

Still section 3.1, I wondered whether 16 bits is long term going to be enough for the remaining lifetime. If I did the math right, this implies a maximum of just over 18 hours. Given reliable flooding is there anything that we might want to refresh less often than every 18 hours?

 LES: Interesting comment. A similar question was raised during WG review – but for a very different reason. Someone “did the math” and concluded that if we actually generated 65000 FS-LSPs that even at maximum lifetime we would have to refresh one FS-LSP/second constantly. Of course, the reality is that we aren’t going to approach anywhere near 65000 FS-LSPs. The 16 bit extended LSP number is deemed so much larger than any anticipated need as to never approach the maximum number in real deployments. (We are not trying to become BGP. ☺)

Changing the lifetime field would violate our goal of keeping the format of FS-LSPs as close as possible to existing LSPs so as to maximize reuse of existing code.  And such a change would affect the format of LSP entries in FS-SNPs as well. Refreshing a given FS_LSP once every 18 hours still seems like a “very long time” to me. So unless we feel strongly that there is a need for a longer lifetime I would like to leave things as they are.

Section 12: I wondered whether “expert review” was the right allocation method for scope identifiers, or if we want to require IETF consensus (normally implying an RFC which goes through IETF last call). I don’t think that we want a lot of them. Do we anticipate either standards from other groups or proprietary protocols (ie, anything that wouldn’t have an IETF consensus RFC) to receive scope IDs?

LES: I thought about this. I think Expert Review is almost always selected for IS-IS because ISO still has some ownership (though admittedly none of the IS-IS experts live there any more). So while the chances of something other than an RFC requesting a scope identifier seems neglible, using Expert Review covers us in case this ever happens. I have nothing invested here – if there is consensus that IETF Review is more appropriate I am fine with it – but the current choice was a conscious decision.

   Les


Nits: None

Thanks, Ross