[Isis-wg] comments on draft-litkowski-isis-yang-isis-cfg-01

"Wunan (Eric)" <eric.wu@huawei.com> Tue, 22 July 2014 19:26 UTC

Return-Path: <eric.wu@huawei.com>
X-Original-To: isis-wg@ietfa.amsl.com
Delivered-To: isis-wg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com []) by ietfa.amsl.com (Postfix) with ESMTP id 0B0291B29B0 for <isis-wg@ietfa.amsl.com>; Tue, 22 Jul 2014 12:26:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id XzI-G4poE7Kf for <isis-wg@ietfa.amsl.com>; Tue, 22 Jul 2014 12:26:34 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com []) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE4CE1B27EE for <isis-wg@ietf.org>; Tue, 22 Jul 2014 12:26:33 -0700 (PDT)
Received: from (EHLO lhreml406-hub.china.huawei.com) ([]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BHM51360; Tue, 22 Jul 2014 19:26:32 +0000 (GMT)
Received: from SZXEMA402-HUB.china.huawei.com ( by lhreml406-hub.china.huawei.com ( with Microsoft SMTP Server (TLS) id; Tue, 22 Jul 2014 20:26:31 +0100
Received: from SZXEMA508-MBX.china.huawei.com ([]) by SZXEMA402-HUB.china.huawei.com ([]) with mapi id 14.03.0158.001; Wed, 23 Jul 2014 03:26:23 +0800
From: "Wunan (Eric)" <eric.wu@huawei.com>
To: "stephane.litkowski@orange.com" <stephane.litkowski@orange.com>, "isis-wg@ietf.org" <isis-wg@ietf.org>
Thread-Topic: comments on draft-litkowski-isis-yang-isis-cfg-01
Thread-Index: Ac+l4qtZhrh5j6gJR3OwDOjb/Qkn+Q==
Date: Tue, 22 Jul 2014 19:26:22 +0000
Message-ID: <0F26584357FD124DB93F1535E4B0A65036804905@szxema508-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
x-originating-ip: []
Content-Type: multipart/alternative; boundary="_000_0F26584357FD124DB93F1535E4B0A65036804905szxema508mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: http://mailarchive.ietf.org/arch/msg/isis-wg/k3EMbrkeWspKagR89pLov2JAmcA
Subject: [Isis-wg] comments on draft-litkowski-isis-yang-isis-cfg-01
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/isis-wg/>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2014 19:26:36 -0000

Hi Stephane,

Some comments below. Please check.

1. +--rw isis

Should be a list here with a key like [name] or [local-id] here?

2. +--rw nsap-address in isis-cfg container,

"nsap-address" is used here but "system-id" is used isis-state. Suggest to use same one.

And one isis can have at least three NSAP since area address can be different.

3. +--rw ipv4-router-id?

    +--rw ipv6-router-id?

Not sure the use here.

4. Missing vrf association ?

5. Missing nsf ?

6. Missing traffic engineering ?

7. Missing Timer related cfg ?

8. Missing redistribution related cfg ?

9. Multi-topology should allow to configure more besides ipv4-uni, ipv6-uni, ipv4-multi, ipv6-multi

These are commonly used configuration which should not be omitted.

10. isis route configuration and operation should be included in isis-cfg and isis-state ?

11. interfaces and TE state should be included in isis-state