Re: [ipwave] Patching Linux Kernel with OCB

Sara el hamdani <saraelhamdani@gmail.com> Mon, 24 June 2019 00:06 UTC

Return-Path: <saraelhamdani@gmail.com>
X-Original-To: its@ietfa.amsl.com
Delivered-To: its@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 236B5120105 for <its@ietfa.amsl.com>; Sun, 23 Jun 2019 17:06:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QYrCgwVOsBVk for <its@ietfa.amsl.com>; Sun, 23 Jun 2019 17:06:42 -0700 (PDT)
Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E55412001A for <its@ietf.org>; Sun, 23 Jun 2019 17:06:42 -0700 (PDT)
Received: by mail-yb1-xb30.google.com with SMTP id w9so473670ybe.9 for <its@ietf.org>; Sun, 23 Jun 2019 17:06:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CJc8Vc5wYzBwDJ/NkJ0hm1C0RtWGvOebRXib+XwzEi8=; b=Zv5WzmwZhN70kRdfAM6ClTQpULA9GQMf2V4mC4Y9FyF15L8mm9jFLxVBRDjQIOJ4AW viVqF4oj8hATThU1f285hOo9QY/TuvB8Ob9WGcl9oNw64dsdLO2w+VXvDyQNxei7NwFp kDM9Vxn2bVNWdAs7ZOqtDQDgPXvDFSMuBaT0Tzt31cA0pPoiBMxOFDS6kX3YNlEga77Z 8EskMrPVyrQgOGSQW0NOT+jvXrEpupY4AaxkRXcMiwyFKdAVAB+noB2Peg/IhqRFsXYk LBbcwBLw0N3FRJsMtdzRqrgFLZYTCOPCXBOSW+9/t4cH2Ah6cyTYF1E7oKobdQ4acMNt 3alQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CJc8Vc5wYzBwDJ/NkJ0hm1C0RtWGvOebRXib+XwzEi8=; b=oYjNGS/9TrsBQF/BrHhgq9QkY4bOIUd+KN0rSPuORKK41aa6EM7lnaSq5NBYEuxzij lOLQRD4zLyR+fI2ZYSL37NRM1gz7h4We4Azd/TMPf628gLVxEOPwKGSweIiWUYt8/rpI xkJUUEoXP3qRrI75xMeFckwhzUy4Be5mU18Vl4E2n6vi3XpJL0UDpdYg9+IrKWmMXVw8 l/bhzaqUSCbqXACTp6F7tfEzJfPzGLBHqDLRBwaLhpcb+QxcDQpt78wnb2nUUSz8gE07 5/KCv1TGXB6UBJLi7G+HLft9LsXKsj8wVFFV7huCFsG88lVzIW2BbRcwARzU33mQ+ASr u/Pg==
X-Gm-Message-State: APjAAAU2Z2Vip95pQXI3jT7leXVEkbwP1vJ4kr2X97uV7mWo+OmmzOcw 7mR02RLnMIqfPGzwtq2JysAPi4yUdUZkoSHpXeY8arOh
X-Google-Smtp-Source: APXvYqzVqaGPxBWXqb4h5jRhlNt4EzTjNnL0M34bpa7hXczva3gcoAVmkdtM/ZccpObvqU7CoDOJI+nX+EpKO1DrFlk=
X-Received: by 2002:a25:1854:: with SMTP id 81mr77111741yby.152.1561334801380; Sun, 23 Jun 2019 17:06:41 -0700 (PDT)
MIME-Version: 1.0
References: <CAM9JMHPbfhNgvDgJP3kMj7VG2DRGa6-t1bbfSrqHeGH62kW1Zg@mail.gmail.com> <d592be28-1160-eeef-7239-2878c35bc2a1@gmail.com> <CAMugd_UzXo_1Usu8k7jR0TjbSEMSnprAFcD4R7Lz8Hwx1g7rqA@mail.gmail.com> <CAJ0NgkDGd83nxqw=BiNCQR1MieFgMVneV=rKbgTUBQzZ=d1m2w@mail.gmail.com>
In-Reply-To: <CAJ0NgkDGd83nxqw=BiNCQR1MieFgMVneV=rKbgTUBQzZ=d1m2w@mail.gmail.com>
From: Sara el hamdani <saraelhamdani@gmail.com>
Date: Mon, 24 Jun 2019 01:06:01 +0100
Message-ID: <CAJ0NgkA2whZwH7FDTPLyNJsuQ7FnOGOpFHiHDewbtWbkPdMdRw@mail.gmail.com>
To: its@ietf.org
Cc: Alexandre Petrescu <alexandre.petrescu@gmail.com>, Nabil Benamar <benamar73@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000363a34058c0696f5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/its/qdfUwKRkAJebuEM0nHXLDnODbgE>
Subject: Re: [ipwave] Patching Linux Kernel with OCB
X-BeenThere: its@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IPWAVE - IP Wireless Access in Vehicular Environments WG at IETF <its.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/its>, <mailto:its-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/its/>
List-Post: <mailto:its@ietf.org>
List-Help: <mailto:its-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/its>, <mailto:its-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jun 2019 00:06:45 -0000

Hello Alex,

Many thanks for sharing your insights.

Indeed, we knew during the hackathon that we should better patch the
kernel in its newest version 5.1.12. However, we couldn't create a new
patch because of the lack of time as mentioned Mr, Nabil. In fact, we did
not have the right adapter for the physical OCB Card we had. So, we spent
the whole first day trying to install the card on the desktop including
creating the adequate antenas manually . Then, we had  in the next day only
six hours to capture IPv6 packets, patch and recompile the kernel ...

We have recommended to the organizers to reserve more time to this truck in
future hackathons. We think also that creating a new patch for the current
linux of the kernel is worth to be the object of an independent truck in
the hackathon.

Concerning the parameters, we have tested the connectivity using ath9k
driver successfully, and we were about to do the same for ath10k but it was
already the presentation time (as we aforementioned, a lack of time).

For the patch creator, we don't know honestly who he is, but we have found
the link mentioned on a previous email of you in the link:
https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view. Thus, we
decided to fix it and to make it work.

Besides, even if we arrived to patch the kernel with ath9k, the report in
the terminal showed that it was not completely successful (not 100%) and it
seems that this is what happens usually. So based on your big experience,
Mr. Alex, in creating and patching the kernel, we would like to know if it
is common for you to patch the kernel successfully 100%?

Le lun. 24 juin 2019 à 00:32, Sara el hamdani <saraelhamdani@gmail.com> a
écrit :

> Hello Alex,
>
> Many thanks for sharing your insights.
>
> Indeed, we knew during the hackathon that we should better patch the
> kernel in its newest version 5.1.12. However, we couldn't create a new
> patch because of the lack of time as mentioned Mr, Nabil. In fact, we
> didn't have the right adapter for the physical OCBcard we had. So, we whole
> first day spent the the first day trying to install the card on the desktop
> including creating manually the adequate antenas.  Then, we had  only six
> hours in the next day to capture IPv6 packets patching and recompiling the
> kernel ect.
>
> We have recommended to the organizers the reserve more time to this truck
> in future hackathons. We think also that creating a new patch for the
> current linux of the kernel is worth to be the object of an independent
> truck in the hackathon.
>
> Concerning the parameters, we have tested the connectivity using ath9k
> driver successfully, and we were about to do the same for ath10k but it was
> the already presentation time (as we aforementioned a lack of time).
>
> For the patch creator, we don't know honestly who he is, but we have found
> the link mentioned on a previous email of you in the link:
> https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view. Thus,
> we decided to fix it and to make it work.
>
> Besides, even if we arrived to patch the kernel with ath9k, the report in
> the terminal showed that it was not completely successful (not 100%) and it
> seems that this is what happens usually. So based on your big in you
> experience, Mr. Alex, on creating and patching the kernel, we would know if
> it is common for you to patch the kernel successfully 100%?
>
> Sara
>
>


> Le ven. 21 juin 2019 à 12:41, Nabil Benamar <benamar73@gmail.com> a
> écrit :
>
>> Hi Alex,
>>
>> Thank you for your comments.
>> This is exactly what the hackathon participants put in future work!
>>
>> 2 days were not enough to build the testbed and test different drivers
>> and parameters...
>>
>> On Fri, Jun 21, 2019, 14:01 Alexandre Petrescu <
>> alexandre.petrescu@gmail.com> wrote:
>>
>>> Hello Mr. Seur,
>>>
>>> I would like to ask you whether you can apply that patch to ath10k also?
>>> (instead of ath9k).
>>>
>>> If you do, you risk being the first to achieve 1Gbps on OCB, hopefully
>>> with IPv6.
>>>
>>> Alex
>>>
>>> Le 20/06/2019 à 15:25, John Seur a écrit :
>>> > Hello IPWavers,
>>> >
>>> > During the Hackathon@AIS2019
>>> > (https://hackathon.internetsummitafrica.org/), the team in IPWave
>>> track
>>> > (led by Nabil Benamar) was patching the Linux kernel 4.9.61 with OCB
>>> > mode and discovered the following bugs in the patch file
>>> > (https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view).
>>> >    drivers/net/wireless/ath/ath9k/main.c:961:2: error: duplicate case
>>> value
>>> >    case NL80211_IFTYPE_OCB:
>>> >    drivers/net/wireless/ath/ath9k/hw.c:1241:2: error: duplicate case
>>> value
>>> >    case NL80211_IFTYPE_OCB:
>>> >
>>> > The duplicated lines of code were commented out and the patch file
>>> works!
>>> >
>>> > _______________________________________________
>>> > its mailing list
>>> > its@ietf.org
>>> > https://www.ietf.org/mailman/listinfo/its
>>> >
>>>
>>> _______________________________________________
>>> its mailing list
>>> its@ietf.org
>>> https://www.ietf.org/mailman/listinfo/its
>>>
>> _______________________________________________
>> its mailing list
>> its@ietf.org
>> https://www.ietf.org/mailman/listinfo/its
>>
>
>
> --
> *Best regards*
>
>
> *Sara EL HAMDANI*
> *Phd student -Umi University.*
>


-- 
*Best regards*


*Sara EL HAMDANI*
*Phd student -Umi University.*