Re: [ipwave] Patching Linux Kernel with OCB

Alexandre Petrescu <alexandre.petrescu@gmail.com> Fri, 21 June 2019 10:59 UTC

Return-Path: <alexandre.petrescu@gmail.com>
X-Original-To: its@ietfa.amsl.com
Delivered-To: its@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B9B1120227 for <its@ietfa.amsl.com>; Fri, 21 Jun 2019 03:59:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.631
X-Spam-Level:
X-Spam-Status: No, score=-1.631 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0PpJW7ESaMyJ for <its@ietfa.amsl.com>; Fri, 21 Jun 2019 03:59:14 -0700 (PDT)
Received: from sainfoin-smtp-out.extra.cea.fr (sainfoin-smtp-out.extra.cea.fr [132.167.192.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 42200120228 for <its@ietf.org>; Fri, 21 Jun 2019 03:59:14 -0700 (PDT)
Received: from pisaure.intra.cea.fr (pisaure.intra.cea.fr [132.166.88.21]) by sainfoin-sys.extra.cea.fr (8.14.7/8.14.7/CEAnet-Internet-out-4.0) with ESMTP id x5LAxBmI028524 for <its@ietf.org>; Fri, 21 Jun 2019 12:59:11 +0200
Received: from pisaure.intra.cea.fr (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id C3BA3206133 for <its@ietf.org>; Fri, 21 Jun 2019 12:59:11 +0200 (CEST)
Received: from muguet2-smtp-out.intra.cea.fr (muguet2-smtp-out.intra.cea.fr [132.166.192.13]) by pisaure.intra.cea.fr (Postfix) with ESMTP id B880C206097 for <its@ietf.org>; Fri, 21 Jun 2019 12:59:11 +0200 (CEST)
Received: from [10.8.35.150] (is154594.intra.cea.fr [10.8.35.150]) by muguet2-sys.intra.cea.fr (8.14.7/8.14.7/CEAnet-Internet-out-4.0) with ESMTP id x5LAxBYh021777 for <its@ietf.org>; Fri, 21 Jun 2019 12:59:11 +0200
To: its@ietf.org
References: <CAM9JMHPbfhNgvDgJP3kMj7VG2DRGa6-t1bbfSrqHeGH62kW1Zg@mail.gmail.com> <CAJ0NgkCbYEV=OmteyqvrHZ8pnhNb7o5t4asxzmvLkZQXxjazHw@mail.gmail.com>
From: Alexandre Petrescu <alexandre.petrescu@gmail.com>
Message-ID: <55d53f81-7746-2be2-e882-28e7712951a5@gmail.com>
Date: Fri, 21 Jun 2019 12:59:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <CAJ0NgkCbYEV=OmteyqvrHZ8pnhNb7o5t4asxzmvLkZQXxjazHw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: fr
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/its/txU_kJ-_M8WVqmh259hMzx3o0eo>
Subject: Re: [ipwave] Patching Linux Kernel with OCB
X-BeenThere: its@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IPWAVE - IP Wireless Access in Vehicular Environments WG at IETF <its.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/its>, <mailto:its-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/its/>
List-Post: <mailto:its@ietf.org>
List-Help: <mailto:its-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/its>, <mailto:its-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2019 10:59:17 -0000


Le 20/06/2019 à 17:22, Sara el hamdani a écrit :
> Hi IPWAVERs,
> 
> I am in the same team in IPWave track with mister John on  
> Hackathon@AIS2019 (https://hackathon.internetsummitafrica.org/). I would 
> like to refer that we have tested the patch proposed by Alex in the 
> mailing list, but it just did not work for us. Instead, we have used the 
> old patch in the link 
> (https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view 
> <http://on:https//drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view>), 
> so we have discovered the bugs described above.
> I recommand anybody who needs to pach the kernel 4.9.61 with OCB mode 
> to use the old pach after fixing the bugs.

Hi Sara,

I thank you very much for the report.  It is good that you patch OCB for 
kernel 4.9.61.  It is a very recent kernel, although the most recent 
seems to be 5.1.12.

For information, I have been patching around the kernels since kernel 
version 3.x.  Before that, some people did it for kernels 2.x if I 
remember correctly.  A few patches existed in public and in private.  At 
my organisation we currently work with a private patch for kernel 
version 4.something.  It relies on the OCB options in the mainline 
kernel  There are other organisations on this email list that work with 
some other patches for 4.something.  There are also a few patches on 
github.com.  Some of them were originated by a Grand Challenge contest 
in Europe.

You now  mention the patch at 
https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view
I would like to ask you who created it?  (organisation, or group, or 
person name).

I would also like to ask you whether, in addition of the OCB patch, you 
also used the OCB options in the normal kernel configuration?  (did you 
do make menuconfig and checked 'OCB' in some option, or not at all?)

This OCB patch is worth setting aside somewhere on a fixed web page, so 
that everybody can use it.

There are many people who created OCB patches.  They seem to have a 
temporary interest in the matter: most of them no longer maintain their 
patches.  Each person starts from an earlier version, upgrade to most 
recent linux and then move on work on other topic.

Alex

> 
> ___
> Sara El Hamdani
> 
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> 
> 	Garanti sans virus. www.avast.com 
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> 
> 
> 
> <#m_1966153803618386632_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> 
> Le jeu. 20 juin 2019 à 15:25, John Seur <john.seur@gmail.com 
> <mailto:john.seur@gmail.com>> a écrit :
> 
>     Hello IPWavers,
> 
>     During the Hackathon@AIS2019
>     (https://hackathon.internetsummitafrica.org/), the team in IPWave
>     track (led by Nabil Benamar) was patching the Linux kernel 4.9.61
>     with OCB mode and discovered the following bugs in the patch file
>     (https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view).
>        drivers/net/wireless/ath/ath9k/main.c:961:2: error: duplicate
>     case value
>        case NL80211_IFTYPE_OCB:
>        drivers/net/wireless/ath/ath9k/hw.c:1241:2: error: duplicate case
>     value
>        case NL80211_IFTYPE_OCB:
> 
>     The duplicated lines of code were commented out and the patch file
>     works!
>     _______________________________________________
>     its mailing list
>     its@ietf.org <mailto:its@ietf.org>
>     https://www.ietf.org/mailman/listinfo/its
> 
> 
> 
> -- 
> *Best regards*
> *
> *
> /Sara EL HAMDANI
> /
> /Phd student -Umi University./
> 
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> 
> 	Garanti sans virus. www.avast.com 
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> 
> 
> 
> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> 
> _______________________________________________
> its mailing list
> its@ietf.org
> https://www.ietf.org/mailman/listinfo/its
>