Re: [Jcardcal] Genart LC review: draft-ietf-jcardcal-jcal-09

Philipp Kewisch <kewisch@gmail.com> Wed, 26 March 2014 15:25 UTC

Return-Path: <kewisch@gmail.com>
X-Original-To: jcardcal@ietfa.amsl.com
Delivered-To: jcardcal@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8AD21A00FB; Wed, 26 Mar 2014 08:25:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KV9JWjmQw8UC; Wed, 26 Mar 2014 08:25:56 -0700 (PDT)
Received: from mail-bk0-x236.google.com (mail-bk0-x236.google.com [IPv6:2a00:1450:4008:c01::236]) by ietfa.amsl.com (Postfix) with ESMTP id B68531A00E3; Wed, 26 Mar 2014 08:25:55 -0700 (PDT)
Received: by mail-bk0-f54.google.com with SMTP id 6so598113bkj.13 for <multiple recipients>; Wed, 26 Mar 2014 08:25:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=SPZQybOhD3qE9nB+TXv7yOZThAFH2nBphk6/+4Ff9sY=; b=bc7z2fP0i7R4LOp+f5RwKFz6rPqhutoFyVkv8FlN5utq6sSCcc7qHmSdShZDQl3AXm l+BTLOLiDIXzJlbpIRVi0u4Je/iymEdZ0dQUcLccriLD/E3sm4IY3PJJVSNrKmf4SgvJ ULjCCtwTMgBXqJl0SSW1YE7rI9paGc0oZ+PVrZokNMEnU/X89ZlBuWK2J9kM6Lu9/Rzv rC/kdm0WG2zQPqjfG1QxOZedZ0bPV5h9MjYm4DBsFLYpHtkxrlkjuVyAs5oMMer5sfre Y0+S52XR6d0v0YPePZS6MxgGfzINhWRv7X5JIP9JOR12SQc3Pp5pAqbzHOROkNRzfKYZ 1rgg==
X-Received: by 10.204.52.199 with SMTP id j7mr1363973bkg.57.1395847553717; Wed, 26 Mar 2014 08:25:53 -0700 (PDT)
Received: from [10.47.87.222] (tmo-111-7.customers.d1-online.com. [80.187.111.7]) by mx.google.com with ESMTPSA id xj2sm23745526bkb.15.2014.03.26.08.25.51 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 26 Mar 2014 08:25:52 -0700 (PDT)
References: <531F5C0D.5040903@nostrum.com> <532B5066.5050803@gmail.com> <532B69C8.305@nostrum.com> <532B792D.7010105@gmail.com> <532C3BC1.1000909@nostrum.com> <5332A5E7.6040403@gmail.com> <5332D481.5070207@nostrum.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <5332D481.5070207@nostrum.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Message-Id: <B62E4E93-87A1-40A5-81E0-3A1AD86A132C@gmail.com>
X-Mailer: iPhone Mail (11D169)
From: Philipp Kewisch <kewisch@gmail.com>
Date: Wed, 26 Mar 2014 16:25:46 +0100
To: Robert Sparks <rjsparks@nostrum.com>
Archived-At: http://mailarchive.ietf.org/arch/msg/jcardcal/4DbZ3hADOtnN8ausBrOa6DRG9ic
Cc: "draft-ietf-jcardcal-jcal@tools.ietf.org" <draft-ietf-jcardcal-jcal@tools.ietf.org>, "<gen-art@ietf.org> Team" <gen-art@ietf.org>, "jcardcal@ietf.org" <jcardcal@ietf.org>
Subject: Re: [Jcardcal] Genart LC review: draft-ietf-jcardcal-jcal-09
X-BeenThere: jcardcal@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: JSON data formats for vCard and iCalendar WG <jcardcal.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jcardcal>, <mailto:jcardcal-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/jcardcal/>
List-Post: <mailto:jcardcal@ietf.org>
List-Help: <mailto:jcardcal-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jcardcal>, <mailto:jcardcal-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Mar 2014 15:25:58 -0000

Ah ok, just listing the names again in a comment in the ABNF is easy enough, thats totally fine with me.

Thanks,
Philipp


> On Mar 26, 2014, at 14:22, Robert Sparks <rjsparks@nostrum.com> wrote:
> 
> I'll let you work that out with Pete.
> 
> If you do decide to list them, I wouldn't repeat their definition.
> The important thing is that you verified there wasn't anything left dangling.
> Thanks for taking the time to go through that again.
> 
> RjS
> 
>> On 3/26/14, 5:03 AM, Philipp Kewisch wrote:
>>> On 3/21/14, 2:16 PM, Robert Sparks wrote:
>>>> On 3/20/14, 6:26 PM, Philipp Kewisch wrote:
>>>> On 3/20/14, 11:20 PM, Robert Sparks wrote:
>>>>>> value-separator is defined in section 2 of rfc 7159.
>>>>> Provide that reference at the point it's used in the document please.
>>>> Just above the ABNF in the introduction to the section, I write "ABNF
>>>> Symbols not described here are taken from [RFC7159]". Isn't that
>>>> sufficient?
>>> I missed it. Others are likely to as well.
>>> Building an explicit list of what symbols you're counting on from that
>>> document
>>> would let you check that you haven't missed defining any others.
>>> Putting the list
>>> in the document will help others later find where to go when they're
>>> missing the
>>> symbol by using grep on this document.
>>> (You should have that list already from the ABNF verification step you
>>> performed).
>>>> Philipp
>> That list is quite a bit, I personally think the note at the beginning
>> of the section should be sufficient. Don't you think most implementers
>> will assume these rules belong to JSON and re-read the section if they
>> are really looking for why the rule is missing? If you think this is a
>> blocking issue, I'm happy to include it though.
>> 
>> ; These symbols originate from RFC7159 and are only
>> begin-array     = ws %x5B ws  ; [ left square bracket
>> begin-object    = ws %x7B ws  ; { left curly bracket
>> end-array       = ws %x5D ws  ; ] right square bracket
>> end-object      = ws %x7D ws  ; } right curly bracket
>> name-separator  = ws %x3A ws  ; : colon
>> value-separator = ws %x2C ws  ; , comma
>> string = quotation-mark *char quotation-mark
>> quotation-mark = %x22      ; "
>> ws = *( %x20 / %x09 / %x0A / %x0D ) ; Space, Horizontal tab, line feed
>>                                     ; or new line, carriage return
>> false = %x66.61.6c.73.65   ; false
>> true  = %x74.72.75.65      ; true
>> number = [ minus ] int [ frac ] [ exp ]
>> decimal-point = %x2E       ; .
>> digit1-9 = %x31-39         ; 1-9
>> e = %x65 / %x45            ; e E
>> exp = e [ minus / plus ] 1*DIGIT
>> frac = decimal-point 1*DIGIT
>> int = zero / ( digit1-9 *DIGIT )
>> minus = %x2D               ; -
>> plus = %x2B                ; +
>> zero = %x30                ; 0
>