[Jmap] Mahesh Jethanandani's Discuss on draft-ietf-jmap-contacts-09: (with DISCUSS and COMMENT)

[Mahesh Jethanandani via Datatracker <[e-mail]>]

Mahesh Jethanandani has entered the following ballot position for
draft-ietf-jmap-contacts-09: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-jmap-contacts/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

Thanks for the document. It was short and easy to read. The following two
DISCUSS should be easy to resolve with some additional text, or they could be
my lack of understanding of how JMAP works, in which case I would not mind
being educated.

Section 2.3, paragraph 3
>       If false, any attempt to destroy an AddressBook that still has
>       ContactCard in it will be rejected with an addressBookHasContents
>       SetError.  If true, any ContactCards that were in the AddressBook
>       will be removed from it, and if in no other AddressBooks they will
>       be destroyed.

The "if true" condition is not clear to me, especially if other AddressBooks
exist. There is a distinction that is being drawn between removing a
ContactCard and destroying it, which is not apparent. Can that distinction be
explained?

Related to that, it appears the ContactCards that were part of an AddressBook
that is being deleted, will be moved if another AddressBook exists. Which
AddressBook would that be? The default AddressBook? What happens if the default
AddressBook is being removed?

Section 3, paragraph 2
>    *  *addressBookIds*: Id[Boolean]
>       The set of AddressBook ids this ContactCard belongs to.  A card
>       MUST belong to at least one AddressBook at all times (until it is
>       destroyed).  The set is represented as an object, with each key
>       being an AddressBook id.  The value for each key in the object
>       MUST be true.

What happens if a ContactCard is removed from an AddressBook that is present in
multiple AddressBooks? Is it removed from all AddressBooks, or just one? If it
is removed from all AddressBooks, how does a user who wants to trim the
AddressBook to certain contacts remove a ContactCard?


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

The IANA review of this document seems to not have concluded yet.

-------------------------------------------------------------------------------
NIT
-------------------------------------------------------------------------------

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool) so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

Section 2, paragraph 12
> w AddressBooks created by the user themself. If false, the AddressBook and it
>                                    ^^^^^^^^
Generally speaking, "themself" is only acceptable when referring to a singular
entity (such as the singular usage of "they", which is the preferred pronoun
for many non-binary people). If "themself" refers to a plural entity (such as
"everybody", or the standard usage of "they"), you should use "themselves".

Section 2.3, paragraph 3
> s, it MUST be ignored and the currently default AddressBook (if any) will rem
>                               ^^^^^^^^^^^^^^^^^
You used an adverb ("currently") instead of an adjective, or a noun ("default")
instead of another adjective.