Re: [Jmap] Comments on draft-ietf-jmap-websocket-03

Ken Murchison <murch@fastmailteam.com> Tue, 05 November 2019 14:51 UTC

Return-Path: <murch@fastmailteam.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A00F2120C1D for <jmap@ietfa.amsl.com>; Tue, 5 Nov 2019 06:51:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmailteam.com header.b=pmqmF7e8; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=hhv2Yor0
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qgkLbhn6SlB4 for <jmap@ietfa.amsl.com>; Tue, 5 Nov 2019 06:51:32 -0800 (PST)
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8D0941208CB for <jmap@ietf.org>; Tue, 5 Nov 2019 06:36:31 -0800 (PST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8DD3A4A3; Tue, 5 Nov 2019 09:29:33 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 05 Nov 2019 09:29:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= fastmailteam.com; h=subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=fm1; bh=zkHgb37TlpMB9Wr6JGlqDnNgku tqSCJtzHlDIOrSK4E=; b=pmqmF7e88NpXTf+yyahE08RkwYP+5jr1m9se+3Cwoy 9Bom2YtXL6/5sGn99sho4eUt8o70Og5KlNQZhgF+lCVVDZNqok2+Cp/j4Rdu1ztZ dlwCWDQPXmThw0hwgz/XQRLMfDBJxWt+EHB+80FIud1CkRB/itUSiIC1zo0EMlbs TIoV71T8c4KztHSqRB+QCccmDhYJAvtX9LLy03zdL1uw7i2PCdiJG07FenFiAQon OY3uRcL6lrT2CgfNafgjEBbl7Inhdz7m9WpcYUCUm2NeQRl/4HrgABSPSC9d+Q9+ NprydOxgX+CQoaNllqaZGufyklt3rFgYEny701N3DjsQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=zkHgb37TlpMB9Wr6JGlqDnNgkutqSCJtzHlDIOrSK 4E=; b=hhv2Yor0RmoG5g3U5QypIj3yVHt++DZH2JoKKmzcWHc4Ve5H3P3zLGPwd if43y9L35u3aw9q1/Ay4Vsg96iXCgJfL75rZWtefmdrTsmH3TY7RAuhw//XjbS3R ENaelAVmQyIgxF924nqNvEeolvjNIdLFJtYWSsx7btmBET91GuSAT4fkYFmOQGDS il2NuobeHL9YPx+vniiDT7bkwtVhzFy7jOe+Yji/l230ngPq9OTWPPcCi+YmHfYP FsuCO+n2lSmRGLBY0aWhRQwA8A4gTthHFXsHbmGEaWvzOpPUCEiozD91ANNVC7Ug yGV0AhofnpzZNiAJCNsFxw//gKbdw==
X-ME-Sender: <xms:TIfBXT6XJFfSjYCPYkTdc4j6Dbh87ikADceLtEsUkBrrfMG23pVaxA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudduhedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvfhfhohfkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpefmvghn ucfouhhrtghhihhsohhnuceomhhurhgthhesfhgrshhtmhgrihhlthgvrghmrdgtohhmqe enucfkphepjeegrdejjedrkeehrddvhedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm uhhrtghhsehfrghsthhmrghilhhtvggrmhdrtghomhenucevlhhushhtvghrufhiiigvpe dt
X-ME-Proxy: <xmx:TIfBXcIhHGDdBPB3I-I79UdI7L-T6JvyPkUQUnkrD-JTjqrWoL_flA> <xmx:TIfBXT4v8XU29XiklkVTSRwuwJzIz9Ptn38C2Kpfr522AQDtO-VSPw> <xmx:TIfBXfxMrKNXLtyfUAhUWK4o5X7zhq_CKxVdtrXiC9QLvC5aerkzOg> <xmx:TYfBXX7yYbREFrgNtaEB94Wl41P1SuDesS71x-mUNrsA16zFiYBSbQ>
Received: from localhost.localdomain (cpe-74-77-85-250.buffalo.res.rr.com [74.77.85.250]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C6073060061; Tue, 5 Nov 2019 09:29:32 -0500 (EST)
To: Jim Fenton <fenton@bluepopcorn.net>, jmap@ietf.org
References: <652de948-53ba-ddb4-1c40-25df28b1c42e@bluepopcorn.net>
From: Ken Murchison <murch@fastmailteam.com>
Organization: FastMail US LLC
Message-ID: <1bb16b08-7c04-2ac0-334a-3fe95db1bb3c@fastmailteam.com>
Date: Tue, 05 Nov 2019 09:29:31 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <652de948-53ba-ddb4-1c40-25df28b1c42e@bluepopcorn.net>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/1tqbUVXoAiLwZiXz72qxSVtHRo0>
Subject: Re: [Jmap] Comments on draft-ietf-jmap-websocket-03
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2019 14:51:40 -0000

Hi Jim,

Thanks for the review.  Responses inline.



On 11/4/19 3:55 PM, Jim Fenton wrote:
> A few minor comments on the websocket-03 draft, currently in WGLC:
>
> - Section 2: I'm not sure what the reference [1] is about (and 
> correspondingly, the URIs section 8.3). I'd suggest leaving that out; 
> it seems to be confusing the idnits tool as well.


That was a function of using an <eref> for BCP 14.  I've removed that 
and just used plaintext instead.



>
> - Section 3: supportsWebSocketPush: The value is shown as "Boolean", 
> which would lead me to perhaps believe that it would be something like 
> "supportsWebSocketPush": "true" while the example doesn't have quotes 
> around "true". My inclination would be to leave off the quotes around 
> Boolean, but I'm not a JSON syntax expert by any stretch of the 
> imagination so decide accordingly.


I'm no JSON syntax expert either, but the use here is consistent with 
RFCs 8620 and 8621, so I think I'll keep it as-is.



>
> - Sections 4.2.2 and 4.2.3: requestId is shown as optional in the 
> response, and may only be included if there was a requestId in the 
> request. If there is a requestId in the request, should the requestId 
> be mandatory in the response? I think it should.


I agree.  I've changed this to be "(optional; MUST be returned if given 
in the request)"



>
> - Next time you're making an update, please change the reference to 
> jmap-mail to RFC 8621.


Done.


-- 

Ken Murchison
Cyrus Development Team
FastMail US LLC