Re: [Jmap] Lars Eggert's No Objection on draft-ietf-jmap-quotas-10: (with COMMENT)

rcordier@linagora.com Tue, 31 January 2023 07:28 UTC

Return-Path: <rcordier@linagora.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79942C14CF15; Mon, 30 Jan 2023 23:28:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.693
X-Spam-Level:
X-Spam-Status: No, score=-6.693 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=neutral reason="invalid (public key: not available)" header.d=linagora.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RdLuyWgyMMbq; Mon, 30 Jan 2023 23:27:55 -0800 (PST)
Received: from smtp.linagora.com (smtp.linagora.com [54.36.8.78]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 30D30C14E514; Mon, 30 Jan 2023 23:27:48 -0800 (PST)
Received: from ?Open?PaaS?SMTP?server?for?Linagora? (unknown [51.83.109.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.linagora.com (Postfix) with ESMTPSA id 59BAE3EE62; Tue, 31 Jan 2023 08:27:46 +0100 (CET)
DKIM-Signature: a=rsa-sha256; b=p0/Z6bYEhE0OqWJ0LgqW94P/DpOcx2mc0byZPMN+R90vSG0awHjyh/ZHhzzsOvaR6aKURMHzrYTLGJkbR1ejRNPxQQy+W8iKuq41Uh8W/5dwdWTRuyJMvY7UvzDEwYWsZ3yS5ZxNf7NsagaaVE+j1GJ+mnqoymYm/ghnxJNalvf03G3jYo6nfqwLdTSGgxOv7ZxIQbAQZPa5iCWYBdhpVqYK0wVXWOojzC3qoZIbtfiyUjNgft0CBPVy1rCdo6+nEhD7TT0Y6hGAFrP3nqAFDB2v/HGZlJwrqYgI8cM61s8a8X66467AiZ+6dQ+WvpkwQO98dvEliUN4aFPMLzho9A==; s=smtpoutjames; d=linagora.com; v=1; bh=qg8UMoSM5NUpdynofNfb+mqNP0aHcuUfAMKZSc4iKco=; h=from : reply-to : subject : date : to : cc : resent-date : resent-from : resent-sender : resent-to : resent-cc : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive;
Date: Tue, 31 Jan 2023 07:27:46 +0000
Message-ID: <603376924.63.1675150066918@212e230e4d2f>
MIME-Version: 1.0
X-LINAGORA-Copy-Delivery-Done: 1
From: rcordier@linagora.com
To: The IESG <iesg@ietf.org>, Lars Eggert via Datatracker <noreply@ietf.org>
Cc: draft-ietf-jmap-quotas@ietf.org, jmap-chairs@ietf.org, jmap@ietf.org, brong@fastmailteam.com
Reply-To: rcordier@linagora.com
User-Agent: Team-Mail/0.5.2 Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36
Content-Type: multipart/alternative; boundary="-=Part.1f1.96e0d0c76b7fdd4a.18606b982e5.9a5b625b02adc950=-"
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/G0JSOV1PU2J7u-mcFQ68rEJ9wv0>
Subject: Re: [Jmap] Lars Eggert's No Objection on draft-ietf-jmap-quotas-10: (with COMMENT)
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jan 2023 07:28:00 -0000

Hello Lars,

Sorry for the late response and thank you for the review and feedback!

I added the missing reference and fixed most of the nits as it made sense to me, in the latest version 11 of the draft.

+ Missing reference fix: https://github.com/jmapio/jmap/pull/376/commits/b614c4be11002229fea0ba4ef59c95a4f58a8679

+ Nits: https://github.com/jmapio/jmap/pull/376/commits/c8e92af7624d56cd7ab1ecec54358069e55e14f7

Best regards,

Rene.

On Dec 12, 2022 7:40 PM, from Lars Eggert Via Datatracker Lars Eggert has entered the following ballot position for
draft-ietf-jmap-quotas-10: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-jmap-quotas/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-jmap-quotas-10

CC @larseggert

Thanks to Thomas Fossati for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/oAEgfTC3LDk7eMWyNgtNlOTv8oE).
I have not seen a public response to his review of -06?

## Comments

### Missing references

No reference entries found for: `[RFC9110]`.

### Inclusive language

Found terminology that should be reviewed for inclusivity; see
https://www.rfc-editor.org/part2/#inclusive_language for background and more
guidance:

 * Term `he`; alternatives might be `they`, `them`, `their`

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Grammar/style

#### Section 4, paragraph 16
```
softLimit" (if present and different than null) and the "limit". * softLimit
                                     ^^^^
```
Did you mean "different from"? "Different than" is often considered colloquial
style.

#### Section 4, paragraph 19
```
warnLimit" (if present and different than null) but lower than the "limit".
                                     ^^^^
```
Did you mean "different from"? "Different than" is often considered colloquial
style.

#### Section 4, paragraph 21
```
 "String|null" Arbitrary free, human readable, description of this quota. It
                               ^^^^^^^^^^^^^^
```
This word is normally spelled with a hyphen.

#### Section 4, paragraph 23
```
ull. Since "used" frequently changes but other properties are generally only
                                    ^^^^
```
Use a comma before "but" if it connects two independent clauses (unless they
are closely connected and short).

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool