[Jmap] Opsdir last call review of draft-ietf-jmap-smime-07

Menachem Dodge via Datatracker <noreply@ietf.org> Wed, 01 September 2021 08:13 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: jmap@ietf.org
Delivered-To: jmap@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 85BF63A0E74; Wed, 1 Sep 2021 01:13:33 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Menachem Dodge via Datatracker <noreply@ietf.org>
To: <ops-dir@ietf.org>
Cc: draft-ietf-jmap-smime.all@ietf.org, jmap@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.36.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <163048401349.30297.15336218793544457746@ietfa.amsl.com>
Reply-To: Menachem Dodge <menachemdodge1@gmail.com>
Date: Wed, 01 Sep 2021 01:13:33 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/LIEsHR6yHCMS3APC_pMazDLNTTs>
Subject: [Jmap] Opsdir last call review of draft-ietf-jmap-smime-07
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Sep 2021 08:13:34 -0000

Reviewer: Menachem Dodge
Review result: Has Nits

I have reviewed this document as part of the Operational directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written with the intent of improving the operational aspects of
the IETF drafts. Comments that are not addressed in last call may be included
in AD reviews during the IESG review.  Document editors and WG chairs should
treat these comments just like any other last call comments.

The document explains the need to add an extension to JMAP for returning S/MIME
signature verification status. The document is written clearly.

Please consider whether the document header should indicate "Updates: 8621".

Nits:

1. Section 4:  Paragraph 5 - *smimeStatusAtDelivery*:
The brackets:

OLD==> (It effectively the same as "smimeStatus" value
 calculated at the date/time of deliver, as specified by
 "receivedAt".)
Suggested==> (It is effectively the same as the "smimeStatus" value
 calculated at the date/time of delivery, as specified by "receivedAt".)

2. Section 4: Paragraph 7 beginning with ' smimeStatus: "String|null". '
OLD==> ' Client MUST treat unrecognized values as "unknown" or "signed/failed".
' SUGGESTED==> ' Clients MUST treat unrecognized values as "unknown" or
"signed/failed". '

3. Section 4: Paragraphs 8,9,10 and 11. Missing colon following the first word
of the paragraph, this word being the possible string values of the property.
 Suggest that it be:        "unknown:" , "signed:" , signed/verified:", 
 "signed/failed:"

4. It would be useful to add additional actual examples of  messages - and to
refer to them in the text. So for the paragraph on "smimeErrors" it would be
useful to refer to the Example 2 below. It would be good to have an additional
example  showing the case where: "For example, the signing certificate might be
 expired and the message From email address might not correspond to
 any of the email addresses in the signing certificate."

5. In section 6 "Security Considerations" - it would be nice to have some
additional explanation of the recommendation to cache the results for 10
minutes. Is this to be done on the server side or at the client? Should there
be a reference here to other documents on signature verification?

Thank you kindly.

Menachem Dodge